[M138-LTS][bindings] Retain underlying array buffer for [PassAsSpan] arrays... [chromium/src : refs/branch-heads/7204]

0 views
Skip to first unread message

Tiago Vignatti (xWF) (Gerrit)

unread,
Apr 1, 2026, 10:46:54 AM (20 hours ago) Apr 1
to Andrey Kosyakov, Victor Gabriel Savu, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Andrey Kosyakov and Victor Gabriel Savu

Tiago Vignatti (xWF) added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tiago Vignatti (xWF) . resolved

The bug was approved for M138 LTS. PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Victor Gabriel Savu
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7204
Gerrit-Change-Id: I7a815f0537073b39d9da1d9ab99de7cf44f78646
Gerrit-Change-Number: 7715730
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Victor Gabriel Savu <vs...@google.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 14:46:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Victor Gabriel Savu (Gerrit)

unread,
Apr 1, 2026, 10:54:34 AM (20 hours ago) Apr 1
to Tiago Vignatti (xWF), Andrey Kosyakov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Andrey Kosyakov and Tiago Vignatti (xWF)

Victor Gabriel Savu voted and added 1 comment

Votes added by Victor Gabriel Savu

Code-Review+1
Owners-Override+1

1 comment

Patchset-level comments
Victor Gabriel Savu . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Tiago Vignatti (xWF)
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7204
Gerrit-Change-Id: I7a815f0537073b39d9da1d9ab99de7cf44f78646
Gerrit-Change-Number: 7715730
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 14:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tiago Vignatti (xWF) (Gerrit)

unread,
Apr 1, 2026, 1:29:35 PM (17 hours ago) Apr 1
to Andrey Kosyakov, Victor Gabriel Savu, AyeAye, Chromium LUCI CQ, Kentaro Hara, Raphael Kubo da Costa, blink-...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org
Attention needed from Andrey Kosyakov and Victor Gabriel Savu

Tiago Vignatti (xWF) added 1 comment

Patchset-level comments
Tiago Vignatti (xWF) . resolved

The bug was approved for M138 LTS. PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Victor Gabriel Savu
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7204
Gerrit-Change-Id: Ic0bb40da3308da8773d8c2e62b3de3652fd84485
Gerrit-Change-Number: 7634838
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Victor Gabriel Savu <vs...@google.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 17:29:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Gabriel Savu (Gerrit)

unread,
Apr 1, 2026, 2:13:19 PM (17 hours ago) Apr 1
to Andrey Kosyakov, Tiago Vignatti (xWF), AyeAye, Chromium LUCI CQ, Kentaro Hara, Raphael Kubo da Costa, blink-...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org
Attention needed from Andrey Kosyakov and Tiago Vignatti (xWF)

Victor Gabriel Savu voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Tiago Vignatti (xWF)
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7204
Gerrit-Change-Id: Ic0bb40da3308da8773d8c2e62b3de3652fd84485
Gerrit-Change-Number: 7634838
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 18:13:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Apr 1, 2026, 2:38:22 PM (16 hours ago) Apr 1
to Tiago Vignatti (xWF), Victor Gabriel Savu, AyeAye, Chromium LUCI CQ, Kentaro Hara, Raphael Kubo da Costa, blink-...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org
Attention needed from Tiago Vignatti (xWF)

Andrey Kosyakov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tiago Vignatti (xWF)
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7204
Gerrit-Change-Id: Ic0bb40da3308da8773d8c2e62b3de3652fd84485
Gerrit-Change-Number: 7634838
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 18:38:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Apr 1, 2026, 2:40:16 PM (16 hours ago) Apr 1
to Tiago Vignatti (xWF), Victor Gabriel Savu, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Tiago Vignatti (xWF)

Andrey Kosyakov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tiago Vignatti (xWF)
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedLint
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7204
    Gerrit-Change-Id: I7a815f0537073b39d9da1d9ab99de7cf44f78646
    Gerrit-Change-Number: 7715730
    Gerrit-PatchSet: 2
    Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 18:40:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Tiago Vignatti (xWF) (Gerrit)

    unread,
    Apr 1, 2026, 3:04:30 PM (16 hours ago) Apr 1
    to Andrey Kosyakov, Victor Gabriel Savu, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org

    Tiago Vignatti (xWF) voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedLint
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7204
    Gerrit-Change-Id: I7a815f0537073b39d9da1d9ab99de7cf44f78646
    Gerrit-Change-Number: 7715730
    Gerrit-PatchSet: 2
    Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 19:04:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 1, 2026, 4:54:02 PM (14 hours ago) Apr 1
    to Tiago Vignatti (xWF), Andrey Kosyakov, Victor Gabriel Savu, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [M138-LTS][bindings] Retain underlying array buffer for [PassAsSpan] arrays...

    if re-entry into JS is possible while converting other params or within the function

    Bug: 484946544
    Change-Id: I7a815f0537073b39d9da1d9ab99de7cf44f78646
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7595948
    Reviewed-by: Nate Chapin <jap...@chromium.org>
    Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
    Reviewed-by: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1589594}

    (cherry picked from commit ec1a6357e246afedf1e57c6e050c47d12f703003)
    Change-Id: I7a815f0537073b39d9da1d9ab99de7cf44f78646
    Owners-Override: Victor Gabriel Savu <vs...@google.com>
    Reviewed-by: Victor Gabriel Savu <vs...@google.com>
    Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
    Commit-Queue: Tiago Vignatti (xWF) <vign...@google.com>
    Cr-Commit-Position: refs/branch-heads/7204@{#3510}
    Cr-Branched-From: d5de512dc9dc8ddfe4e6d71b0637578bb6158683-refs/heads/main@{#1465706}
    Files:
    • M PRESUBMIT.py
    • M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl.cc
    • M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl.h
    • M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl_test.cc
    • M third_party/blink/renderer/bindings/core/v8/pass_as_span.h
    • M third_party/blink/renderer/bindings/scripts/bind_gen/blink_v8_bridge.py
    • M third_party/blink/web_tests/external/wpt/encoding/textdecoder-arguments.any.js
    Change size: M
    Delta: 7 files changed, 141 insertions(+), 48 deletions(-)
    Branch: refs/branch-heads/7204
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Andrey Kosyakov, +1 by Victor Gabriel Savu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7204
    Gerrit-Change-Id: I7a815f0537073b39d9da1d9ab99de7cf44f78646
    Gerrit-Change-Number: 7715730
    Gerrit-PatchSet: 3
    Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages