WTF: Remove Characters8() and Characters16() of String and StringImpl [chromium/src : main]

33 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Mar 30, 2026, 4:03:27 AM (3 days ago) Mar 30
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic05c20262f89ec8ad8c4bb72ca1e3776d4c44270
Gerrit-Change-Number: 7707440
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Mon, 30 Mar 2026 08:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Mar 30, 2026, 4:45:51 AM (3 days ago) Mar 30
to Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic05c20262f89ec8ad8c4bb72ca1e3776d4c44270
    Gerrit-Change-Number: 7707440
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 30 Mar 2026 08:45:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 30, 2026, 4:50:19 AM (3 days ago) Mar 30
    to Kent Tamura, Fredrik Söderquist, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WTF: Remove Characters8() and Characters16() of String and StringImpl

    These methods are superseded by `Span8()` and `Span16()` which return
    `base::span` objects.
    Bug: 451652367
    Change-Id: Ic05c20262f89ec8ad8c4bb72ca1e3776d4c44270
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1606964}
    Files:
    • M third_party/blink/renderer/core/inspector/v8_inspector_string.h
    • M third_party/blink/renderer/platform/bindings/parkable_string_test.cc
    • M third_party/blink/renderer/platform/text/segmented_string.h
    • M third_party/blink/renderer/platform/wtf/text/string_impl.h
    • M third_party/blink/renderer/platform/wtf/text/wtf_string.h
    Change size: S
    Delta: 5 files changed, 13 insertions(+), 34 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic05c20262f89ec8ad8c4bb72ca1e3776d4c44270
    Gerrit-Change-Number: 7707440
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages