[defer-import-eval] Add Blink integration for dynamic import.defer [chromium/src : main]
0 views
Skip to first unread message
Olivier Flückiger (Gerrit)
Feb 20, 2026, 5:07:34 AMFeb 20
to Caio Lima, Leszek Swirski, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, Kentaro Hara and Leszek Swirski
Olivier Flückiger added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Olivier Flückiger . resolved
lgtm for what it's worth. adding reviewers, since I am not a chromium reviewer.
File third_party/blink/web_tests/wpt_internal/js/import-defer/resources/side-effect-module.js
Line 2, Patchset 1 (Latest):
export const value = 42;Olivier Flückiger . unresolved
could you add another test that has a TLA so we can make sure the eager evaluation part works?
Related details
Attention is currently required from:
- Caio Lima
- Kentaro Hara
- Leszek Swirski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Caio Lima (Gerrit)
Feb 27, 2026, 9:59:29 AM (14 days ago) Feb 27
to Leszek Swirski, Kentaro Hara, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Kentaro Hara, Leszek Swirski and Olivier Flückiger
Caio Lima added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Caio Lima . resolved
Thanks for the review! Looks like I'm still missing a CO to third_party/blink/web_tests/VirtualTestSuites. Do you know who I could include here?
File third_party/blink/web_tests/wpt_internal/js/import-defer/resources/side-effect-module.js
could you add another test that has a TLA so we can make sure the eager evaluation part works?
Attention is currently required from:
- Kentaro Hara
- Leszek Swirski
- Olivier Flückiger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Feb 27, 2026, 10:05:08 AM (14 days ago) Feb 27
to Caio Lima, David Baron, Kentaro Hara, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, David Baron, Kentaro Hara and Olivier Flückiger
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Caio Lima
- David Baron
- Kentaro Hara
- Olivier Flückiger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Feb 27, 2026, 10:14:22 AM (14 days ago) Feb 27
to Caio Lima, David Baron, Leszek Swirski, Kentaro Hara, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, Kentaro Hara and Olivier Flückiger
David Baron voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Baron
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Caio Lima
- Kentaro Hara
- Olivier Flückiger
Olivier Flückiger (Gerrit)
Feb 27, 2026, 10:45:10 AM (13 days ago) Feb 27
to Caio Lima, Kouhei Ueno, David Baron, Leszek Swirski, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, Kouhei Ueno and Leszek Swirski
Olivier Flückiger added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Olivier Flückiger . resolved
Talked offline to Kouhei, he should be able to do a review next week.
Related details
Attention is currently required from:
- Caio Lima
- Kouhei Ueno
- Leszek Swirski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
Mar 5, 2026, 5:14:40 PM (7 days ago) Mar 5
to Caio Lima, Kouhei Ueno, David Baron, Leszek Swirski, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, Kouhei Ueno and Leszek Swirski
Hiroshige Hayashizaki added 5 comments![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
Basically looks good.
File third_party/blink/renderer/bindings/core/v8/module_record.h
Line 81, Patchset 2 (Latest):
v8::ModuleImportPhase import_phase = v8::ModuleImportPhase::kEvaluation);Hiroshige Hayashizaki . unresolved
Could you remove the default `kEvaluation` to avoid possible import phase mismatch?
File third_party/blink/renderer/bindings/core/v8/v8_script_runner.h
Line 146, Patchset 2 (Latest):
v8::ModuleImportPhase phase = v8::ModuleImportPhase::kEvaluation);Hiroshige Hayashizaki . unresolved
ditto, Could you remove the default `kEvaluation` to avoid possible import phase mismatch?
File third_party/blink/renderer/core/script/module_script.h
Line 80, Patchset 2 (Latest):
[[nodiscard]] ScriptEvaluationResult EvaluateForImportPhase(Hiroshige Hayashizaki . unresolved
nit: I prefer a name like `RunScriptOnScriptStateAndReturnValueWithImportPhase()`
to clarify this is mostly just adding import phase arg to `RunScriptOnScriptStateAndReturnValue()`.
(The name is long, but shouldn't be a large problem as we only have two callers)
File third_party/blink/renderer/core/script/module_script.cc
Line 141, Patchset 2 (Latest):
DCHECK_EQ(execute_script_policy,Hiroshige Hayashizaki . unresolved
Drive-by: could you use `CHECK()` here?
Related details
Attention is currently required from:
- Caio Lima
- Kouhei Ueno
- Leszek Swirski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
Mar 5, 2026, 5:16:57 PM (7 days ago) Mar 5
to Caio Lima, Takashi Nakayama, Kouhei Ueno, David Baron, Leszek Swirski, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, Kouhei Ueno, Leszek Swirski and Takashi Nakayama
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Caio Lima
- Kouhei Ueno
- Leszek Swirski
- Takashi Nakayama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
Mar 5, 2026, 5:23:11 PM (7 days ago) Mar 5
to Caio Lima, Takashi Nakayama, Kouhei Ueno, David Baron, Leszek Swirski, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, Kouhei Ueno, Leszek Swirski and Takashi Nakayama
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/wpt_internal/js/import-defer/basic-deferred-evaluation.html
Line 1, Patchset 2 (Latest):
<!doctype html>Hiroshige Hayashizaki . unresolved
Can we move the tests to public WPT
(under `third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/module/`)?
We can mark the tests as `tentative`
https://web-platform-tests.org/writing-tests/file-names.html#test-features
Caio Lima (Gerrit)
Mar 6, 2026, 7:47:03 AM (7 days ago) Mar 6
to Takashi Nakayama, Hiroshige Hayashizaki, Kouhei Ueno, David Baron, Leszek Swirski, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Hiroshige Hayashizaki, Kouhei Ueno, Leszek Swirski and Takashi Nakayama
Caio Lima added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/wpt_internal/js/import-defer/basic-deferred-evaluation.html
Line 1, Patchset 2 (Latest):
<!doctype html>Hiroshige Hayashizaki . unresolved
Can we move the tests to public WPT
(under `third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/module/`)?We can mark the tests as `tentative`
https://web-platform-tests.org/writing-tests/file-names.html#test-features
Caio Lima
Sure. One question that I have is that this test right now fails, because we have the flag disabled when running this test here. Should we keep the expected like that as well? Additionally, show we also move the TLA version?
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
Caio Lima (Gerrit)
Mar 6, 2026, 9:26:07 AM (7 days ago) Mar 6
to AyeAye, Takashi Nakayama, Hiroshige Hayashizaki, Kouhei Ueno, David Baron, Leszek Swirski, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from David Baron, Hiroshige Hayashizaki, Kouhei Ueno, Leszek Swirski and Takashi Nakayama
Caio Lima added 6 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Caio Lima . resolved
Thank you very much for the reviews so far.
I see that I'm now missing owner to review the flag override between Chromium and V8. Could you help me find somebody that could review this part, please?
File third_party/blink/renderer/bindings/core/v8/module_record.h
Line 81, Patchset 2:
v8::ModuleImportPhase import_phase = v8::ModuleImportPhase::kEvaluation);Hiroshige Hayashizaki . resolved
Could you remove the default `kEvaluation` to avoid possible import phase mismatch?
Caio Lima
Done
File third_party/blink/renderer/bindings/core/v8/v8_script_runner.h
Line 146, Patchset 2:
v8::ModuleImportPhase phase = v8::ModuleImportPhase::kEvaluation);Hiroshige Hayashizaki . resolved
ditto, Could you remove the default `kEvaluation` to avoid possible import phase mismatch?
Caio Lima
Done
File third_party/blink/renderer/core/script/module_script.h
Line 80, Patchset 2:
[[nodiscard]] ScriptEvaluationResult EvaluateForImportPhase(Hiroshige Hayashizaki . resolved
nit: I prefer a name like `RunScriptOnScriptStateAndReturnValueWithImportPhase()`
to clarify this is mostly just adding import phase arg to `RunScriptOnScriptStateAndReturnValue()`.(The name is long, but shouldn't be a large problem as we only have two callers)
Caio Lima
Acknowledged
File third_party/blink/renderer/core/script/module_script.cc
Drive-by: could you use `CHECK()` here?
Caio Lima
Done
File third_party/blink/web_tests/wpt_internal/js/import-defer/basic-deferred-evaluation.html
Line 1, Patchset 2:
<!doctype html>Hiroshige Hayashizaki . unresolved
Caio LimaCan we move the tests to public WPT
(under `third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/module/`)?We can mark the tests as `tentative`
https://web-platform-tests.org/writing-tests/file-names.html#test-features
Sure. One question that I have is that this test right now fails, because we have the flag disabled when running this test here. Should we keep the expected like that as well? Additionally, show we also move the TLA version?
Attention is currently required from:
- David Baron
- Hiroshige Hayashizaki
- Kouhei Ueno
- Leszek Swirski
- Takashi Nakayama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Mar 6, 2026, 9:26:39 AM (7 days ago) Mar 6
to Caio Lima, David Baron, AyeAye, Takashi Nakayama, Hiroshige Hayashizaki, Kouhei Ueno, Leszek Swirski, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, Hiroshige Hayashizaki, Kouhei Ueno, Leszek Swirski and Takashi Nakayama
David Baron voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Baron
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Caio Lima
Olivier Flückiger (Gerrit)
12:29 PM (11 hours ago) 12:29 PM
to Caio Lima, Kentaro Hara, David Baron, AyeAye, Takashi Nakayama, Hiroshige Hayashizaki, Kouhei Ueno, Leszek Swirski, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org
Attention needed from Caio Lima, Hiroshige Hayashizaki, Kentaro Hara, Kouhei Ueno, Leszek Swirski and Takashi Nakayama
Olivier Flückiger added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Olivier Flückiger . resolved
+Kentaro for content/renderer/render_process_impl
Related details
Attention is currently required from:
- Caio Lima
- Hiroshige Hayashizaki
- Kentaro Hara
- Kouhei Ueno
- Leszek Swirski
- Takashi Nakayama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages