Reland "WebGPU: Match WGSL syntax for texture component swizzle" [chromium/src : main]

0 views
Skip to first unread message

Fr (Gerrit)

unread,
Sep 25, 2025, 11:55:47 AM (11 days ago) Sep 25
to AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, Corentin Wallez, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kainin...@chromium.org, blink-revie...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org
Attention needed from Kai Ninomiya

Fr added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Fr . resolved

PTAL. The diff between this and the other CL is the fact that we now return true when the experimental feature is not enabled when validating the swizzle. See https://chromium-review.googlesource.com/c/chromium/src/+/6958569/11/third_party/blink/renderer/modules/webgpu/gpu_texture.cc#120

Open in Gerrit

Related details

Attention is currently required from:
  • Kai Ninomiya
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7d7141e1aec7a6801c5700152058c869117367e
Gerrit-Change-Number: 6983268
Gerrit-PatchSet: 2
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Corentin Wallez <cwa...@chromium.org>
Gerrit-CC: Gregg Tavares <gm...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kai Ninomiya <kai...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Corentin Wallez (Gerrit)

unread,
Sep 25, 2025, 11:56:48 AM (11 days ago) Sep 25
to Fr, AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kainin...@chromium.org, blink-revie...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org
Attention needed from Fr and Kai Ninomiya

Corentin Wallez voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fr
  • Kai Ninomiya
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7d7141e1aec7a6801c5700152058c869117367e
Gerrit-Change-Number: 6983268
Gerrit-PatchSet: 2
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Gregg Tavares <gm...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Fr <beaufort...@gmail.com>
Gerrit-Attention: Kai Ninomiya <kai...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:56:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Corentin Wallez (Gerrit)

unread,
Sep 25, 2025, 11:57:28 AM (11 days ago) Sep 25
to Fr, AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kainin...@chromium.org, blink-revie...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org
Attention needed from Fr and Kai Ninomiya

Corentin Wallez added 1 comment

Patchset-level comments
Fr . resolved

PTAL. The diff between this and the other CL is the fact that we now return true when the experimental feature is not enabled when validating the swizzle. See https://chromium-review.googlesource.com/c/chromium/src/+/6958569/11/third_party/blink/renderer/modules/webgpu/gpu_texture.cc#120

Corentin Wallez

Please double check that the fix between PS1 and PS2 actually fixes the issue that we saw.

Gerrit-Comment-Date: Thu, 25 Sep 2025 15:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fr <beaufort...@gmail.com>
satisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Sep 25, 2025, 2:22:15 PM (10 days ago) Sep 25
to Peter McNeeley, Fr, Chromium LUCI CQ, Corentin Wallez, Kai Ninomiya, AyeAye, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, jmedle...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, blink-revie...@chromium.org, kainin...@chromium.org
Attention needed from Corentin Wallez, Fr and Kai Ninomiya

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Corentin Wallez
  • Fr
  • Kai Ninomiya
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icec5322e142569fe424d43aa4237281957365b69
Gerrit-Change-Number: 6985464
Gerrit-PatchSet: 1
Gerrit-Owner: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
Gerrit-Reviewer: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Gregg Tavares <gm...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Fr <beaufort...@gmail.com>
Gerrit-Attention: Corentin Wallez <cwa...@chromium.org>
Gerrit-Attention: Kai Ninomiya <kai...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 18:22:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fr (Gerrit)

unread,
Sep 26, 2025, 4:30:14 AM (10 days ago) Sep 26
to Corentin Wallez, AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kainin...@chromium.org, blink-revie...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org
Attention needed from Kai Ninomiya

Fr voted and added 1 comment

Votes added by Fr

Commit-Queue+2

1 comment

Patchset-level comments
Fr . resolved

PTAL. The diff between this and the other CL is the fact that we now return true when the experimental feature is not enabled when validating the swizzle. See https://chromium-review.googlesource.com/c/chromium/src/+/6958569/11/third_party/blink/renderer/modules/webgpu/gpu_texture.cc#120

Corentin Wallez

Please double check that the fix between PS1 and PS2 actually fixes the issue that we saw.

Fr

I've tried it locally with and without `--enable-unsafe-webgpu`

Open in Gerrit

Related details

Attention is currently required from:
  • Kai Ninomiya
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7d7141e1aec7a6801c5700152058c869117367e
Gerrit-Change-Number: 6983268
Gerrit-PatchSet: 2
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
Gerrit-Reviewer: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Gregg Tavares <gm...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kai Ninomiya <kai...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 08:29:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Fr <beaufort...@gmail.com>
Comment-In-Reply-To: Corentin Wallez <cwa...@chromium.org>
satisfied_requirement
open
diffy

Fr (Gerrit)

unread,
Sep 26, 2025, 6:11:05 AM (10 days ago) Sep 26
to Corentin Wallez, AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kainin...@chromium.org, blink-revie...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org
Attention needed from Kai Ninomiya

Fr voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Fri, 26 Sep 2025 10:10:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 26, 2025, 6:14:02 AM (10 days ago) Sep 26
to Fr, Corentin Wallez, AyeAye, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kainin...@chromium.org, blink-revie...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Reland "WebGPU: Match WGSL syntax for texture component swizzle"

This is a reland of commit bc29fd445d6788ddb0dfbe7b97ad1b2045de599d

Original change's description:
> WebGPU: Match WGSL syntax for texture component swizzle
>
> Spec PR: https://github.com/gpuweb/gpuweb/pull/5319
> CTS: https://github.com/gpuweb/cts/pull/4427
>
> Change-Id: Ie398159c52e76839c2cd91bbf3ecf04a77568e19
> Bug: 414312052
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6958569
> Reviewed-by: Kai Ninomiya <kai...@chromium.org>
> Commit-Queue: Fr <beaufort...@gmail.com>
> Cr-Commit-Position: refs/heads/main@{#1519112}
Bug: 414312052
Change-Id: Ia7d7141e1aec7a6801c5700152058c869117367e
Reviewed-by: Corentin Wallez <cwa...@chromium.org>
Commit-Queue: Fr <beaufort...@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1521159}
Files:
  • M third_party/blink/renderer/bindings/generated_in_modules.gni
  • M third_party/blink/renderer/modules/webgpu/dawn_enum_conversions.cc
  • M third_party/blink/renderer/modules/webgpu/dawn_enum_conversions.h
  • M third_party/blink/renderer/modules/webgpu/gpu_texture.cc
  • M third_party/blink/renderer/modules/webgpu/gpu_texture_view_descriptor.idl
Change size: M
Delta: 5 files changed, 53 insertions(+), 45 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Corentin Wallez
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7d7141e1aec7a6801c5700152058c869117367e
Gerrit-Change-Number: 6983268
Gerrit-PatchSet: 3
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages