gamepad: Implement connected and disconnected WindowEventHandlers [chromium/src : main]

[Orko Garai (Gerrit)]

Attention needed from Matt Reynolds

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Matt Reynolds

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 2

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Comment-Date: Thu, 25 Sep 2025 20:51:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Matt Reynolds (Gerrit)]

Attention needed from Orko Garai

Matt Reynolds voted and added 1 comment

Votes added by Matt Reynolds

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Matt Reynolds . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Orko Garai

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 2

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Orko Garai <or...@igalia.com>

Gerrit-Comment-Date: Thu, 25 Sep 2025 21:07:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Matt Reynolds (Gerrit)]

Attention needed from Orko Garai

Matt Reynolds voted and added 3 comments

Votes added by Matt Reynolds

Code-Review

+0

3 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Matt Reynolds . resolved

(un-lgtm due to missing launch approval)

The code changes seem good but please modify the CL so the feature is default-disabled.

File third_party/blink/renderer/modules/gamepad/window_gamepad.idl

Line 8, Patchset 2 (Latest): attribute EventHandler ongamepadconnected;
attribute EventHandler ongamepaddisconnected;

Matt Reynolds . unresolved

These attributes should have a [RuntimeEnabled=] extended attribute to keep them turned off until the feature is launched.

File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Line 3355, Patchset 2 (Latest): getter ongamepadconnected
getter ongamepaddisconnected

Matt Reynolds . unresolved

Changes to stable webexposed expectations need launch approval. Please add a feature in runtime_enabled_features.json5, initially "experimental", and remove the changes in virtual/stable/webexposed expectations for now.

Open in Gerrit

Related details

Attention is currently required from:

• Orko Garai

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 2

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Orko Garai <or...@igalia.com>

Gerrit-Comment-Date: Thu, 25 Sep 2025 21:24:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Orko Garai (Gerrit)]

Attention needed from Matt Reynolds

Orko Garai added 1 comment

File third_party/blink/renderer/modules/gamepad/window_gamepad.idl

Line 8, Patchset 2 (Latest): attribute EventHandler ongamepadconnected;
attribute EventHandler ongamepaddisconnected;

Matt Reynolds . unresolved

These attributes should have a [RuntimeEnabled=] extended attribute to keep them turned off until the feature is launched.

Orko Garai

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Matt Reynolds

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 2

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Comment-Date: Thu, 25 Sep 2025 21:51:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Matt Reynolds <mattre...@chromium.org>

[Orko Garai (Gerrit)]

Attention needed from Matt Reynolds

Orko Garai added 1 comment

File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Line 3355, Patchset 2 (Latest):

getter ongamepadconnected
getter ongamepaddisconnected

Matt Reynolds . unresolved

Changes to stable webexposed expectations need launch approval. Please add a feature in runtime_enabled_features.json5, initially "experimental", and remove the changes in virtual/stable/webexposed expectations for now.

Orko Garai

Acknowledged

Gerrit-Comment-Date: Thu, 25 Sep 2025 21:51:32 +0000

[Orko Garai (Gerrit)]

Attention needed from Matt Reynolds

Orko Garai added 2 comments

File third_party/blink/renderer/modules/gamepad/window_gamepad.idl

Line 8, Patchset 2: attribute EventHandler ongamepadconnected;
attribute EventHandler ongamepaddisconnected;

Matt Reynolds . resolved

These attributes should have a [RuntimeEnabled=] extended attribute to keep them turned off until the feature is launched.

Orko Garai

Acknowledged

Orko Garai

Done

File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Line 3355, Patchset 2: getter ongamepadconnected
getter ongamepaddisconnected

Matt Reynolds . resolved

Changes to stable webexposed expectations need launch approval. Please add a feature in runtime_enabled_features.json5, initially "experimental", and remove the changes in virtual/stable/webexposed expectations for now.

Orko Garai

Acknowledged

Orko Garai

Done

Open in Gerrit

Related details

Attention is currently required from:

• Matt Reynolds

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 4

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Sep 2025 02:42:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Orko Garai <or...@igalia.com>

Comment-In-Reply-To: Matt Reynolds <mattre...@chromium.org>

[Peter Beverloo (Gerrit)]

Attention needed from Matt Reynolds and Orko Garai

Peter Beverloo added 1 comment

File android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt

Line 3552, Patchset 4 (Latest): getter ongamepaddisconnected

Peter Beverloo . unresolved

Are the Gamepad APIs supported on Android WebView?

Open in Gerrit

Related details

Attention is currently required from:

• Matt Reynolds
• Orko Garai

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 4

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Orko Garai <or...@igalia.com>

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Sep 2025 10:50:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Orko Garai (Gerrit)]

Attention needed from Matt Reynolds and Peter Beverloo

Orko Garai added 1 comment

File android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt

Line 3552, Patchset 4 (Latest): getter ongamepaddisconnected

Peter Beverloo . resolved

Are the Gamepad APIs supported on Android WebView?

Orko Garai

Yes I just tested to confirm.

Open in Gerrit

Related details

Attention is currently required from:

• Matt Reynolds
• Peter Beverloo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 4

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Attention: Peter Beverloo <pe...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Sep 2025 12:37:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Peter Beverloo <pe...@chromium.org>

[Peter Beverloo (Gerrit)]

Attention needed from Matt Reynolds and Orko Garai

Peter Beverloo voted and added 2 comments

Votes added by Peter Beverloo

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Peter Beverloo . resolved

Not that it's necessary, but android_webview lgtm anyway

File android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt

Line 3552, Patchset 4 (Latest): getter ongamepaddisconnected

Peter Beverloo . resolved

Are the Gamepad APIs supported on Android WebView?

Orko Garai

Yes I just tested to confirm.

Peter Beverloo

Cool, thanks for testing 😊

Open in Gerrit

Related details

Attention is currently required from:

• Matt Reynolds
• Orko Garai

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 4

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Orko Garai <or...@igalia.com>

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Sep 2025 12:38:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Orko Garai <or...@igalia.com>

Comment-In-Reply-To: Peter Beverloo <pe...@chromium.org>

[Matt Reynolds (Gerrit)]

Attention needed from Orko Garai

Matt Reynolds voted and added 1 comment

Votes added by Matt Reynolds

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Matt Reynolds . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Orko Garai

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 5

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Orko Garai <or...@igalia.com>

Gerrit-Comment-Date: Sat, 27 Sep 2025 00:26:58 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Orko Garai (Gerrit)]

Attention needed from Javier Fernandez

Orko Garai voted and added 1 comment

Votes added by Orko Garai

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Orko Garai . resolved

@jfern...@igalia.com For runtime_enabled_features.json5

Open in Gerrit

Related details

Attention is currently required from:

• Javier Fernandez

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 5

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Javier Fernandez <jfern...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Javier Fernandez <jfern...@igalia.com>

Gerrit-Comment-Date: Sat, 27 Sep 2025 00:41:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Javier Fernandez (Gerrit)]

Attention needed from Orko Garai

Javier Fernandez voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Orko Garai

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 5

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Javier Fernandez <jfern...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Orko Garai <or...@igalia.com>

Gerrit-Comment-Date: Tue, 30 Sep 2025 09:00:54 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

gamepad: Implement connected and disconnected WindowEventHandlers

Implement Window.ongamepadconnected and Window.ongamepaddisconnected as
per https://github.com/w3c/gamepad/pull/144.

This fixes the gamepad idlharness.window.html interop wpt failures seen
in chromium vs. other browsers.

R=mattreynolds

Bug: 40175074

Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6984681

Auto-Submit: Orko Garai <or...@igalia.com>

Reviewed-by: Matt Reynolds <mattre...@chromium.org>

Commit-Queue: Javier Fernandez <jfern...@igalia.com>

Reviewed-by: Javier Fernandez <jfern...@igalia.com>

Reviewed-by: Peter Beverloo <pe...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1522755}

Files:

• M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
• M third_party/blink/renderer/bindings/idl_in_modules.gni
• M third_party/blink/renderer/modules/gamepad/BUILD.gn
• A third_party/blink/renderer/modules/gamepad/dom_window_gamepad.h
• A third_party/blink/renderer/modules/gamepad/window_gamepad.idl
• M third_party/blink/renderer/platform/runtime_enabled_features.json5
• M third_party/blink/web_tests/external/wpt/gamepad/idlharness.window-expected.txt
• M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
• M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
• M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
• M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
• M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Change size: M

Delta: 12 files changed, 74 insertions(+), 13 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Peter Beverloo, +1 by Matt Reynolds, +1 by Javier Fernandez

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ida8bf56dd8bdebf151704528db7d01ded04db706

Gerrit-Change-Number: 6984681

Gerrit-PatchSet: 6

Gerrit-Owner: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Javier Fernandez <jfern...@igalia.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Orko Garai <or...@igalia.com>

Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>