Speculative load measurement API - preload tracking [chromium/src : main]
38 views
Skip to first unread message
Yoav Weiss (@Shopify) (Gerrit)
Feb 16, 2026, 11:22:06 AMFeb 16
to Kouhei Ueno, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
Yoav Weiss (@Shopify) voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Mar 12, 2026, 2:31:25 AMMar 12
to Yoav Weiss (@Shopify), Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)
Kouhei Ueno added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Mar 12, 2026, 2:43:23 AMMar 12
to Kouhei Ueno, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
Yoav Weiss (@Shopify) added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
Line 1987, Patchset 2:
KURL url = resource->Url();Kouhei Ueno . resolved
Yoav Weiss (@Shopify)const KURL&
Done
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Mar 12, 2026, 3:17:51 AMMar 12
to Yoav Weiss (@Shopify), Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)
Kouhei Ueno added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.html
Line 74, Patchset 3 (Latest):
await new Promise(resolve => setTimeout(resolve, 200));Kouhei Ueno . unresolved
To avoid flaky test, would you make the resource be served via custom handler so we can ensure server received the request?
Something similar to
third_party/blink/web_tests/external/wpt/speculation-rules/prefetch/resources/prefetch.py to put data on server stash and we continuously fetch the stash until it says the server has received the req.
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Mar 12, 2026, 5:44:06 AMMar 12
to Kouhei Ueno, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
Yoav Weiss (@Shopify) added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.html
To avoid flaky test, would you make the resource be served via custom handler so we can ensure server received the request?
Something similar to
third_party/blink/web_tests/external/wpt/speculation-rules/prefetch/resources/prefetch.py to put data on server stash and we continuously fetch the stash until it says the server has received the req.
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Mar 13, 2026, 12:00:04 AMMar 13
to Yoav Weiss (@Shopify), Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)
Kouhei Ueno added 14 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/events/page_transition_event.h
Line 73, Patchset 5 (Latest):
protected:Kouhei Ueno . unresolved
Would you elaborate on why this needs change?
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.html
Line 74, Patchset 3:
await new Promise(resolve => setTimeout(resolve, 200));Kouhei Ueno . resolved
Yoav Weiss (@Shopify)To avoid flaky test, would you make the resource be served via custom handler so we can ensure server received the request?
Something similar to
third_party/blink/web_tests/external/wpt/speculation-rules/prefetch/resources/prefetch.py to put data on server stash and we continuously fetch the stash until it says the server has received the req.
Done
Kouhei Ueno
Sorry I should have asked if we really need this first.
if we are waiting on onload, would it be enough?
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.https.html
Line 64, Patchset 5 (Latest):
assert_true(result.speculations !== null && result.speculations !== undefined,Kouhei Ueno . unresolved
nit: split to two assert_not_equals
Line 69, Patchset 5 (Latest):
const preloads = result.speculations.preloads;Kouhei Ueno . unresolved
should we check its contents?
Line 109, Patchset 5 (Latest):
const preloads = result.speculations.preloads;Kouhei Ueno . unresolved
Can we match `preloads` exactly against expected array?
I believe we expect it to have the precise set of elements.
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-used-preload.tentative.html
Line 99, Patchset 5 (Latest):
assert_true(result.speculations !== null,Kouhei Ueno . unresolved
assert_not_equals
Line 107, Patchset 5 (Latest):
assert_true(unusedPreload !== undefined,Kouhei Ueno . unresolved
assert_not_equals
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-multiple-preloads.html
Line 5, Patchset 5 (Latest):
<link rel="preload" href="unused-script.js" as="script">Kouhei Ueno . unresolved
nonexistent?
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-pagehide-reporter.html
Line 9, Patchset 5 (Latest):
type: 'pagehide',Kouhei Ueno . unresolved
Would you elaborate why we need to pass this value?
Line 15, Patchset 5 (Latest):
persisted: event.persistedKouhei Ueno . unresolved
Would you elaborate why we need to pass this value?
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-unused-preload.html
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-used-preload-and-reporter.html
Line 9, Patchset 5 (Latest):
if (parent && parent !== window && parent.pagehideCallback) {Kouhei Ueno . unresolved
what is `parent !== window` condition needed for?
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Mar 13, 2026, 1:00:17 AMMar 13
to Kouhei Ueno, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
Yoav Weiss (@Shopify) added 10 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/events/page_transition_event.h
Would you elaborate on why this needs change?
Yoav Weiss (@Shopify)
It doesn't. Removed
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.https.html
Line 64, Patchset 5:
assert_true(result.speculations !== null && result.speculations !== undefined,Kouhei Ueno . resolved
nit: split to two assert_not_equals
Yoav Weiss (@Shopify)
Done
should we check its contents?
Yoav Weiss (@Shopify)
Sure, but it's empty in this test
Can we match `preloads` exactly against expected array?
I believe we expect it to have the precise set of elements.
Yoav Weiss (@Shopify)
Done
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-used-preload.tentative.html
Line 99, Patchset 5:
assert_true(result.speculations !== null,Kouhei Ueno . resolved
Yoav Weiss (@Shopify)assert_not_equals
Done
Line 107, Patchset 5:
assert_true(unusedPreload !== undefined,Kouhei Ueno . resolved
Yoav Weiss (@Shopify)assert_not_equals
Done
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-pagehide-reporter.html
Would you elaborate why we need to pass this value?
Yoav Weiss (@Shopify)
We don't. removed!
Would you elaborate why we need to pass this value?
Yoav Weiss (@Shopify)
We don't. Removed!
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-unused-preload.html
Line 1, Patchset 5:
<!DOCTYPE html>Kouhei Ueno . resolved
Yoav Weiss (@Shopify)Is this file used?
No, removed!
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-used-preload-and-reporter.html
Line 9, Patchset 5:
if (parent && parent !== window && parent.pagehideCallback) {Kouhei Ueno . resolved
what is `parent !== window` condition needed for?
Yoav Weiss (@Shopify)
To only report when loaded in an iframe. But I guess it's not strictly needed, so removed.
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
Yoav Weiss (@Shopify) (Gerrit)
Mar 13, 2026, 1:01:27 AMMar 13
to Kouhei Ueno, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
Yoav Weiss (@Shopify) added 2 comments![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-multiple-preloads.html
Line 1, Patchset 5:
<!DOCTYPE html>Kouhei Ueno . resolved
Yoav Weiss (@Shopify)Is this file used?
Nope. Removed.
Line 5, Patchset 5:
<link rel="preload" href="unused-script.js" as="script">Kouhei Ueno . resolved
Yoav Weiss (@Shopify)nonexistent?
Removed the file
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Mar 13, 2026, 1:01:48 AMMar 13
to Kouhei Ueno, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
Yoav Weiss (@Shopify) added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.https.html
Line 90, Patchset 5:
await waitForPreloadRequest(uuid);Kouhei Ueno . unresolved
ditto
Yoav Weiss (@Shopify)
Can you elaborate what you meant here?
Kouhei Ueno (Gerrit)
Mar 17, 2026, 9:54:06 AMMar 17
to Yoav Weiss (@Shopify), Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)
Kouhei Ueno added 5 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/frame/local_dom_window.cc
Line 999, Patchset 8 (Latest):
bool persisted = (persistence == kPageTransitionEventPersisted);Kouhei Ueno . unresolved
Would you add a TODO comment we should plumb enum `PageTransitionEventPersistence` through PageHideEvent + PageTransitionEvent? I don't see any reason not to...
File third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
Line 2430, Patchset 8 (Latest):
// TODO(yoav): Currently only URLs are passed for early hintsKouhei Ueno . unresolved
TODO(crbug/...)
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.https.html
Line 90, Patchset 5:
await waitForPreloadRequest(uuid);Kouhei Ueno . resolved
Yoav Weiss (@Shopify)ditto
Can you elaborate what you meant here?
Kouhei Ueno
I think I'm good with this one.
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-used-preload.tentative.html
Line 35, Patchset 8 (Latest):
await new Promise(resolve => setTimeout(resolve, 200));Kouhei Ueno . unresolved
If we are using the script and waiting for the onload, do we need this wait?
Line 69, Patchset 8 (Latest):
promise_test(async t => {Kouhei Ueno . unresolved
Sorry I'm still quite confused. The file name is "used-preload" but this is testing "unused preload"?
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Mar 17, 2026, 10:07:23 AMMar 17
to Yoav Weiss (@Shopify), Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)
Kouhei Ueno added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Kouhei Ueno . resolved
Overall I'm still quite confused with the WPTs - some are http tests some are https tests. Would you elaborate why? Can we clarify the organization of the tests? `pagehide-speculations.tentative` seem to contain interface tests. I'd like to confirm if the tests are mostly orthogonal to each other
Yoav Weiss (@Shopify) (Gerrit)
Mar 18, 2026, 8:48:44 AMMar 18
to Barry Pollard, Kouhei Ueno, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
Yoav Weiss (@Shopify) voted and added 5 comments![]( "Open in Gerrit")
Votes added by Yoav Weiss (@Shopify)
| Commit-Queue | +1 |
Kouhei Ueno . resolved
Overall I'm still quite confused with the WPTs - some are http tests some are https tests. Would you elaborate why? Can we clarify the organization of the tests? `pagehide-speculations.tentative` seem to contain interface tests. I'd like to confirm if the tests are mostly orthogonal to each other
Yoav Weiss (@Shopify)
The unused preloads test is using UUID (for the preload stash) and hence is required to be https. The rest of the tests don't need that.
I removed the interface test, as it's covered elsewhere.
File third_party/blink/renderer/core/frame/local_dom_window.cc
Line 999, Patchset 8:
bool persisted = (persistence == kPageTransitionEventPersisted);Kouhei Ueno . resolved
Would you add a TODO comment we should plumb enum `PageTransitionEventPersistence` through PageHideEvent + PageTransitionEvent? I don't see any reason not to...
Yoav Weiss (@Shopify)
Plumbed it
File third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
Line 2430, Patchset 8:
// TODO(yoav): Currently only URLs are passed for early hintsKouhei Ueno . resolved
Yoav Weiss (@Shopify)TODO(crbug/...)
Done
File third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-used-preload.tentative.html
If we are using the script and waiting for the onload, do we need this wait?
Yoav Weiss (@Shopify)
removed
Sorry I'm still quite confused. The file name is "used-preload" but this is testing "unused preload"?
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Mar 19, 2026, 10:24:11 AM (14 days ago) Mar 19
to Yoav Weiss (@Shopify), Barry Pollard, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hiroshige Hayashizaki
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Mar 19, 2026, 10:43:58 AM (14 days ago) Mar 19
to Yoav Weiss (@Shopify), Kouhei Ueno, Barry Pollard, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58615.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Mar 19, 2026, 10:47:41 AM (14 days ago) Mar 19
to Blink W3C Test Autoroller, Kouhei Ueno, Barry Pollard, Hiroshige Hayashizaki, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki
Yoav Weiss (@Shopify) voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
Chromium LUCI CQ (Gerrit)
Mar 19, 2026, 11:13:00 AM (14 days ago) Mar 19
to Yoav Weiss (@Shopify), Blink W3C Test Autoroller, Kouhei Ueno, Barry Pollard, Hiroshige Hayashizaki, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Speculative load measurement API - preload tracking
This CL implements the preload tracking portion of the Speculative Load
Measurement API, exposing preload information on the pagehide event.
Introduces PageHideEvent (extending PageTransitionEvent) with a
SpeculationData attribute containing preload information. ResourceFetcher
tracks all preloads and their usage state, which is collected at
pagehide time.
The feature is gated behind the PageHideSpeculations runtime flag.
Change-Id: I18d0bfe97e7a117fe298b65a5fbbcd177b2b8e40
Bug: 481590676
Commit-Queue: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1601978}
Files:
- M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
- M third_party/blink/renderer/bindings/generated_in_core.gni
- M third_party/blink/renderer/bindings/idl_in_core.gni
- M third_party/blink/renderer/core/dom/document.cc
- M third_party/blink/renderer/core/events/build.gni
- A third_party/blink/renderer/core/events/page_hide_event.cc
- A third_party/blink/renderer/core/events/page_hide_event.h
- A third_party/blink/renderer/core/events/page_hide_event.idl
- A third_party/blink/renderer/core/events/page_hide_event_init.idl
- M third_party/blink/renderer/core/events/page_transition_event.cc
- M third_party/blink/renderer/core/events/page_transition_event.h
- A third_party/blink/renderer/core/events/preload.cc
- A third_party/blink/renderer/core/events/preload.h
- A third_party/blink/renderer/core/events/preload.idl
- A third_party/blink/renderer/core/events/speculation_data.cc
- A third_party/blink/renderer/core/events/speculation_data.h
- A third_party/blink/renderer/core/events/speculation_data.idl
- M third_party/blink/renderer/core/frame/local_dom_window.cc
- M third_party/blink/renderer/core/frame/local_dom_window.h
- M third_party/blink/renderer/platform/loader/fetch/resource.cc
- M third_party/blink/renderer/platform/loader/fetch/resource.h
- M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
- M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.https.html
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-used-preload.tentative.html
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations.tentative.html
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/blank.html
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-pagehide-reporter.html
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-unused-preload-and-reporter.html
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-used-preload-and-reporter.html
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/preload-stash.py
- A third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/preloaded-script.js
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Change size: L
Delta: 34 files changed, 914 insertions(+), 32 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kouhei Ueno
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Mar 19, 2026, 12:02:56 PM (14 days ago) Mar 19
to Chromium LUCI CQ, Yoav Weiss (@Shopify), Kouhei Ueno, Barry Pollard, Hiroshige Hayashizaki, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The exported PR, https://github.com/web-platform-tests/wpt/pull/58615, has failed the following check(s) on GitHub:
wpt-firefox-nightly-stability (https://github.com/web-platform-tests/wpt/runs/67768599640)
These failures will block the export. They may represent new or existing problems; please take a look at the output and see if it can be fixed. Unresolved failures will be looked at by the Ecosystem-Infra sheriff after this CL has been landed in Chromium; if you need earlier help please contact blin...@chromium.org.
Any suggestions to improve this service are welcome; crbug.com/1027618.
Gerrit CL SHA: Latest
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Mar 19, 2026, 7:43:20 PM (14 days ago) Mar 19
to Chromium LUCI CQ, Yoav Weiss (@Shopify), Kouhei Ueno, Barry Pollard, Hiroshige Hayashizaki, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58615
Yoav Weiss (@Shopify) (Gerrit)
Mar 31, 2026, 5:38:47 AM (2 days ago) Mar 31
to Chromium LUCI CQ, Blink W3C Test Autoroller, Kouhei Ueno, Barry Pollard, Hiroshige Hayashizaki, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Yoav Weiss (@Shopify) has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages