Blink: platform: Use Blink wrappers for binding utilities [chromium/src : main]
0 views
Skip to first unread message
Jaewon Jung (Gerrit)
Nov 3, 2025, 9:51:45 PMNov 3
to Jeremy Roman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Jeremy Roman
Jaewon Jung added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Nov 4, 2025, 10:18:44 AMNov 4
to Jaewon Jung, Jeremy Roman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Jaewon Jung
Jeremy Roman added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/wtf/functional.h
Line 421, Patchset 6 (Latest):
template <typename T>
struct CrossThreadCopier<std::unique_ptr<T>> {
using Type = std::unique_ptr<T>;
static Type Copy(Type ptr) { return std::move(ptr); }
};
Jeremy Roman . unresolved
This already exists in third_party/blink/renderer/platform/wtf/cross_thread_copier_std.h.
Related details
Attention is currently required from:
- Jaewon Jung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jaewon Jung (Gerrit)
Nov 5, 2025, 8:11:56 AMNov 5
to Jeremy Roman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Jeremy Roman
Jaewon Jung added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/wtf/functional.h
Line 421, Patchset 6:
template <typename T>
struct CrossThreadCopier<std::unique_ptr<T>> {
using Type = std::unique_ptr<T>;
static Type Copy(Type ptr) { return std::move(ptr); }
};
Jeremy Roman . resolved
This already exists in third_party/blink/renderer/platform/wtf/cross_thread_copier_std.h.
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Nov 5, 2025, 10:45:04 AMNov 5
to Jaewon Jung, Jeremy Roman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Jaewon Jung
Jeremy Roman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jaewon Jung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jaewon Jung (Gerrit)
Nov 6, 2025, 1:01:30 AMNov 6
to Andrey Kosyakov, Jeremy Roman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Andrey Kosyakov
Jaewon Jung added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jaewon Jung . resolved
PTAL! Thanks. :)
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jaewon Jung (Gerrit)
Nov 11, 2025, 7:41:43 PM (12 days ago) Nov 11
to Nate Chapin, Andrey Kosyakov, Jeremy Roman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Andrey Kosyakov and Nate Chapin
Jaewon Jung added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jaewon Jung . resolved
Sorry for the ping. Would you have a moment to review this CL? The original reviewer seems unavailable. Thanks!
Related details
Attention is currently required from:
- Andrey Kosyakov
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Nov 12, 2025, 3:12:51 PM (11 days ago) Nov 12
to Jaewon Jung, Andrey Kosyakov, Jeremy Roman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Andrey Kosyakov and Jaewon Jung
Nate Chapin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
- Jaewon Jung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jaewon Jung (Gerrit)
Nov 12, 2025, 7:22:23 PM (11 days ago) Nov 12
to Nate Chapin, Andrey Kosyakov, Jeremy Roman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Andrey Kosyakov
Jaewon Jung voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2025, 8:27:30 PM (11 days ago) Nov 12
to Jaewon Jung, Nate Chapin, Andrey Kosyakov, Jeremy Roman, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Blink: platform: Use Blink wrappers for binding utilities
This patch refactors `ParkableStringManager` and its test to align
with Blink coding conventions, replacing `base::` binding utilities
with their Blink-specific counterparts.
Signed-off-by: Jaewon Jung <jw....@navercorp.com>
Bug: 40797264
Change-Id: I0be00c1fd58819af9a421482d5d59433b74aeeeb
Reviewed-by: Jeremy Roman <jbr...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544075}
Files:
- M third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
- M third_party/blink/renderer/platform/bindings/parkable_string_test.cc
Change size: M
Delta: 2 files changed, 37 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Chapin, +1 by Jeremy Roman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages