Remove V8StringResource [chromium/src : main]

0 views
Skip to first unread message

Andrey Kosyakov (Gerrit)

unread,
Mar 31, 2026, 8:46:27 PM (2 days ago) Mar 31
to Nate Chapin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Xida Chen, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, sloboda...@chromium.org, zol...@webkit.org
Attention needed from Nate Chapin

Andrey Kosyakov voted and added 3 comments

Votes added by Andrey Kosyakov

Commit-Queue+1

3 comments

File third_party/blink/renderer/bindings/core/v8/dictionary.cc
Line 163, Patchset 4 (Parent): if (!string_key.Prepare(exception_state)) {
Andrey Kosyakov . resolved

note `key` is already a v8::String, so we won't throw here.

File third_party/blink/renderer/bindings/core/v8/v8_string_resource.h
Line 108, Patchset 2 (Parent): mode_ = kDoNotExternalize;
Andrey Kosyakov . resolved

Technically, we're losing this part, but I'm not sure we care because it's already a slow path, and then if not externalizing strings produced by ToString() conversion makes sense, we should be doing this consistently across different code paths.

Line 50, Patchset 2 (Parent):template <V8StringResourceMode Mode = kDefaultMode>
Andrey Kosyakov . resolved

Note it was never used in non-default mode.

Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cbaae52fd64e737c12657062c700a80b66158a6
Gerrit-Change-Number: 7708957
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 00:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
Apr 1, 2026, 12:04:33 PM (19 hours ago) Apr 1
to Andrey Kosyakov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Xida Chen, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, sloboda...@chromium.org, zol...@webkit.org
Attention needed from Andrey Kosyakov

Nate Chapin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cbaae52fd64e737c12657062c700a80b66158a6
Gerrit-Change-Number: 7708957
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 16:04:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Apr 1, 2026, 12:36:57 PM (18 hours ago) Apr 1
to Nate Chapin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Xida Chen, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, sloboda...@chromium.org, zol...@webkit.org

Andrey Kosyakov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Wed, 01 Apr 2026 16:36:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 1, 2026, 1:42:34 PM (17 hours ago) Apr 1
to Andrey Kosyakov, Nate Chapin, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Xida Chen, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, sloboda...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove V8StringResource

Replace it with ToBlinkString() for v8::Strings and
NativeValueTraits<>::NativeValue() for values.
Change-Id: I9cbaae52fd64e737c12657062c700a80b66158a6
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608643}
Files:
  • M third_party/blink/renderer/bindings/bindings.gni
  • M third_party/blink/renderer/bindings/core/v8/capture_source_location.cc
  • M third_party/blink/renderer/bindings/core/v8/dictionary.cc
  • M third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
  • M third_party/blink/renderer/bindings/core/v8/script_iterator.cc
  • M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc
  • M third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
  • M third_party/blink/renderer/bindings/core/v8/v8_code_cache.h
  • M third_party/blink/renderer/bindings/core/v8/v8_html_constructor.cc
  • D third_party/blink/renderer/bindings/core/v8/v8_string_resource.h
  • M third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules.cc
  • M third_party/blink/renderer/core/fetch/readable_stream_bytes_consumer.cc
  • M third_party/blink/renderer/core/fetch/readable_stream_bytes_consumer_test.cc
  • M third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
  • M third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.cc
  • M third_party/blink/renderer/modules/csspaint/css_paint_definition.cc
  • M third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.cc
  • M third_party/blink/renderer/modules/encoding/text_encoder_stream.cc
  • M third_party/blink/renderer/modules/payments/payment_request.cc
  • M third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope_test.cc
  • M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
  • M third_party/blink/renderer/platform/BUILD.gn
  • M third_party/blink/renderer/platform/bindings/v8_binding.h
  • D third_party/blink/renderer/platform/bindings/v8_binding_macros.h
  • M third_party/blink/renderer/platform/bindings/v8_private_property.cc
  • M third_party/blink/renderer/platform/bindings/v8_private_property.h
  • M third_party/blink/renderer/platform/wtf/text/string_hash.h
Change size: L
Delta: 27 files changed, 13 insertions(+), 294 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Chapin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cbaae52fd64e737c12657062c700a80b66158a6
Gerrit-Change-Number: 7708957
Gerrit-PatchSet: 5
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages