Improve String::Split(UChar, Vector) API [chromium/src : main]

[Kent Tamura (Gerrit)]

Kent Tamura voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib88a1fc308f89299cd5c1f967dc6503794773184

Gerrit-Change-Number: 7565357

Gerrit-PatchSet: 5

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Luna Lu <loon...@chromium.org>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 11 Feb 2026 02:13:58 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[gwsq (Gerrit)]

Attention needed from Takashi Toyoshima

Message from gwsq

WARNING: gwsq was unable to find a reviewer who is not on vacation. As a fallback, gwsq is ignoring vacations and assigning toyo...@chromium.org.
WARNING: gwsq was unable to find a reviewer who is not on vacation. As a fallback, gwsq is ignoring vacations and assigning toyo...@chromium.org.
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: toyo...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): toyo...@chromium.org

Reviewer source(s):
toyo...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Takashi Toyoshima

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib88a1fc308f89299cd5c1f967dc6503794773184

Gerrit-Change-Number: 7565357

Gerrit-PatchSet: 5

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Luna Lu <loon...@chromium.org>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Feb 2026 02:20:11 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Kent Tamura (Gerrit)]

Attention needed from Takashi Toyoshima

Kent Tamura added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Kent Tamura . resolved

chrome-ipc-reviews@, please approve image_resource_type_converters.cc

Gerrit-Comment-Date: Wed, 11 Feb 2026 02:23:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Takashi Toyoshima (Gerrit)]

Attention needed from Kent Tamura

Takashi Toyoshima voted and added 1 comment

Votes added by Takashi Toyoshima

Code-Review

+1

1 comment

File third_party/blink/renderer/platform/wtf/text/wtf_string_test.cc

Line 289, Patchset 5 (Latest): result.clear();

Takashi Toyoshima . unresolved

now this line is redundant?

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Feb 2026 05:42:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Kent Tamura (Gerrit)]

Attention needed from Fredrik Söderquist

Kent Tamura voted and added 2 comments

Votes added by Kent Tamura

Auto-Submit

+1

2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Kent Tamura . resolved

fs@, would you review this please?

File third_party/blink/renderer/platform/wtf/text/wtf_string_test.cc

Line 289, Patchset 5: result.clear();

Takashi Toyoshima . resolved

now this line is redundant?

Kent Tamura

Good point! Removed.

Open in Gerrit

Related details

Attention is currently required from:

• Fredrik Söderquist

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib88a1fc308f89299cd5c1f967dc6503794773184

Gerrit-Change-Number: 7565357

Gerrit-PatchSet: 6

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Luna Lu <loon...@chromium.org>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Fredrik Söderquist <f...@opera.com>

Gerrit-Comment-Date: Wed, 11 Feb 2026 06:58:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org>

[Fredrik Söderquist (Gerrit)]

Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Feb 2026 09:45:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Improve String::Split(UChar, Vector) API

The `String::Split` API was not very ergonomic. It required declaring a
vector on a separate line before calling the split method with an
out-parameter.

This change introduces a new `String::SplitSkippingEmpty` method that
returns a `Vector<String>` by value. This allows for a more concise,
single-line expression for splitting strings.

All call sites of the old `String::Split(UChar, Vector<String>&)`
overload, which implicitly skipped empty strings, have been migrated to
use the new `SplitSkippingEmpty` method. The now-unused overload has
been removed to improve the API surface.

This is a pure refactoring for code health and readability, and has no
behavior changes.

Bug: 473854537

Change-Id: Ib88a1fc308f89299cd5c1f967dc6503794773184

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7565357

Reviewed-by: Fredrik Söderquist <f...@opera.com>

Commit-Queue: Fredrik Söderquist <f...@opera.com>

Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>

Auto-Submit: Kent Tamura <tk...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1583080}

Files:

• M third_party/blink/renderer/bindings/core/v8/activity_logger_test.cc
• M third_party/blink/renderer/core/accessibility/ax_object_cache.cc
• M third_party/blink/renderer/core/editing/ime/input_method_controller.cc
• M third_party/blink/renderer/core/editing/suggestion/text_suggestion_controller.cc
• M third_party/blink/renderer/core/frame/csp/trusted_types_directive_test.cc
• M third_party/blink/renderer/core/frame/navigator_language.cc
• M third_party/blink/renderer/core/page/context_menu_controller.cc
• M third_party/blink/renderer/core/permissions_policy/permissions_policy_parser.cc
• M third_party/blink/renderer/modules/accessibility/ax_object.cc
• M third_party/blink/renderer/modules/manifest/image_resource_type_converters.cc
• M third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc
• M third_party/blink/renderer/modules/webaudio/inspector_web_audio_agent.cc
• M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
• M third_party/blink/renderer/platform/graphics/gpu/extensions_3d_util.cc
• M third_party/blink/renderer/platform/wtf/text/wtf_string.cc
• M third_party/blink/renderer/platform/wtf/text/wtf_string.h
• M third_party/blink/renderer/platform/wtf/text/wtf_string_test.cc

Change size: M

Delta: 17 files changed, 37 insertions(+), 42 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Takashi Toyoshima, +1 by Fredrik Söderquist

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib88a1fc308f89299cd5c1f967dc6503794773184

Gerrit-Change-Number: 7565357

Gerrit-PatchSet: 7

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>