Migrate caches partial interfaces to mixin in WindowOrWorkerGlobalScope [chromium/src : main]

0 views
Skip to first unread message

Suyeon Ji (Gerrit)

unread,
Oct 3, 2025, 11:57:07 AM (3 days ago) Oct 3
to Fergal Daly, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Fergal Daly and Jinho Bang

Suyeon Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Suyeon Ji . resolved

Hello! Please take a look. Thanks a lot!

Open in Gerrit

Related details

Attention is currently required from:
  • Fergal Daly
  • Jinho Bang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I63ff0ad67c73d390c48dabef78821db04a2b783f
Gerrit-Change-Number: 7005913
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Jinho Bang <zi...@chromium.org>
Gerrit-Attention: Fergal Daly <fer...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Oct 2025 15:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jinho Bang (Gerrit)

unread,
Oct 3, 2025, 12:35:50 PM (3 days ago) Oct 3
to Suyeon Ji, Fergal Daly, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Fergal Daly and Suyeon Ji

Jinho Bang voted and added 2 comments

Votes added by Jinho Bang

Code-Review+1

2 comments

Patchset-level comments
Jinho Bang . resolved

non-owner lgtm

File third_party/blink/renderer/modules/cache_storage/window_or_worker_global_scope_cache_storage.idl
Line 1, Patchset 2 (Latest):// Copyright 2025 The Chromium Authors
Jinho Bang . unresolved

nit: It seems like it would be better to keep 2015, since this file was renamed due to its high similarity.

Open in Gerrit

Related details

Attention is currently required from:
  • Fergal Daly
  • Suyeon Ji
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I63ff0ad67c73d390c48dabef78821db04a2b783f
    Gerrit-Change-Number: 7005913
    Gerrit-PatchSet: 2
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
    Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
    Gerrit-Attention: Fergal Daly <fer...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Oct 2025 16:35:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Fergal Daly (Gerrit)

    unread,
    Oct 5, 2025, 9:47:45 PM (4 hours ago) Oct 5
    to Suyeon Ji, Jinho Bang, Fergal Daly, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Suyeon Ji

    Fergal Daly added 1 comment

    File third_party/blink/renderer/modules/cache_storage/window_or_worker_global_scope_cache_storage.idl
    Line 1, Patchset 2 (Latest):// Copyright 2025 The Chromium Authors
    Jinho Bang . unresolved

    nit: It seems like it would be better to keep 2015, since this file was renamed due to its high similarity.

    Fergal Daly

    Yes, this is a rename, so should leave the copyright intact.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Suyeon Ji
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I63ff0ad67c73d390c48dabef78821db04a2b783f
    Gerrit-Change-Number: 7005913
    Gerrit-PatchSet: 2
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
    Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
    Gerrit-Comment-Date: Mon, 06 Oct 2025 01:47:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jinho Bang <zi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Suyeon Ji (Gerrit)

    unread,
    12:40 AM (1 hour ago) 12:40 AM
    to Jinho Bang, Fergal Daly, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Fergal Daly and Jinho Bang

    Suyeon Ji added 1 comment

    File third_party/blink/renderer/modules/cache_storage/window_or_worker_global_scope_cache_storage.idl
    Line 1, Patchset 2:// Copyright 2025 The Chromium Authors
    Jinho Bang . resolved

    nit: It seems like it would be better to keep 2015, since this file was renamed due to its high similarity.

    Fergal Daly

    Yes, this is a rename, so should leave the copyright intact.

    Suyeon Ji

    Oops, I thought this was being added as a new file. Reverted it back, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fergal Daly
    • Jinho Bang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I63ff0ad67c73d390c48dabef78821db04a2b783f
      Gerrit-Change-Number: 7005913
      Gerrit-PatchSet: 3
      Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
      Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
      Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
      Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Jinho Bang <zi...@chromium.org>
      Gerrit-Attention: Fergal Daly <fer...@chromium.org>
      Gerrit-Comment-Date: Mon, 06 Oct 2025 04:40:06 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Jinho Bang <zi...@chromium.org>
      Comment-In-Reply-To: Fergal Daly <fer...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Fergal Daly (Gerrit)

      unread,
      12:42 AM (1 hour ago) 12:42 AM
      to Suyeon Ji, Fergal Daly, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
      Attention needed from Jinho Bang and Suyeon Ji

      Fergal Daly voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jinho Bang
      • Suyeon Ji
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I63ff0ad67c73d390c48dabef78821db04a2b783f
      Gerrit-Change-Number: 7005913
      Gerrit-PatchSet: 3
      Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
      Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
      Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
      Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
      Gerrit-Attention: Jinho Bang <zi...@chromium.org>
      Gerrit-Comment-Date: Mon, 06 Oct 2025 04:41:44 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages