Checked Span: Opt out Blink `core/` [chromium/src : main]

0 views

Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

3:55 AM (2 hours ago) 3:55 AM

to Kalvin Lee, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, ortuno...@chromium.org, extension...@chromium.org, titoua...@chromium.org, jbroma...@chromium.org, chromium-a...@chromium.org, apavlo...@chromium.org, bartek...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, hiroshig...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, loading-rev...@chromium.org, wfh+...@chromium.org, zol...@webkit.org

Attention needed from Kalvin Lee

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/blink_perf.bindings complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15856717890000

Open in Gerrit

Related details

Attention is currently required from:

Kalvin Lee

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kalvin Lee (Gerrit)

unread,

4:20 AM (1 hour ago) 4:20 AM

to Raphael Kubo da Costa, Menard, Alexis, blink-re...@chromium.org, ortuno...@chromium.org, blink-rev...@chromium.org, bartek...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, wfh+...@chromium.org, hiroshig...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org, blink-revi...@chromium.org, jbroma...@chromium.org, dom+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, titoua...@chromium.org, zol...@webkit.org, devtools-re...@chromium.org, apavlo...@chromium.org, kouhei...@chromium.org, dominicc+...@chromium.org, extension...@chromium.org

Kalvin Lee has uploaded the change for review

Commit message

Checked Span: Opt out Blink `core/`

Looking at the alerts that fired when we last tried to enable Checked
Span in release, `blink_perf` suites are strongly affected.

This CL opts out spans under `renderer/core/` in an attempt to remedy.

Bug: 501113358

Change-Id: I5210413b22ab6e9f7ac90de56059c44ac9d2b7d1

Change diff

Change information

Files:

M base/allocator/partition_allocator/partition_alloc.gni
M third_party/blink/renderer/bindings/core/v8/pass_as_span.h
M third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
M third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value_fuzzer.cc
M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_deserializer.h
M third_party/blink/renderer/bindings/core/v8/v8_code_cache.h
M third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
M third_party/blink/renderer/bindings/modules/v8/v8_context_snapshot_impl.cc
M third_party/blink/renderer/core/css/css_property_value_set.cc
M third_party/blink/renderer/core/css/css_property_value_set.h
M third_party/blink/renderer/core/css/css_variable_data.h
M third_party/blink/renderer/core/css/parser/css_selector_parser.cc
M third_party/blink/renderer/core/dom/element_data.h
M third_party/blink/renderer/core/editing/iterators/text_searcher_icu.cc
M third_party/blink/renderer/core/html/parser/html_stack_item.h
M third_party/blink/renderer/core/inspector/inspector_session_state.cc
M third_party/blink/renderer/core/inspector/v8_inspector_string.cc
M third_party/blink/renderer/core/inspector/v8_inspector_string.h
M third_party/blink/renderer/core/layout/block_break_token.h
M third_party/blink/renderer/core/layout/inline/offset_mapping.cc
M third_party/blink/renderer/core/typed_arrays/array_buffer/array_buffer_contents.cc
M third_party/blink/renderer/core/typed_arrays/array_buffer/array_buffer_contents.h
M third_party/blink/renderer/core/typed_arrays/dom_array_buffer_view.h
M third_party/blink/renderer/core/typed_arrays/dom_typed_array.h
M third_party/blink/renderer/core/xml/parser/xml_document_parser.cc
M third_party/blink/renderer/core/xml/xslt_processor_libxslt.cc
M third_party/blink/renderer/core/xml/xslt_unicode_sort.cc
M third_party/blink/renderer/platform/bindings/source_location.cc

Change size: M

Delta: 28 files changed, 89 insertions(+), 68 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages