Forwarding abort reason from AbortController.abort() to fetch() response [chromium/src : main]

1 view
Skip to first unread message

Taylor Brandstetter (Gerrit)

unread,
May 12, 2026, 3:09:32 PM (7 days ago) May 12
to Adam Rice, Hiroki Nakagawa, Andreas Haas, Rakina Zata Amni, David Bokan, Taylor Brandstetter, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org
Attention needed from Adam Rice, Andreas Haas, David Bokan, Hiroki Nakagawa and Rakina Zata Amni

Taylor Brandstetter added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Taylor Brandstetter . resolved

Oops, thought I was adding reviewers earlier but was only adding to CC. See previous message.

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Andreas Haas
  • David Bokan
  • Hiroki Nakagawa
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iea6190f533c4b87326671e0d40f7accadde0abb8
Gerrit-Change-Number: 7759798
Gerrit-PatchSet: 5
Gerrit-Owner: Taylor Brandstetter <dead...@chromium.org>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: David Bokan <bo...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: Taylor Brandstetter <dead...@google.com>
Gerrit-Attention: Andreas Haas <ah...@chromium.org>
Gerrit-Attention: David Bokan <bo...@chromium.org>
Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 19:09:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rakina Zata Amni (Gerrit)

unread,
May 15, 2026, 2:20:45 AM (4 days ago) May 15
to Taylor Brandstetter, Adam Rice, Hiroki Nakagawa, Andreas Haas, David Bokan, Taylor Brandstetter, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org
Attention needed from Adam Rice, Andreas Haas, David Bokan, Hiroki Nakagawa and Taylor Brandstetter

Rakina Zata Amni added 1 comment

Patchset-level comments
Rakina Zata Amni . resolved

(I think the other reviewers already cover the ownership needed for review, so let me remove myself)

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Andreas Haas
  • David Bokan
  • Hiroki Nakagawa
  • Taylor Brandstetter
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iea6190f533c4b87326671e0d40f7accadde0abb8
Gerrit-Change-Number: 7759798
Gerrit-PatchSet: 5
Gerrit-Owner: Taylor Brandstetter <dead...@chromium.org>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: David Bokan <bo...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Taylor Brandstetter <dead...@google.com>
Gerrit-Attention: Andreas Haas <ah...@chromium.org>
Gerrit-Attention: David Bokan <bo...@chromium.org>
Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Attention: Taylor Brandstetter <dead...@chromium.org>
Gerrit-Comment-Date: Fri, 15 May 2026 06:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Bokan (Gerrit)

unread,
May 15, 2026, 4:16:28 PM (4 days ago) May 15
to Taylor Brandstetter, Adam Rice, Hiroki Nakagawa, Andreas Haas, Taylor Brandstetter, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org
Attention needed from Adam Rice, Andreas Haas, Hiroki Nakagawa and Taylor Brandstetter

David Bokan added 2 comments

Patchset-level comments
File-level comment, Patchset 1:
Taylor Brandstetter . unresolved

I'm doing this following a discussion with Adam. The context is that we (Meet developers) would like the stack information that CreateOrEmpty provides, so we were thinking of just changing body.cc to use that, and preferably adding the fetch URL in the message as well for additional debuggability.

That would require an experiment for changing the message. But Adam also noticed that we should be providing the abort reason as well (if one is provided), which also would require an experiment. In which case we might as well do both at once.

A question though: What would be the best way to go about getting the URL into this message, assuming that's not problematic? The error is now coming from AbortSignal (https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/abort_signal.cc;l=279;drc=0a4317210c4de343411da25ccf8145d3091b3007) which doesn't have that context. Could I provide an optional string to its constructor for a default abort reason? Or would the memory footprint for that be a concern?

David Bokan

Apologies for the delay. I can't say I have a ton of expertise specifically in Fetch/Abort as a general Blink core dev but given this isn't long lived and URLs aren't that big I don't see the issue in copying in the KURL. You could even pass in and hold a pointer to `FetchRequestData` which is GarbageCollected, assuming all this makes sense for Abort (which Adam would be better placed to judge)

David Bokan . resolved

Removing myself since I don't think I'm the best reviewer in the list for fetch-related things.

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Andreas Haas
  • Hiroki Nakagawa
  • Taylor Brandstetter
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iea6190f533c4b87326671e0d40f7accadde0abb8
Gerrit-Change-Number: 7759798
Gerrit-PatchSet: 5
Gerrit-Owner: Taylor Brandstetter <dead...@chromium.org>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Taylor Brandstetter <dead...@google.com>
Gerrit-Attention: Andreas Haas <ah...@chromium.org>
Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Attention: Taylor Brandstetter <dead...@chromium.org>
Gerrit-Comment-Date: Fri, 15 May 2026 20:16:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Taylor Brandstetter <dead...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages