webauthn: implement PublicKeyCredential.parseRequestOptionsFromJSON() [chromium/src : main]
111 views
Skip to first unread message
Martin Kreichgauer (Gerrit)
Jun 17, 2024, 8:34:56 PM (12 days ago) Jun 17
to Martin Kreichgauer, Adam Langley, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Adam Langley
Martin Kreichgauer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Martin Kreichgauer
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Adam Langley
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Langley (Gerrit)
Jun 17, 2024, 9:02:48 PM (12 days ago) Jun 17
to Martin Kreichgauer, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Martin Kreichgauer
Adam Langley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Langley
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/modules/credentialmanagement/authentication_extensions_client_inputs_json.idl
Related details
Attention is currently required from:
- Martin Kreichgauer
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kreichgauer (Gerrit)
Jun 18, 2024, 12:57:38 PM (11 days ago) Jun 18
to Martin Kreichgauer, Adam Langley, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Adam Langley
Martin Kreichgauer voted and added 2 comments![]( "Open in Gerrit")
Votes added by Martin Kreichgauer
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/modules/credentialmanagement/authentication_extensions_client_inputs_json.idl
Related details
Attention is currently required from:
- Adam Langley
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Langley (Gerrit)
Jun 18, 2024, 1:11:33 PM (11 days ago) Jun 18
to Martin Kreichgauer, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Martin Kreichgauer
Adam Langley voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Martin Kreichgauer
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 18, 2024, 1:15:53 PM (11 days ago) Jun 18
to Martin Kreichgauer, Adam Langley, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Martin Kreichgauer
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/46815.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Martin Kreichgauer
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kreichgauer (Gerrit)
Jun 18, 2024, 2:06:12 PM (11 days ago) Jun 18
to Martin Kreichgauer, Blink W3C Test Autoroller, Adam Langley, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Martin Kreichgauer voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kreichgauer (Gerrit)
Jun 18, 2024, 3:53:09 PM (11 days ago) Jun 18
to Martin Kreichgauer, Blink W3C Test Autoroller, Adam Langley, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Martin Kreichgauer voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2024, 4:39:06 PM (11 days ago) Jun 18
to Martin Kreichgauer, Blink W3C Test Autoroller, Adam Langley, AyeAye, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/web_tests/external/wpt/webauthn/idlharness.https.window-expected.txt
Insertions: 2, Deletions: 1.
@@ -1,5 +1,6 @@
This is a testharness.js-based test.
-Found 2 FAIL, 0 TIMEOUT, 0 NOTRUN.
+Found 1 FAIL, 0 TIMEOUT, 0 NOTRUN.
[FAIL] PublicKeyCredential interface: operation getClientCapabilities()
assert_own_property: interface object missing static operation expected property "getClientCapabilities" missing
Harness: the test ran to completion.
+
```
```
The name of the file: third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Insertions: 1, Deletions: 0.
@@ -13312,3 +13312,4 @@
PASS successfullyParsed is true
TEST COMPLETE
+
```
```
The name of the file: third_party/blink/renderer/modules/credentialmanagement/json.cc
Insertions: 0, Deletions: 3.
@@ -139,9 +139,6 @@
if (json.hasHmacCreateSecret()) {
result->setHmacCreateSecret(json.hmacCreateSecret());
}
- if (json.hasUvm()) {
- result->setUvm(json.uvm());
- }
if (json.hasCredentialProtectionPolicy()) {
result->setCredentialProtectionPolicy(json.credentialProtectionPolicy());
}
```
Change information
Commit message:
webauthn: implement PublicKeyCredential.parseRequestOptionsFromJSON()
Add implementation and WPT. Flag guarded by
the existing `WebAuthenticationJSONSerialization` feature flag.
The method effectively creates a WebAuthn get() request from a JSON
dict.
Bug: 40250593
Change-Id: I4083fa2ffa17ec75520e0c38692f165f58e91400
Reviewed-by: Adam Langley <a...@chromium.org>
Commit-Queue: Martin Kreichgauer <mart...@google.com>
Cr-Commit-Position: refs/heads/main@{#1316672}
Files:
- M third_party/blink/renderer/bindings/generated_in_modules.gni
- M third_party/blink/renderer/bindings/idl_in_modules.gni
- A third_party/blink/renderer/modules/credentialmanagement/authentication_extensions_client_inputs_json.idl
- M third_party/blink/renderer/modules/credentialmanagement/json.cc
- M third_party/blink/renderer/modules/credentialmanagement/json.h
- M third_party/blink/renderer/modules/credentialmanagement/public_key_credential.cc
- M third_party/blink/renderer/modules/credentialmanagement/public_key_credential.h
- M third_party/blink/renderer/modules/credentialmanagement/public_key_credential.idl
- M third_party/blink/renderer/modules/credentialmanagement/public_key_credential_creation_options_json.idl
- A third_party/blink/renderer/modules/credentialmanagement/public_key_credential_descriptor_json.idl
- A third_party/blink/renderer/modules/credentialmanagement/public_key_credential_request_options_json.idl
- M third_party/blink/web_tests/external/wpt/webauthn/idlharness.https.window-expected.txt
- M third_party/blink/web_tests/external/wpt/webauthn/public-key-credential-creation-options-from-json.https.window.js
- A third_party/blink/web_tests/external/wpt/webauthn/public-key-credential-request-options-from-json.https.window.js
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Change size: L
Delta: 15 files changed, 338 insertions(+), 121 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adam Langley
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 18, 2024, 5:14:49 PM (11 days ago) Jun 18
to Martin Kreichgauer, Chromium LUCI CQ, Adam Langley, AyeAye, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, webauthn...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/46815
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages