Make BackgroundResourceScriptStreamer handle V8CannotStream case [chromium/src : main]
0 views
Skip to first unread message
Tsuyoshi Horo (Gerrit)
Jun 23, 2024, 11:37:47 PM (6 days ago) Jun 23
to Marja Hölttä, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Attention needed from Marja Hölttä
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Jun 24, 2024, 2:05:01 AM (6 days ago) Jun 24
to Tsuyoshi Horo, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Attention needed from Tsuyoshi Horo
Marja Hölttä voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marja Hölttä
| Code-Review | +1 |
1 comment
Patchset-level comments
Marja Hölttä . resolved
lgtm! thanks for fixing and sorry that I missed this corner case in the orig code review
Related details
Attention is currently required from:
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Jun 24, 2024, 2:05:24 AM (6 days ago) Jun 24
to Marja Hölttä, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2024, 2:11:58 AM (6 days ago) Jun 24
to Tsuyoshi Horo, Marja Hölttä, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make BackgroundResourceScriptStreamer handle V8CannotStream case
When --js-flags=--no-script-streaming command line flag is set,
v8::ScriptCompiler::StartStreaming() returns nullptr.
But BackgroundResourceScriptStreamer::BackgroundProcessor doesn't
correctly such case.
This CL makes BackgroundResourceScriptStreamer::BackgroundProcessor
support such case using NotStreamingReason::kV8CannotStream, as same as
ResourceScriptStreamer does.
Bug: 348520461
Change-Id: I6a8c863679245f4ce880303202a2adae447db34a
Commit-Queue: Tsuyoshi Horo <ho...@chromium.org>
Reviewed-by: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1318432}
Files:
- M content/browser/loader/loader_browsertest.cc
- M content/test/content_test_bundle_data.filelist
- A content/test/data/loader/blank.html
- A content/test/data/loader/change_title.js
- M third_party/blink/renderer/bindings/core/v8/script_streamer.cc
Change size: M
Delta: 5 files changed, 56 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marja Hölttä
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages