[Blink] Add scroll performance entry skeleton [chromium/src : main]

0 views
Skip to first unread message

Noam Helfman (Gerrit)

unread,
May 12, 2026, 2:55:27 AM (7 days ago) May 12
to suresh potti, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ashleynewson+w...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org
Attention needed from Olga Gerchikov

Noam Helfman removed suresh potti from this change

Deleted Reviewers:
  • suresh potti
Open in Gerrit

Related details

Attention is currently required from:
  • Olga Gerchikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icf150ff6dd9f77d1f22f7cfac0e11d072316865c
Gerrit-Change-Number: 7816404
Gerrit-PatchSet: 6
Gerrit-Owner: Noam Helfman <no...@microsoft.com>
Gerrit-Reviewer: Noam Helfman <no...@microsoft.com>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Olga Gerchikov (Gerrit)

unread,
May 12, 2026, 11:25:50 AM (7 days ago) May 12
to Noam Helfman, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ashleynewson+w...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org
Attention needed from Noam Helfman

Olga Gerchikov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Noam Helfman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icf150ff6dd9f77d1f22f7cfac0e11d072316865c
Gerrit-Change-Number: 7816404
Gerrit-PatchSet: 6
Gerrit-Owner: Noam Helfman <no...@microsoft.com>
Gerrit-Reviewer: Noam Helfman <no...@microsoft.com>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Noam Helfman <no...@microsoft.com>
Gerrit-Comment-Date: Tue, 12 May 2026 15:25:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Noam Helfman (Gerrit)

unread,
May 12, 2026, 11:41:06 AM (7 days ago) May 12
to Michal Mocny, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ashleynewson+w...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org
Attention needed from Michal Mocny and Noam Helfman

Noam Helfman added 3 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Noam Helfman . resolved

This is my first CL; feedback welcome.

File third_party/blink/renderer/core/timing/performance.cc
Line 532, Patchset 1: // Scroll entries are delivered through PerformanceObserver once scroll
Olga Gerchikov . resolved

Please use instead
// TODO(crbug.com/504094429): Scroll entries are delivered through PerformanceObserver once scroll instrumentation is added.

Noam Helfman

will fix

File third_party/blink/renderer/core/timing/performance_scroll_timing_test.cc
Line 18, Patchset 1: auto* window = LocalDOMWindow::From(scope.GetScriptState());
Olga Gerchikov . resolved

Please use const where appropriate.

Noam Helfman

fixed while also adding coverage

Open in Gerrit

Related details

Attention is currently required from:
  • Michal Mocny
  • Noam Helfman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icf150ff6dd9f77d1f22f7cfac0e11d072316865c
    Gerrit-Change-Number: 7816404
    Gerrit-PatchSet: 6
    Gerrit-Owner: Noam Helfman <no...@microsoft.com>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Noam Helfman <no...@microsoft.com>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
    Gerrit-Attention: Noam Helfman <no...@microsoft.com>
    Gerrit-Comment-Date: Tue, 12 May 2026 15:40:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Olga Gerchikov <gerc...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Noam Helfman (Gerrit)

    unread,
    May 12, 2026, 11:47:00 AM (7 days ago) May 12
    to Yoav Weiss, Michal Mocny, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ashleynewson+w...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org
    Attention needed from Michal Mocny and Yoav Weiss

    Noam Helfman added 1 comment

    Patchset-level comments
    Noam Helfman . resolved

    My first CL. Feedback is welcome!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michal Mocny
    • Yoav Weiss
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icf150ff6dd9f77d1f22f7cfac0e11d072316865c
    Gerrit-Change-Number: 7816404
    Gerrit-PatchSet: 6
    Gerrit-Owner: Noam Helfman <no...@microsoft.com>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Noam Helfman <no...@microsoft.com>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Reviewer: Yoav Weiss <yoav....@shopify.com>
    Gerrit-Attention: Yoav Weiss <yoav....@shopify.com>
    Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 May 2026 15:46:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yoav Weiss (@Shopify) (Gerrit)

    unread,
    4:55 AM (1 hour ago) 4:55 AM
    to Noam Helfman, Yoav Weiss, Michal Mocny, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ashleynewson+w...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org
    Attention needed from Michal Mocny, Noam Helfman and Yoav Weiss

    Yoav Weiss (@Shopify) added 2 comments

    Patchset-level comments
    Yoav Weiss (@Shopify) . resolved

    Do I understand correctly that this just adds the entry type, and adds it to the supported entry type, but never actually emits it, and listening on it will never fire?

    File third_party/blink/renderer/core/timing/performance.cc
    Line 526, Patchset 6 (Latest): // TaskAttribution and script entries are only associated with longtask
    Yoav Weiss (@Shopify) . unresolved

    This seems like an unrelated change. Can you revert?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michal Mocny
    • Noam Helfman
    • Yoav Weiss
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icf150ff6dd9f77d1f22f7cfac0e11d072316865c
      Gerrit-Change-Number: 7816404
      Gerrit-PatchSet: 6
      Gerrit-Owner: Noam Helfman <no...@microsoft.com>
      Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
      Gerrit-Reviewer: Noam Helfman <no...@microsoft.com>
      Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Reviewer: Yoav Weiss <yoav....@shopify.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Yoav Weiss <yoav....@shopify.com>
      Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
      Gerrit-Attention: Noam Helfman <no...@microsoft.com>
      Gerrit-Comment-Date: Tue, 19 May 2026 08:55:04 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages