Remove unused include in v8_binding.h [chromium/src : main]

0 views
Skip to first unread message

David Sanders (Gerrit)

unread,
Oct 1, 2025, 4:06:08 AM (5 days ago) Oct 1
to Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from David Sanders

Message from David Sanders

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I30223782dd8537e372bbffb49e023d05d4b940cc
Gerrit-Change-Number: 7000795
Gerrit-PatchSet: 6
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 08:05:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Oct 1, 2025, 4:08:03 AM (5 days ago) Oct 1
to David Sanders, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from David Sanders

Kentaro Hara voted and added 1 comment

Votes added by Kentaro Hara

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Kentaro Hara . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I30223782dd8537e372bbffb49e023d05d4b940cc
Gerrit-Change-Number: 7000795
Gerrit-PatchSet: 6
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 08:07:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Sanders (Gerrit)

unread,
Oct 1, 2025, 2:11:51 PM (4 days ago) Oct 1
to Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org

David Sanders voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I30223782dd8537e372bbffb49e023d05d4b940cc
Gerrit-Change-Number: 7000795
Gerrit-PatchSet: 6
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 18:11:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 1, 2025, 2:30:01 PM (4 days ago) Oct 1
to David Sanders, Kentaro Hara, Raphael Kubo da Costa, AyeAye, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove unused include in v8_binding.h
Bug: 40318405
Change-Id: I30223782dd8537e372bbffb49e023d05d4b940cc
Commit-Queue: David Sanders <dsand...@ucsbalum.com>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1523746}
Files:
  • M third_party/blink/renderer/platform/bindings/script_state.cc
  • M third_party/blink/renderer/platform/bindings/v8_binding.h
  • M third_party/blink/renderer/platform/bindings/v8_dom_activity_logger.cc
  • M third_party/blink/renderer/platform/bindings/v8_per_context_data.cc
Change size: XS
Delta: 4 files changed, 4 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kentaro Hara
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I30223782dd8537e372bbffb49e023d05d4b940cc
Gerrit-Change-Number: 7000795
Gerrit-PatchSet: 7
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages