Add options parameter to createSyncAccessHandle() [chromium/src : main]
Emanuel Krivoy (Gerrit)
Attention is currently required from: Marijn Kruisselbrink.
Emanuel Krivoy would like Marijn Kruisselbrink to review this change.
Add options parameter to createSyncAccessHandle()
For now the only accepted (and required) option is "mode: 'in-place'".
Having this parameter allows us to later define a more appropriate
default behavior for access handles than the one we currently implement.
This is specially useful in the context of expanding access handle usage
outside of OPFS.
For more details check:
https://github.com/WICG/file-system-access/blob/main/AccessHandle.md#exposing-accesshandles-on-all-filesystems
Bug: 1218431
Change-Id: I50d0a4acfd81874e17b6b28d1c2bf446b0397a4d
---
M third_party/blink/renderer/bindings/generated_in_modules.gni
M third_party/blink/renderer/bindings/idl_in_modules.gni
A third_party/blink/renderer/modules/file_system_access/file_system_create_access_handle_options.idl
M third_party/blink/renderer/modules/file_system_access/file_system_file_handle.cc
M third_party/blink/renderer/modules/file_system_access/file_system_file_handle.h
M third_party/blink/renderer/modules/file_system_access/file_system_file_handle.idl
M third_party/blink/web_tests/external/wpt/file-system-access/resources/message-target.js
M third_party/blink/web_tests/external/wpt/file-system-access/resources/sync-access-handle-test.js
M third_party/blink/web_tests/external/wpt/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-lock.https.tentative.worker.js
9 files changed, 41 insertions(+), 14 deletions(-)
To view, visit change 3110487. To unsubscribe, or for help writing mail filters, visit settings.
Emanuel Krivoy (Gerrit)
Attention is currently required from: Marijn Kruisselbrink.
Blink WPT Bot (Gerrit)
Attention is currently required from: Marijn Kruisselbrink.
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/30111.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Marijn Kruisselbrink (Gerrit)
Attention is currently required from: Emanuel Krivoy.
Patch set 1:Code-Review +1
Blink W3C Test Autoroller (Gerrit)
Attention is currently required from: Emanuel Krivoy.
The exported PR, https://github.com/web-platform-tests/wpt/pull/30111, has failed the following check(s) on GitHub:
wpt-firefox-nightly-stability (https://github.com/web-platform-tests/wpt/pull/30111/checks?check_run_id=5572642674)
These failures will block the export. They may represent new or existing problems; please take a look at the output and see if it can be fixed. Unresolved failures will be looked at by the Ecosystem-Infra sheriff after this CL has been landed in Chromium; if you need earlier help please contact ecosyst...@chromium.org.
Any suggestions to improve this service are welcome; crbug.com/1027618.
Gerrit CL SHA: ef25c12bd6716ce17cb458fed6e93eff862fbeb9
Patchset Number: 6
Emanuel Krivoy (Gerrit)
Attention is currently required from: Emanuel Krivoy.
Patch set 6:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: content/browser/file_system_access/file_system_access_capacity_allocation_host_impl_browsertest.cc
Insertions: 219, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/web_tests/external/wpt/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-lock.https.tentative.worker.js
Insertions: 0, Deletions: 43.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/web_tests/external/wpt/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker.js
Insertions: 88, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Add options parameter to createSyncAccessHandle()
For now the only accepted (and required) option is "mode: 'in-place'".
Having this parameter allows us to later define a more appropriate
default behavior for access handles than the one we currently implement.
This is specially useful in the context of expanding access handle usage
outside of OPFS.
For more details check:
https://github.com/WICG/file-system-access/blob/main/AccessHandle.md#exposing-accesshandles-on-all-filesystems
Bug: 1218431
Change-Id: I50d0a4acfd81874e17b6b28d1c2bf446b0397a4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110487
Reviewed-by: Marijn Kruisselbrink <m...@chromium.org>
Commit-Queue: Emanuel Krivoy <kri...@google.com>
Cr-Commit-Position: refs/heads/main@{#982209}
---
M content/browser/file_system_access/file_system_access_capacity_allocation_host_impl_browsertest.cc
M third_party/blink/renderer/bindings/generated_in_modules.gni
M third_party/blink/renderer/bindings/idl_in_modules.gni
A third_party/blink/renderer/modules/file_system_access/file_system_create_access_handle_options.idl
M third_party/blink/renderer/modules/file_system_access/file_system_file_handle.cc
M third_party/blink/renderer/modules/file_system_access/file_system_file_handle.h
M third_party/blink/renderer/modules/file_system_access/file_system_file_handle.idl
M third_party/blink/web_tests/external/wpt/file-system-access/resources/message-target.js
M third_party/blink/web_tests/external/wpt/file-system-access/resources/sync-access-handle-test.js
M third_party/blink/web_tests/external/wpt/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker.js
10 files changed, 68 insertions(+), 25 deletions(-)
Emanuel Krivoy (Gerrit)
Emanuel Krivoy has created a revert of this change.
To view, visit change 3110487. To unsubscribe, or for help writing mail filters, visit settings.