[FPF-CI] Remove end-to-end tests for Canvas Noise Tokens. [chromium/src : main]

0 views
Skip to first unread message

John Kim (Gerrit)

unread,
Oct 29, 2025, 12:13:24 PM (4 days ago) Oct 29
to Giovanni Ortuno Urquidi, Zainab Rizvi, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, johnyki...@google.com, kinuko...@chromium.org, ortuno...@chromium.org, rizvis...@google.com, thesals...@google.com
Attention needed from Dave Tapuska, Giovanni Ortuno Urquidi and Zainab Rizvi

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Giovanni Ortuno Urquidi
  • Zainab Rizvi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id94b864ee7b898072bf83bab0932dceb895a74b8
Gerrit-Change-Number: 7079250
Gerrit-PatchSet: 7
Gerrit-Owner: John Kim <john...@google.com>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Reviewer: John Kim <john...@google.com>
Gerrit-Reviewer: Zainab Rizvi <riz...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Attention: Zainab Rizvi <riz...@google.com>
Gerrit-Comment-Date: Wed, 29 Oct 2025 16:13:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dave Tapuska (Gerrit)

unread,
Oct 29, 2025, 12:28:14 PM (4 days ago) Oct 29
to John Kim, Giovanni Ortuno Urquidi, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, johnyki...@google.com, kinuko...@chromium.org, ortuno...@chromium.org, rizvis...@google.com, thesals...@google.com
Attention needed from Giovanni Ortuno Urquidi and John Kim

Dave Tapuska voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Giovanni Ortuno Urquidi
  • John Kim
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id94b864ee7b898072bf83bab0932dceb895a74b8
    Gerrit-Change-Number: 7079250
    Gerrit-PatchSet: 7
    Gerrit-Owner: John Kim <john...@google.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: John Kim <john...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: John Kim <john...@google.com>
    Gerrit-Comment-Date: Wed, 29 Oct 2025 16:28:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Giovanni Ortuno Urquidi (Gerrit)

    unread,
    Oct 29, 2025, 1:08:10 PM (4 days ago) Oct 29
    to John Kim, Giovanni Ortuno Urquidi, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, johnyki...@google.com, kinuko...@chromium.org, ortuno...@chromium.org, rizvis...@google.com, thesals...@google.com
    Attention needed from John Kim

    Giovanni Ortuno Urquidi voted and added 1 comment

    Votes added by Giovanni Ortuno Urquidi

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Giovanni Ortuno Urquidi . resolved

    T_T

    Open in Gerrit

    Related details

    Attention is currently required from:
    • John Kim
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id94b864ee7b898072bf83bab0932dceb895a74b8
    Gerrit-Change-Number: 7079250
    Gerrit-PatchSet: 7
    Gerrit-Owner: John Kim <john...@google.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: John Kim <john...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: John Kim <john...@google.com>
    Gerrit-Comment-Date: Wed, 29 Oct 2025 17:08:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 30, 2025, 11:01:15 AM (3 days ago) Oct 30
    to Tom Van Goethem, John Kim, Jean-Philippe Gravel, Giovanni Ortuno Urquidi, Dave Tapuska, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, johnyki...@google.com, kinuko...@chromium.org, ortuno...@chromium.org, rizvis...@google.com, thesals...@google.com

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    7 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [FPF-CI] Remove end-to-end tests for Canvas Noise Tokens.

    As per https://privacysandbox.google.com/overview/status, Canvas
    Interventions will be part of the deprecation. This CL removes e2e test
    infrastructure for Canvas Interventions.
    Bug: 454083467
    Change-Id: Id94b864ee7b898072bf83bab0932dceb895a74b8
    Commit-Queue: John Kim <john...@google.com>
    Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Reviewed-by: Dave Tapuska <dtap...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1537936}
    Files:
    • D chrome/browser/fingerprinting_protection/canvas_interventions_browsertest.cc
    • M chrome/test/BUILD.gn
    • D chrome/test/data/fingerprinting_protection/canvas_noise_token_sw.js
    • D chrome/test/data/fingerprinting_protection/canvas_noise_token_worker.js
    • M third_party/blink/renderer/bindings/generated_in_core.gni
    • M third_party/blink/renderer/bindings/idl_in_core.gni
    • M third_party/blink/renderer/core/canvas_interventions/build.gni
    • D third_party/blink/renderer/core/canvas_interventions/canvas_interventions_test.cc
    • D third_party/blink/renderer/core/canvas_interventions/canvas_interventions_test.h
    • D third_party/blink/renderer/core/canvas_interventions/canvas_interventions_test.idl
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    Change size: M
    Delta: 11 files changed, 0 insertions(+), 191 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Dave Tapuska, +1 by Giovanni Ortuno Urquidi
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id94b864ee7b898072bf83bab0932dceb895a74b8
    Gerrit-Change-Number: 7079250
    Gerrit-PatchSet: 10
    Gerrit-Owner: John Kim <john...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Jean-Philippe Gravel <jpgr...@chromium.org>
    Gerrit-Reviewer: John Kim <john...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages