[Trusted Types + CSP] Implement trusted-types-eval keyword. [chromium/src : main]
Daniel Vogelheim (Gerrit)
Daniel Vogelheim added 1 comment![]( "Open in Gerrit")
Related details
- Yifan Luo
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
AI Code Reviewer (Gerrit)
AI Code Reviewer added 2 comments![]( "Open in Gerrit")
bool CheckTrustedTypesEval(Google C++ Style Guide: Internal Linkage. This function should be `static` or in an anonymous namespace as it is not exported. Also, the parameter 'policy' is unused; please omit the name to avoid compiler warnings.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
bool CheckTrustedTypesEvalAndReportViolation(Google C++ Style Guide: Internal Linkage. This function should be `static` or in an anonymous namespace as it is not exported. Also, the parameter 'exception_status' is unused; please omit the name to avoid compiler warnings.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
- Yifan Luo
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Vogelheim (Gerrit)
Daniel Vogelheim added 2 comments![]( "Open in Gerrit")
bool CheckTrustedTypesEval(Google C++ Style Guide: Internal Linkage. This function should be `static` or in an anonymous namespace as it is not exported. Also, the parameter 'policy' is unused; please omit the name to avoid compiler warnings.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
OK But Won't Fix: This file defines numerous, conceptually similar `bool CheckXXX(...)` functions. This new function is consistent with all the other ones in this file. Maybe it makes sense to rewrite them all to be static; but I don't want this one function to be inconsistent with all the others.
bool CheckTrustedTypesEvalAndReportViolation(Google C++ Style Guide: Internal Linkage. This function should be `static` or in an anonymous namespace as it is not exported. Also, the parameter 'exception_status' is unused; please omit the name to avoid compiler warnings.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
OK But Won't Fix: Just as above, this function is consistent with all the other `bool CheckXXX` functions in this file.
Related details
- Yifan Luo
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yifan Luo (Gerrit)
Yifan Luo added 3 comments![]( "Open in Gerrit")
checks, when Trusted Types in enforced. When Trusted Types is not enforced, this directive has no effect.nit: is?
```suggestion
checks, when Trusted Types is enforced. When Trusted Types is not enforced, this directive has no effect.
```
if (ExecutionContext* execution_context = ToExecutionContext(context)) {
if (ContentSecurityPolicy* policy =
execution_context->GetContentSecurityPolicyForCurrentWorld()) {It looks a bit weird. In what kind of cases that `execution_context` can be null? Can we move the variable declaration out of the if condition and just add DCHECKs for it?
Related details
- Daniel Vogelheim
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |