Reland "Refactor crypto to use WindowOrWorkerGlobalScope partial mixin" [chromium/src : main]

0 views
Skip to first unread message

Suyeon Ji (Gerrit)

unread,
Dec 12, 2025, 8:37:26 AM (2 days ago) Dec 12
to Kentaro Hara, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Jinho Bang and Kentaro Hara

Suyeon Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Suyeon Ji . resolved

Hi, Please take a look. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Jinho Bang
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic6c407f72b79da235c743c4120a22c74a84664a3
Gerrit-Change-Number: 7252473
Gerrit-PatchSet: 6
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Jinho Bang <zi...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 13:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Dec 12, 2025, 8:42:39 AM (2 days ago) Dec 12
to Suyeon Ji, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Jinho Bang and Suyeon Ji

Kentaro Hara voted and added 1 comment

Votes added by Kentaro Hara

Code-Review+1

1 comment

Patchset-level comments
Kentaro Hara . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Jinho Bang
  • Suyeon Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic6c407f72b79da235c743c4120a22c74a84664a3
Gerrit-Change-Number: 7252473
Gerrit-PatchSet: 6
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
Gerrit-Attention: Jinho Bang <zi...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 13:42:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jinho Bang (Gerrit)

unread,
Dec 12, 2025, 8:54:02 AM (2 days ago) Dec 12
to Suyeon Ji, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji

Jinho Bang voted and added 1 comment

Votes added by Jinho Bang

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Jinho Bang . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Suyeon Ji
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic6c407f72b79da235c743c4120a22c74a84664a3
    Gerrit-Change-Number: 7252473
    Gerrit-PatchSet: 6
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
    Gerrit-Comment-Date: Fri, 12 Dec 2025 13:53:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 12, 2025, 9:30:30 AM (2 days ago) Dec 12
    to Suyeon Ji, Jinho Bang, Kentaro Hara, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Reland "Refactor crypto to use WindowOrWorkerGlobalScope partial mixin"

    This is a reland of commit dd64337094f7cfe8a8d9ff26f168826d70bde5cf

    Reason for reland:
    The previous implementation avoided using Supplementable due to the deprecation plan discussed in [1]. However, since the decision to remove
    Supplementable has been rescinded, this CL re-implements interface
    mixins using the originally intended approach backed by Supplementable.

    [1]: https://groups.google.com/a/chromium.org/g/blink-dev/c/nbTIoUZW6n0/m/BW11I9SqAQAJ

    Original change's description:
    > This patch migrates partial interfaces to a partial interface mixin
    > to align with the specification.
    >
    > This CL has no behavior changes.
    >
    > Bug: 449023252
    > Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7005133
    > Reviewed-by: Kentaro Hara <har...@chromium.org>
    > Commit-Queue: Jinho Bang <zi...@chromium.org>
    > Reviewed-by: Jinho Bang <zi...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1549040}
    Bug: 449023252
    Change-Id: Ic6c407f72b79da235c743c4120a22c74a84664a3
    Reviewed-by: Jinho Bang <zi...@chromium.org>
    Reviewed-by: Kentaro Hara <har...@chromium.org>
    Commit-Queue: Jinho Bang <zi...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1558001}
    Files:
    • M third_party/blink/renderer/bindings/idl_in_modules.gni
    • M third_party/blink/renderer/modules/crypto/BUILD.gn
    • R third_party/blink/renderer/modules/crypto/global_crypto.cc
    • R third_party/blink/renderer/modules/crypto/global_crypto.h
    • D third_party/blink/renderer/modules/crypto/window_crypto.idl
    • R third_party/blink/renderer/modules/crypto/window_or_worker_global_scope_crypto.idl
    • D third_party/blink/renderer/modules/crypto/worker_global_scope_crypto.h
    Change size: M
    Delta: 7 files changed, 35 insertions(+), 138 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jinho Bang, +1 by Kentaro Hara
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic6c407f72b79da235c743c4120a22c74a84664a3
    Gerrit-Change-Number: 7252473
    Gerrit-PatchSet: 7
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages