[v8] Pass info by reference to V8DOMActivityLogger::LogMethod(..) [chromium/src : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Dec 11, 2025, 2:09:17 PM (3 days ago) Dec 11
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Yuki Shiino
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Yuki Shiino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuki Shiino (Gerrit)
Dec 12, 2025, 2:34:08 AM (3 days ago) Dec 12
to Igor Sheludko, Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Igor Sheludko
Yuki Shiino voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuki Shiino
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 12, 2025, 2:37:23 AM (3 days ago) Dec 12
to Igor Sheludko, Yuki Shiino, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[v8] Pass info by reference to V8DOMActivityLogger::LogMethod(..)
... instead of passing it by value.
V8 is preparing for flattening v8::FunctionCallbackInfo<T> structure
which would make it non-copyable.
Bug: 326505377
Change-Id: I76c6fcec8fe8601b7ad9268ec05bea4a1dc154b2
Reviewed-by: Yuki Shiino <yukis...@chromium.org>
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Yuki Shiino <yukis...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557879}
Files:
- M third_party/blink/renderer/platform/bindings/v8_dom_activity_logger.cc
- M third_party/blink/renderer/platform/bindings/v8_dom_activity_logger.h
Change size: XS
Delta: 2 files changed, 5 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuki Shiino
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages