Rename and enable EXT_blend_func_extended WebGL extension. [chromium/src : main]

0 views
Skip to first unread message

Kenneth Russell (Gerrit)

unread,
Jan 18, 2024, 8:13:40 PM1/18/24
to blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, Alexey Knyazev

Kenneth Russell has uploaded the change for review

Commit message

Rename and enable EXT_blend_func_extended WebGL extension.

Patch by Alexey Knyazev.

Rename to WEBGL_blend_func_extended per agreement in the working
group, because there are differences compared to the OpenGL ES version
of the extension.

Update some test expectations; they will need to be revised again the
next time the WebGL conformance suite is rolled into Chromium.
Bug: 1473838
Change-Id: Ie9a635b9e9bc69fdf1f4f592b24da682a0645a0a

Change diff


Change information

Files:
  • M content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt
  • M content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
  • M content/test/gpu/gpu_tests/webgl1_conformance_integration_test.py
  • M content/test/gpu/gpu_tests/webgl2_conformance_integration_test.py
  • M third_party/blink/renderer/bindings/generated_in_modules.gni
  • M third_party/blink/renderer/bindings/idl_in_modules.gni
  • M third_party/blink/renderer/modules/webgl/BUILD.gn
  • D third_party/blink/renderer/modules/webgl/ext_blend_func_extended.cc
  • D third_party/blink/renderer/modules/webgl/ext_blend_func_extended.h
  • D third_party/blink/renderer/modules/webgl/ext_blend_func_extended.idl
  • M third_party/blink/renderer/modules/webgl/webgl2_rendering_context.cc
  • M third_party/blink/renderer/modules/webgl/webgl2_rendering_context.h
  • A third_party/blink/renderer/modules/webgl/webgl_blend_func_extended.cc
  • A third_party/blink/renderer/modules/webgl/webgl_blend_func_extended.h
  • A third_party/blink/renderer/modules/webgl/webgl_blend_func_extended.idl
  • M third_party/blink/renderer/modules/webgl/webgl_extension_name.h
  • M third_party/blink/renderer/modules/webgl/webgl_rendering_context.cc
  • M third_party/blink/renderer/modules/webgl/webgl_rendering_context.h
  • M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
Change size: M
Delta: 19 files changed, 115 insertions(+), 110 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie9a635b9e9bc69fdf1f4f592b24da682a0645a0a
Gerrit-Change-Number: 5214661
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kai Ninomiya (Gerrit)

unread,
Jan 18, 2024, 8:59:26 PM1/18/24
to Kenneth Russell, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, Alexey Knyazev, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara
Attention needed from Kenneth Russell

Kai Ninomiya added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kai Ninomiya . resolved

Would you mind splitting this into separate CLs for renaming and enabling? If we need to revert for any reason it would be preferable to revert a smaller change.

Open in Gerrit

Related details

Attention is currently required from:
  • Kenneth Russell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie9a635b9e9bc69fdf1f4f592b24da682a0645a0a
Gerrit-Change-Number: 5214661
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
Gerrit-CC: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Kenneth Russell <k...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Jan 2024 01:59:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kenneth Russell (Gerrit)

unread,
Jan 18, 2024, 9:07:52 PM1/18/24
to blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, Kai Ninomiya, Alexey Knyazev, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara
Attention needed from Kai Ninomiya

Kenneth Russell added 1 comment

Patchset-level comments
Kai Ninomiya . resolved

Would you mind splitting this into separate CLs for renaming and enabling? If we need to revert for any reason it would be preferable to revert a smaller change.

Kenneth Russell

Yes, can do. Another revision incoming.

Open in Gerrit

Related details

Attention is currently required from:
  • Kai Ninomiya
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie9a635b9e9bc69fdf1f4f592b24da682a0645a0a
Gerrit-Change-Number: 5214661
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
Gerrit-CC: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Kai Ninomiya <kai...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Jan 2024 02:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kai Ninomiya <kai...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kenneth Russell (Gerrit)

unread,
Jan 18, 2024, 9:12:27 PM1/18/24
to blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org
Attention needed from Kai Ninomiya and Kenneth Russell

Kenneth Russell uploaded new patchset

Kenneth Russell uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Kai Ninomiya
  • Kenneth Russell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie9a635b9e9bc69fdf1f4f592b24da682a0645a0a
Gerrit-Change-Number: 5214661
Gerrit-PatchSet: 2
Gerrit-Owner: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
Gerrit-CC: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Kai Ninomiya <kai...@chromium.org>
Gerrit-Attention: Kenneth Russell <k...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages