Switch to base::Time constant in V8ScriptValueDeserializer::ReadFile [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Sep 29, 2025, 10:20:09 AM (7 days ago) Sep 29
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2024774ebd7a364d4d30053a9a302a8c1910b957
Gerrit-Change-Number: 6994197
Gerrit-PatchSet: 1
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 14:19:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jeremy Roman (Gerrit)

unread,
Sep 29, 2025, 11:51:54 AM (7 days ago) Sep 29
to Fredrik Söderquist, Jeremy Roman, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org
Attention needed from Fredrik Söderquist and Kent Tamura

Jeremy Roman voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2024774ebd7a364d4d30053a9a302a8c1910b957
    Gerrit-Change-Number: 6994197
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 15:51:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Fredrik Söderquist (Gerrit)

    unread,
    Sep 29, 2025, 12:05:22 PM (7 days ago) Sep 29
    to Jeremy Roman, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org
    Attention needed from Kent Tamura

    Fredrik Söderquist voted

    Auto-Submit+0
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kent Tamura
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2024774ebd7a364d4d30053a9a302a8c1910b957
    Gerrit-Change-Number: 6994197
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 16:05:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 12:18:53 PM (7 days ago) Sep 29
    to Fredrik Söderquist, Jeremy Roman, Kent Tamura, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Switch to base::Time constant in V8ScriptValueDeserializer::ReadFile

    Replace use of kMsPerSecond with base::Time::kMillisecondsPerSecond.
    Reorder the code so that everything pertaining to the snapshot
    deserialization is handled in one place (setting last-modified).
    Bug: 446602676
    Change-Id: I2024774ebd7a364d4d30053a9a302a8c1910b957
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Jeremy Roman <jbr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522267}
    Files:
    • M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_deserializer.cc
    Change size: S
    Delta: 1 file changed, 7 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jeremy Roman
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2024774ebd7a364d4d30053a9a302a8c1910b957
    Gerrit-Change-Number: 6994197
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages