Blink: Rename ParkableStringImpl::SecureDigest to SecureStringDigest [chromium/src : main]
38 views
Skip to first unread message
Takashi Nakayama (Gerrit)
Mar 11, 2026, 9:10:23 PMMar 11
to Kouhei Ueno, Hiroshige Hayashizaki, Leszek Swirski, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, gavinp...@chromium.org, kouhei...@chromium.org, hiroshig...@chromium.org, loading-re...@chromium.org, blink-revie...@chromium.org, dom+...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki, Kouhei Ueno and Leszek Swirski
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
- Leszek Swirski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Mar 12, 2026, 12:40:04 AMMar 12
to Takashi Nakayama, Leszek Swirski, Benoit Lize, Hiroshige Hayashizaki, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, gavinp...@chromium.org, kouhei...@chromium.org, hiroshig...@chromium.org, loading-re...@chromium.org, blink-revie...@chromium.org, dom+...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Takashi Nakayama
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hiroshige Hayashizaki
- Takashi Nakayama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
Mar 22, 2026, 6:29:34 AM (11 days ago) Mar 22
to Takashi Nakayama, Kouhei Ueno, Leszek Swirski, Benoit Lize, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, gavinp...@chromium.org, kouhei...@chromium.org, hiroshig...@chromium.org, loading-re...@chromium.org, blink-revie...@chromium.org, dom+...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Attention needed from Takashi Nakayama
Hiroshige Hayashizaki voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Takashi Nakayama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 31, 2026, 1:18:31 AM (2 days ago) Mar 31
to Takashi Nakayama, Hiroshige Hayashizaki, Kouhei Ueno, Leszek Swirski, Benoit Lize, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, AyeAye, gavinp...@chromium.org, kouhei...@chromium.org, hiroshig...@chromium.org, loading-re...@chromium.org, blink-revie...@chromium.org, dom+...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Blink: Rename ParkableStringImpl::SecureDigest to SecureStringDigest
This CL moves ParkableStringImpl::SecureDigest to SecureStringDigest in
`blink::` and renames `ParkableStringImpl::kDigestSize` to
`kSha256Bytes`. `ScriptCachedMetadataHandlerWithHashing::kSha256Bytes`
is removed and unified with the new `kSha256Bytes`.
Change-Id: Idc5b6913ca3f87f0c69c9344eac38b53ebfadaa9
Reviewed-by: Hiroshige Hayashizaki <hiro...@chromium.org>
Commit-Queue: Takashi Nakayama <tn...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1607625}
Files:
- M third_party/blink/renderer/bindings/core/v8/script_decoder.cc
- M third_party/blink/renderer/bindings/core/v8/script_decoder.h
- M third_party/blink/renderer/bindings/core/v8/script_decoder_test.cc
- M third_party/blink/renderer/bindings/core/v8/script_streamer.cc
- M third_party/blink/renderer/bindings/core/v8/script_streamer.h
- M third_party/blink/renderer/core/loader/resource/resource_loader_code_cache_test.cc
- M third_party/blink/renderer/core/loader/resource/script_resource.cc
- M third_party/blink/renderer/core/loader/resource/script_resource.h
- M third_party/blink/renderer/platform/bindings/parkable_string.cc
- M third_party/blink/renderer/platform/bindings/parkable_string.h
- M third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
- M third_party/blink/renderer/platform/bindings/parkable_string_manager.h
- M third_party/blink/renderer/platform/loader/fetch/raw_resource_test.cc
- M third_party/blink/renderer/platform/loader/fetch/resource.h
- M third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
- M third_party/blink/renderer/platform/loader/fetch/resource_loader.h
- M third_party/blink/renderer/platform/loader/fetch/response_body_loader.cc
- M third_party/blink/renderer/platform/loader/fetch/response_body_loader.h
- M third_party/blink/renderer/platform/loader/fetch/response_body_loader_client.h
- M third_party/blink/renderer/platform/loader/fetch/response_body_loader_test.cc
- M third_party/blink/renderer/platform/loader/fetch/script_cached_metadata_handler.cc
- M third_party/blink/renderer/platform/loader/fetch/script_cached_metadata_handler.h
Change size: M
Delta: 22 files changed, 73 insertions(+), 77 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kouhei Ueno, +1 by Hiroshige Hayashizaki
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages