[CodeHealth] Rename channel_span() to channel() [chromium/src : main]

0 views
Skip to first unread message

Thomas Guilbert (Gerrit)

unread,
Dec 11, 2025, 7:42:36 PM (3 days ago) Dec 11
to Raphael Kubo da Costa, chromium...@chromium.org, Hongchan Choi, Kentaro Hara, kinuko...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, Thomas Guilbert

Thomas Guilbert has uploaded the change for review

Commit message

[CodeHealth] Rename channel_span() to channel()

Replace uses of `AudioBus::channel_span()` with the identical
`AudioBus::channel()`.

These changes are pure renames + reformatting, there are no functional
changes.

Directories covered in this split:
third_party/blink

This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
Bug: 373960632
Change-Id: Ied2503a248b5f52331492f0d74e09524d59e01f6

Change diff


Change information

Files:
  • M third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules_test.cc
  • M third_party/blink/renderer/modules/breakout_box/media_stream_audio_track_underlying_source.cc
  • M third_party/blink/renderer/modules/breakout_box/media_stream_audio_track_underlying_source_test.cc
  • M third_party/blink/renderer/modules/breakout_box/pushable_media_stream_audio_source_test.cc
  • M third_party/blink/renderer/modules/media/audio/audio_renderer_mixer_test.cc
  • M third_party/blink/renderer/modules/mediastream/media_stream_audio_processor_test.cc
  • M third_party/blink/renderer/modules/mediastream/webaudio_media_stream_audio_sink_test.cc
  • M third_party/blink/renderer/modules/webcodecs/audio_data.cc
  • M third_party/blink/renderer/platform/audio/audio_destination.cc
  • M third_party/blink/renderer/platform/audio/media_multi_channel_resampler.cc
  • M third_party/blink/renderer/platform/media/web_audio_source_provider_impl_test.cc
  • M third_party/blink/renderer/platform/mediastream/media_stream_audio_level_calculator_unittest.cc
  • M third_party/blink/renderer/platform/mediastream/media_stream_audio_test.cc
Change size: M
Delta: 13 files changed, 35 insertions(+), 37 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ied2503a248b5f52331492f0d74e09524d59e01f6
Gerrit-Change-Number: 7254783
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Guilbert (Gerrit)

unread,
Dec 11, 2025, 7:46:18 PM (3 days ago) Dec 11
to Thomas Guilbert, Kentaro Hara, chromium...@chromium.org, Hongchan Choi, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, tommyw+w...@chromium.org
Attention needed from Kentaro Hara

Thomas Guilbert voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ied2503a248b5f52331492f0d74e09524d59e01f6
Gerrit-Change-Number: 7254783
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 00:46:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Dec 11, 2025, 8:13:13 PM (3 days ago) Dec 11
to Thomas Guilbert, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, tommyw+w...@chromium.org
Attention needed from Thomas Guilbert

Kentaro Hara voted and added 1 comment

Votes added by Kentaro Hara

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kentaro Hara . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Guilbert
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ied2503a248b5f52331492f0d74e09524d59e01f6
Gerrit-Change-Number: 7254783
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 01:12:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thomas Guilbert (Gerrit)

unread,
Dec 11, 2025, 8:19:02 PM (3 days ago) Dec 11
to Thomas Guilbert, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, tommyw+w...@chromium.org

Thomas Guilbert voted and added 1 comment

Votes added by Thomas Guilbert

Commit-Queue+2

1 comment

Patchset-level comments
Kentaro Hara . resolved

LGTM

Thomas Guilbert

TY!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ied2503a248b5f52331492f0d74e09524d59e01f6
Gerrit-Change-Number: 7254783
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Fri, 12 Dec 2025 01:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kentaro Hara <har...@chromium.org>
satisfied_requirement
open
diffy

Thomas Guilbert (Gerrit)

unread,
Dec 11, 2025, 8:19:49 PM (3 days ago) Dec 11
to Thomas Guilbert, AyeAye, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mfoltz+wa...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, tommyw+w...@chromium.org

Thomas Guilbert abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic2066ace026d142b33f5738ce4b565b7cd7f81db
Gerrit-Change-Number: 7254634
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 11, 2025, 9:52:11 PM (3 days ago) Dec 11
to Thomas Guilbert, Kentaro Hara, AyeAye, chromium...@chromium.org, Hongchan Choi, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, tommyw+w...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[CodeHealth] Rename channel_span() to channel()

Replace uses of `AudioBus::channel_span()` with the identical
`AudioBus::channel()`.

These changes are pure renames + reformatting, there are no functional
changes.

Directories covered in this split:
third_party/blink

This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
Bug: 373960632
Change-Id: Ied2503a248b5f52331492f0d74e09524d59e01f6
Auto-Submit: Thomas Guilbert <tgui...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Thomas Guilbert <tgui...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557813}
Files:
  • M third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules_test.cc
  • M third_party/blink/renderer/modules/breakout_box/media_stream_audio_track_underlying_source.cc
  • M third_party/blink/renderer/modules/breakout_box/media_stream_audio_track_underlying_source_test.cc
  • M third_party/blink/renderer/modules/breakout_box/pushable_media_stream_audio_source_test.cc
  • M third_party/blink/renderer/modules/media/audio/audio_renderer_mixer_test.cc
  • M third_party/blink/renderer/modules/mediastream/media_stream_audio_processor_test.cc
  • M third_party/blink/renderer/modules/mediastream/webaudio_media_stream_audio_sink_test.cc
  • M third_party/blink/renderer/modules/webcodecs/audio_data.cc
  • M third_party/blink/renderer/platform/audio/audio_destination.cc
  • M third_party/blink/renderer/platform/audio/media_multi_channel_resampler.cc
  • M third_party/blink/renderer/platform/media/web_audio_source_provider_impl_test.cc
  • M third_party/blink/renderer/platform/mediastream/media_stream_audio_level_calculator_unittest.cc
  • M third_party/blink/renderer/platform/mediastream/media_stream_audio_test.cc
Change size: M
Delta: 13 files changed, 35 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kentaro Hara
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ied2503a248b5f52331492f0d74e09524d59e01f6
Gerrit-Change-Number: 7254783
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages