blink: Implement V8's crash key interface [chromium/src : main]
43 views
Skip to first unread message
Michael Lippautz (Gerrit)
Oct 24, 2025, 3:48:56 AM (9 days ago) Oct 24
to Dominik Inführ, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Dominik Inführ
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Lippautz . resolved
lgtm (I realize this will be green with the corresponding V8 change)
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 30, 2025, 5:49:45 AM (3 days ago) Oct 30
to Andreas Haas, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Andreas Haas and Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Dominik Inführ . resolved
PTAL, I need two reviewers, thanks!
Related details
Attention is currently required from:
- Andreas Haas
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Oct 30, 2025, 6:10:07 AM (3 days ago) Oct 30
to Dominik Inführ, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Dominik Inführ and Michael Lippautz
Andreas Haas added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc
Line 186, Patchset 4 (Latest):
GetIsolate()->SetCrashKeyStringCallbacks(AllocateCrashKeyString,Andreas Haas . unresolved
As discussed offline, I would recommend to set the callback in v8_initializer.cc, where other callbacks are set as well. It may be good to move the other CrashKey code there as well.
Related details
Attention is currently required from:
- Dominik Inführ
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 30, 2025, 1:08:34 PM (3 days ago) Oct 30
to Andreas Haas, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Andreas Haas and Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc
Line 186, Patchset 4:
GetIsolate()->SetCrashKeyStringCallbacks(AllocateCrashKeyString,Andreas Haas . resolved
As discussed offline, I would recommend to set the callback in v8_initializer.cc, where other callbacks are set as well. It may be good to move the other CrashKey code there as well.
Attention is currently required from:
- Andreas Haas
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Oct 30, 2025, 1:12:52 PM (3 days ago) Oct 30
to Dominik Inführ, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Dominik Inführ and Michael Lippautz
Andreas Haas voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 30, 2025, 2:23:46 PM (3 days ago) Oct 30
to Andreas Haas, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Andreas Haas and Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Dominik Inführ . resolved
PTALA, unfortunately I lost the +1 because I moved the using statement.
Related details
Attention is currently required from:
- Andreas Haas
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Oct 30, 2025, 3:11:05 PM (3 days ago) Oct 30
to Dominik Inführ, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Dominik Inführ and Michael Lippautz
Andreas Haas voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Oct 31, 2025, 5:00:19 AM (2 days ago) Oct 31
to Dominik Inführ, Andreas Haas, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Dominik Inführ
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 31, 2025, 5:51:28 AM (2 days ago) Oct 31
to Michael Lippautz, Andreas Haas, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 31, 2025, 5:51:48 AM (2 days ago) Oct 31
to Michael Lippautz, Andreas Haas, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Dominik Inführ voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Dominik Inführ (Gerrit)
Oct 31, 2025, 5:53:37 AM (2 days ago) Oct 31
to Michael Lippautz, Andreas Haas, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Dominik Inführ voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 31, 2025, 5:56:40 AM (2 days ago) Oct 31
to Dominik Inführ, Michael Lippautz, Andreas Haas, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
blink: Implement V8's crash key interface
This CL implements the new crash key API used in V8 to report
crash keys on OOM errors. The API basically only forwards to
Chrome's internal crash key API.
As a cleanup this CL also moves this setup to v8_initializer.cc,
where most callbacks are set up.
Bug: 389951203
Change-Id: I45fa3d13a915b9e92d13a85293c40a2f830c7bbf
Reviewed-by: Andreas Haas <ah...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538472}
Files:
- M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
- M third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc
Change size: M
Delta: 2 files changed, 69 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andreas Haas, +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages