Add IPAddress::IsMulticast() helper [chromium/src : main]

0 views
Skip to first unread message

Reilly Grant (Gerrit)

unread,
Mar 11, 2026, 7:53:41 PM (yesterday) Mar 11
to Omar Ramadan, Reilly Grant, AyeAye, chromium...@chromium.org, Andrew Rayskiy, Kentaro Hara, Raphael Kubo da Costa, Nikhil Nayunigari, Simon Hangl, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, chadduffin+w...@chromium.org, chromium-a...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, fenced-fra...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jmedle...@chromium.org, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, stevenjb+wa...@chromium.org
Attention needed from Omar Ramadan

Reilly Grant voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Omar Ramadan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4cac332f2d98505d176e8ceeeb0b39368e988e2a
Gerrit-Change-Number: 7659547
Gerrit-PatchSet: 2
Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Omar Ramadan <om...@blockcast.net>
Gerrit-Comment-Date: Wed, 11 Mar 2026 23:53:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nick Harper (Gerrit)

unread,
Mar 11, 2026, 7:59:10 PM (24 hours ago) Mar 11
to Omar Ramadan, Chromium LUCI CQ, Reilly Grant, AyeAye, chromium...@chromium.org, Andrew Rayskiy, Kentaro Hara, Raphael Kubo da Costa, Nikhil Nayunigari, Simon Hangl, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, chadduffin+w...@chromium.org, chromium-a...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, fenced-fra...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jmedle...@chromium.org, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, stevenjb+wa...@chromium.org
Attention needed from Omar Ramadan

Nick Harper voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Omar Ramadan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4cac332f2d98505d176e8ceeeb0b39368e988e2a
Gerrit-Change-Number: 7659547
Gerrit-PatchSet: 2
Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Omar Ramadan <om...@blockcast.net>
Gerrit-Comment-Date: Wed, 11 Mar 2026 23:58:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Reilly Grant (Gerrit)

unread,
Mar 11, 2026, 8:26:45 PM (24 hours ago) Mar 11
to Omar Ramadan, Nick Harper, Chromium LUCI CQ, Reilly Grant, AyeAye, chromium...@chromium.org, Andrew Rayskiy, Kentaro Hara, Raphael Kubo da Costa, Nikhil Nayunigari, Simon Hangl, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, chadduffin+w...@chromium.org, chromium-a...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, fenced-fra...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jmedle...@chromium.org, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, stevenjb+wa...@chromium.org
Attention needed from Omar Ramadan

Reilly Grant voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Thu, 12 Mar 2026 00:26:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Mar 11, 2026, 10:35:44 PM (21 hours ago) Mar 11
to Omar Ramadan, Nick Harper, Reilly Grant, AyeAye, chromium...@chromium.org, Andrew Rayskiy, Kentaro Hara, Raphael Kubo da Costa, Nikhil Nayunigari, Simon Hangl, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, chadduffin+w...@chromium.org, chromium-a...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, fenced-fra...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jmedle...@chromium.org, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, stevenjb+wa...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add IPAddress::IsMulticast() helper

Add a method to check whether an IP address falls in the multicast
range (IPv4: 224.0.0.0/4, IPv6: ff00::/8). This is needed by the
upcoming SSM support in the Direct Sockets API.

This is a reland of the //net portion of commit 030237772913c,
which was reverted in 3076e5f581b85.
Bug: 461262401
Change-Id: I4cac332f2d98505d176e8ceeeb0b39368e988e2a
Reviewed-by: Reilly Grant <rei...@chromium.org>
Reviewed-by: Nick Harper <nha...@chromium.org>
Commit-Queue: Reilly Grant <rei...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1598159}
Files:
  • M net/base/ip_address.cc
  • M net/base/ip_address.h
  • M net/base/ip_address_unittest.cc
Change size: S
Delta: 3 files changed, 37 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nick Harper, +1 by Reilly Grant
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4cac332f2d98505d176e8ceeeb0b39368e988e2a
Gerrit-Change-Number: 7659547
Gerrit-PatchSet: 3
Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages