[KA] Write more suggestion render tests. [chromium/src : main]

0 views
Skip to first unread message

Timofey Chudakov (Gerrit)

unread,
Oct 31, 2025, 9:14:33 AM (2 days ago) Oct 31
to Chromium Metrics Reviews, (Julie)Jeongeun Kim, Heron Yang, Raphael Kubo da Costa, Enterprise Policy Reviews, Kevin Babbitt, Mangesh Ghiware, Kentaro Hara, AyeAye, Luchen Peng, Chromium LUCI CQ, chromium...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, druber...@chromium.org, gavin...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, prerenderi...@chromium.org, telemetr...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, blink-rev...@chromium.org, kyungjunle...@google.com, dtseng...@chromium.org, srahim...@chromium.org, blink-rev...@chromium.org, mac-r...@chromium.org, wfh+...@chromium.org, francisjp...@google.com, blink-...@chromium.org, loading...@chromium.org, nektar...@chromium.org, tburkar...@chromium.org, browser-comp...@chromium.org, yuzo+...@chromium.org, net-r...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, lucasrada...@google.com, asvitkine...@chromium.org, blink-revie...@chromium.org, oshima...@chromium.org, devtools...@chromium.org, abigailbk...@google.com
Attention needed from Luchen Peng

Timofey Chudakov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Luchen Peng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e26f8281e4e1cef5affc5a75579a274f5fd8926
Gerrit-Change-Number: 7079037
Gerrit-PatchSet: 11
Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
Gerrit-Reviewer: Luchen Peng <luche...@google.com>
Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Luchen Peng <luche...@google.com>
Gerrit-Comment-Date: Fri, 31 Oct 2025 13:14:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Luchen Peng (Gerrit)

unread,
Oct 31, 2025, 10:35:02 AM (2 days ago) Oct 31
to Timofey Chudakov, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Heron Yang, Raphael Kubo da Costa, Enterprise Policy Reviews, Kevin Babbitt, Mangesh Ghiware, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, druber...@chromium.org, gavin...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, prerenderi...@chromium.org, telemetr...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, blink-rev...@chromium.org, kyungjunle...@google.com, dtseng...@chromium.org, srahim...@chromium.org, blink-rev...@chromium.org, mac-r...@chromium.org, wfh+...@chromium.org, francisjp...@google.com, blink-...@chromium.org, loading...@chromium.org, nektar...@chromium.org, tburkar...@chromium.org, browser-comp...@chromium.org, yuzo+...@chromium.org, net-r...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, lucasrada...@google.com, asvitkine...@chromium.org, blink-revie...@chromium.org, oshima...@chromium.org, devtools...@chromium.org, abigailbk...@google.com
Attention needed from Timofey Chudakov

Luchen Peng voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Timofey Chudakov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9e26f8281e4e1cef5affc5a75579a274f5fd8926
    Gerrit-Change-Number: 7079037
    Gerrit-PatchSet: 11
    Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
    Gerrit-Reviewer: Luchen Peng <luche...@google.com>
    Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Heron Yang <hero...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Timofey Chudakov <tchu...@google.com>
    Gerrit-Comment-Date: Fri, 31 Oct 2025 14:34:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Timofey Chudakov (Gerrit)

    unread,
    Oct 31, 2025, 10:53:57 AM (2 days ago) Oct 31
    to Luchen Peng, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Heron Yang, Raphael Kubo da Costa, Enterprise Policy Reviews, Kevin Babbitt, Mangesh Ghiware, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, druber...@chromium.org, gavin...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, prerenderi...@chromium.org, telemetr...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, blink-rev...@chromium.org, kyungjunle...@google.com, dtseng...@chromium.org, srahim...@chromium.org, blink-rev...@chromium.org, mac-r...@chromium.org, wfh+...@chromium.org, francisjp...@google.com, blink-...@chromium.org, loading...@chromium.org, nektar...@chromium.org, tburkar...@chromium.org, browser-comp...@chromium.org, yuzo+...@chromium.org, net-r...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, lucasrada...@google.com, asvitkine...@chromium.org, blink-revie...@chromium.org, oshima...@chromium.org, devtools...@chromium.org, abigailbk...@google.com

    Timofey Chudakov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Fri, 31 Oct 2025 14:53:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 31, 2025, 10:57:03 AM (2 days ago) Oct 31
    to Timofey Chudakov, Luchen Peng, Chromium Metrics Reviews, (Julie)Jeongeun Kim, Heron Yang, Raphael Kubo da Costa, Akihiro Ota, Enterprise Policy Reviews, Kevin Babbitt, Mangesh Ghiware, Kentaro Hara, AyeAye, chromium...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, druber...@chromium.org, gavin...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, prerenderi...@chromium.org, telemetr...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, blink-rev...@chromium.org, kyungjunle...@google.com, dtseng...@chromium.org, srahim...@chromium.org, blink-rev...@chromium.org, mac-r...@chromium.org, wfh+...@chromium.org, francisjp...@google.com, blink-...@chromium.org, loading...@chromium.org, nektar...@chromium.org, tburkar...@chromium.org, browser-comp...@chromium.org, yuzo+...@chromium.org, net-r...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, lucasrada...@google.com, asvitkine...@chromium.org, blink-revie...@chromium.org, oshima...@chromium.org, devtools...@chromium.org, abigailbk...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [KA] Write more suggestion render tests.

    Add tests for:
    * credit card suggestion
    * promo offer suggestion (tint doesn't work correctly right now)
    * otp suggestion
    * password history suggestion

    to cover suggestion icons.
    Bug: 454608496
    Change-Id: I9e26f8281e4e1cef5affc5a75579a274f5fd8926
    Reviewed-by: Luchen Peng <luche...@google.com>
    Commit-Queue: Timofey Chudakov <tchu...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1538598}
    Files:
    • M chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/bar_component/KeyboardAccessoryChipViewRenderTest.java
    Change size: S
    Delta: 1 file changed, 37 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Luchen Peng
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9e26f8281e4e1cef5affc5a75579a274f5fd8926
    Gerrit-Change-Number: 7079037
    Gerrit-PatchSet: 12
    Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Luchen Peng <luche...@google.com>
    Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages