[v8][api] Update users of v8::Object::CreationContext [chromium/src : main]

Camillo Bruni (Gerrit)

unread,

Nov 11, 2021, 11:24:02 AM11/11/21

to blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, chromium...@chromium.org, Ehsan Karamad, Kentaro Hara, Kevin McNee, W. James MacLean

Set Ready For Review

View Change

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Camillo Bruni (Gerrit)

unread,

Dec 9, 2021, 5:51:52 AM12/9/21

to Kentaro Hara, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org

Attention is currently required from: Kentaro Hara.

Camillo Bruni would like Kentaro Hara to review this change.

View Change

[v8][api] Update users of v8::Object::CreationContext

v8::Object::CreationContext is deprecated, replace users with one of
the two following alternatives:

- MaybeLocal<Context> v8::Object::GetCreationContext()
- Local<Context> v8::Object::GetCreationContextChecked()

Bug: v8:11165
Change-Id: I1ebfc6948dc0c1d289d31d07fca7d940b2fa9073
---
M third_party/blink/renderer/bindings/core/v8/v8_script_runner.cc
M chrome/renderer/extensions/app_hooks_delegate.cc
M third_party/blink/renderer/platform/bindings/binding_security_for_platform.h
M third_party/blink/renderer/platform/bindings/v8_set_return_value.cc
M chrome/renderer/extensions/extension_hooks_delegate.cc
M third_party/blink/renderer/bindings/core/v8/binding_security.h
M third_party/blink/renderer/platform/bindings/to_v8.h
M third_party/blink/renderer/core/execution_context/execution_context.cc
M content/services/shared_storage_worklet/shared_storage.cc
M third_party/blink/renderer/core/exported/web_array_buffer_converter.cc
M third_party/blink/renderer/platform/bindings/callback_interface_base.cc
M third_party/blink/renderer/bindings/core/v8/script_promise_property_test.cc
M third_party/blink/renderer/bindings/core/v8/world_safe_v8_reference.cc
M third_party/blink/renderer/bindings/core/v8/v8_page_popup_controller_binding.cc
M components/guest_view/renderer/guest_view_request.cc
M extensions/renderer/bindings/api_last_error.cc
M third_party/blink/renderer/bindings/core/v8/binding_security.cc
M third_party/blink/renderer/core/html/canvas/image_data.cc
M third_party/blink/renderer/modules/exported/web_dom_file_system.cc
M content/web_test/renderer/gc_controller.cc
M third_party/blink/renderer/platform/bindings/binding_security_for_platform.cc
M extensions/renderer/module_system.cc
M extensions/renderer/bindings/argument_spec_unittest.cc
M gin/arguments.cc
M third_party/blink/renderer/bindings/core/v8/to_v8_traits.h
M third_party/blink/renderer/bindings/core/v8/custom/v8_html_all_collection_custom.cc
M chromecast/renderer/extensions/extension_hooks_delegate.cc
M third_party/blink/renderer/platform/bindings/callback_function_base.cc
M third_party/blink/renderer/bindings/core/v8/generated_code_helper.cc
M extensions/renderer/script_context_set.cc
M third_party/blink/renderer/extensions/chromeos/chromeos_extensions.cc
M third_party/blink/renderer/platform/bindings/v8_set_return_value.h
M extensions/renderer/native_extension_bindings_system.cc
M extensions/renderer/native_extension_bindings_system_unittest.cc
M third_party/blink/renderer/platform/bindings/multi_worlds_v8_reference.cc
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
M third_party/blink/renderer/bindings/core/v8/world_safe_v8_reference.h
M extensions/renderer/object_backed_native_handler.cc
M components/guest_view/renderer/guest_view_container.cc
M content/renderer/v8_value_converter_impl.cc
M third_party/blink/renderer/platform/bindings/script_state.h
M extensions/renderer/runtime_hooks_delegate.cc
M third_party/blink/renderer/core/exported/web_node.cc
M third_party/blink/renderer/core/exported/web_blob.cc
M content/services/shared_storage_worklet/shared_storage_iterator.cc
M extensions/renderer/bindings/api_binding.cc
M third_party/blink/renderer/bindings/core/v8/v8_html_constructor.cc
47 files changed, 176 insertions(+), 124 deletions(-)

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Camillo Bruni (Gerrit)

unread,

Dec 9, 2021, 5:52:03 AM12/9/21

to blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kentaro Hara, Kevin McNee, James Maclean

Attention is currently required from: Kentaro Hara.

View Change

1 comment:

Patchset:
- Patch Set #4:
  PTAL

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Camillo Bruni (Gerrit)

unread,

Dec 9, 2021, 5:57:22 AM12/9/21

to Kentaro Hara, Sean Topping, Finnur Thorarinsson, Jochen Eisinger, Kentaro Hara, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org

Attention is currently required from: Sean Topping, Finnur Thorarinsson, Jochen Eisinger.

Camillo Bruni would like Kentaro Hara, Sean Topping, Finnur Thorarinsson and Jochen Eisinger to review this change.

Camillo Bruni removed Kentaro Hara and Kentaro Hara from this change.

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Camillo Bruni (Gerrit)

unread,

Dec 9, 2021, 5:57:30 AM12/9/21

to blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Finnur Thorarinsson, Jochen Eisinger, Sean Topping, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Attention is currently required from: Sean Topping, Finnur Thorarinsson, Jochen Eisinger.

View Change

1 comment:

Patchset:
- Patch Set #4:
  PTAL

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Kentaro Hara (Gerrit)

unread,

Dec 9, 2021, 5:57:52 AM12/9/21

to Camillo Bruni, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Finnur Thorarinsson, Jochen Eisinger, Sean Topping, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Attention is currently required from: Sean Topping, Camillo Bruni, Finnur Thorarinsson, Jochen Eisinger.

Patch set 4:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #4:
  LGTM

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Sean Topping (Gerrit)

unread,

Dec 9, 2021, 3:09:17 PM12/9/21

to Camillo Bruni, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Kentaro Hara, Finnur Thorarinsson, Jochen Eisinger, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Attention is currently required from: Camillo Bruni, Finnur Thorarinsson, Jochen Eisinger.

Patch set 4:Code-Review +1

View Change

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Finnur Thorarinsson (Gerrit)

unread,

Dec 10, 2021, 11:39:25 PM12/10/21

to Camillo Bruni, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Sean Topping, Kentaro Hara, Jochen Eisinger, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Attention is currently required from: Camillo Bruni, Jochen Eisinger.

View Change

1 comment:

Patchset:

Patch Set #4:

Please be explicit, when requesting reviews from multiple people, about who you want to review what.

There is a lot of overlap in ownership, but it looks to me like there's only one file I'm exclusively an owner for:
  extensions/renderer/bindings/api_binding.cc
... as you seem to have all other files covered.

Is that the file you wanted me to look at?

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Camillo Bruni (Gerrit)

unread,

Dec 11, 2021, 12:44:26 AM12/11/21

to blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Sean Topping, Kentaro Hara, Finnur Thorarinsson, Jochen Eisinger, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Attention is currently required from: Jochen Eisinger.

View Change

1 comment:

Patchset:
- Patch Set #4:
  Sorry, more explicitly:
  jochen@ PTAL shared_storage_iterator.cc and guest_view_request.cc
  finnur@ PTAL extension_hooks_delegate.cc api_binding.cc guest_view_internal_custom_bindings.cc

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Jochen Eisinger (Gerrit)

unread,

Dec 11, 2021, 5:06:30 PM12/11/21

to Camillo Bruni, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Sean Topping, Kentaro Hara, Finnur Thorarinsson, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Attention is currently required from: Camillo Bruni.

Patch set 4:Code-Review +1

View Change

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Finnur Thorarinsson (Gerrit)

unread,

Dec 14, 2021, 5:57:51 AM12/14/21

to Camillo Bruni, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Jochen Eisinger, Sean Topping, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Attention is currently required from: Camillo Bruni.

Patch set 4:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #4:
  chrome/renderer/extensions/app_hooks_delegate.cc and
  chrome/renderer/extensions/extension_hooks_delegate.cc
  LGTM

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Camillo Bruni (Gerrit)

unread,

Dec 14, 2021, 9:13:25 AM12/14/21

to blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Finnur Thorarinsson, Jochen Eisinger, Sean Topping, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Attention is currently required from: Camillo Bruni.

Patch set 4:Commit-Queue +2

View Change

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Dec 14, 2021, 10:53:42 AM12/14/21

to Camillo Bruni, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, extension...@chromium.org, halliwe...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lcwu+...@chromium.org, oshima...@chromium.org, Finnur Thorarinsson, Jochen Eisinger, Sean Topping, Kentaro Hara, chromium...@chromium.org, Ehsan Karamad, Kevin McNee, James Maclean

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Finnur Thorarinsson: Looks good to me
  Kentaro Hara: Looks good to me
  Jochen Eisinger: Looks good to me
  Sean Topping: Looks good to me
  Camillo Bruni: Commit

[v8][api] Update users of v8::Object::CreationContext

v8::Object::CreationContext is deprecated, replace users with one of
the two following alternatives:

- MaybeLocal<Context> v8::Object::GetCreationContext()
- Local<Context> v8::Object::GetCreationContextChecked()

Bug: v8:11165
Change-Id: I1ebfc6948dc0c1d289d31d07fca7d940b2fa9073

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275976
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Sean Topping <seant...@chromium.org>
Reviewed-by: Jochen Eisinger <joc...@chromium.org>
Reviewed-by: Finnur Thorarinsson <fin...@chromium.org>
Commit-Queue: Camillo Bruni <cbr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951508}

47 files changed, 183 insertions(+), 124 deletions(-)

To view, visit change 3275976. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward