Do not use v8::FastApiTypedArray [chromium/src : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Jun 25, 2024, 6:15:25 AM (4 days ago) Jun 25
to Andrey Kosyakov, Andreas Haas, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Jun 25, 2024, 11:55:28 AM (4 days ago) Jun 25
to Michael Lippautz, Andreas Haas, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org
Andrey Kosyakov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 25, 2024, 11:59:10 AM (4 days ago) Jun 25
to Andrey Kosyakov, Michael Lippautz, Andreas Haas, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Do not use v8::FastApiTypedArray
This will cause typed arrays to get passed as v8::Local<v8::Value> to generated NoAllocDirectCall callbacks, with the type checking and conversion being handled through NativeValueTraits<> the way it is for the conventional binding calls.
Bug: 346495942
Change-Id: Ia660385a305ceac6144b2f6409ec2af08e92c878
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1319181}
Files:
- M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl.h
- M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
Change size: M
Delta: 2 files changed, 9 insertions(+), 45 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages