Forward declare base::ScopedClosureRunner in some Blink headers [chromium/src : main]
0 views
Skip to first unread message
AI Code Reviewer (Gerrit)
Dec 12, 2025, 1:05:48 PM (2 days ago) Dec 12
to Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, (Julie)Jeongeun Kim, Raphael Kubo da Costa, abigailbk...@google.com, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, jbroma...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, npm+...@chromium.org, trewin...@google.com, yigu+...@chromium.org, yuzo+...@chromium.org
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/scroll/scrollable_area.h
Line 717, Patchset 1 (Latest):
bool preserve_pinned_marker);AI Code Reviewer . unresolved
Blink Style Guide: Prefer enums or StrongAliases to bare bools for function parameters. To improve type safety and readability, consider using a base::StrongAlias<class PreservePinnedMarkerTag, bool> for the 'preserve_pinned_marker' parameter instead of a bare bool.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Dec 12, 2025, 1:07:18 PM (2 days ago) Dec 12
to Lei Zhang, AI Code Reviewer, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, (Julie)Jeongeun Kim, Raphael Kubo da Costa, abigailbk...@google.com, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, jbroma...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, npm+...@chromium.org, trewin...@google.com, yigu+...@chromium.org, yuzo+...@chromium.org
Lei Zhang added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/scroll/scrollable_area.h
Line 717, Patchset 1 (Latest):
bool preserve_pinned_marker);AI Code Reviewer . resolved
Blink Style Guide: Prefer enums or StrongAliases to bare bools for function parameters. To improve type safety and readability, consider using a base::StrongAlias<class PreservePinnedMarkerTag, bool> for the 'preserve_pinned_marker' parameter instead of a bare bool.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Lei Zhang
**OK But Won't Fix**: Just removing a default argument from pre-existing code.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Flack (Gerrit)
Dec 12, 2025, 2:38:08 PM (2 days ago) Dec 12
to Lei Zhang, AI Code Reviewer, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, (Julie)Jeongeun Kim, Raphael Kubo da Costa, abigailbk...@google.com, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, jbroma...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, npm+...@chromium.org, trewin...@google.com, yigu+...@chromium.org, yuzo+...@chromium.org
Attention needed from Lei Zhang
Robert Flack voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Dec 12, 2025, 2:44:42 PM (2 days ago) Dec 12
to Lei Zhang, Philip Rogers, Robert Flack, AI Code Reviewer, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, (Julie)Jeongeun Kim, Raphael Kubo da Costa, abigailbk...@google.com, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, jbroma...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, npm+...@chromium.org, trewin...@google.com, yigu+...@chromium.org, yuzo+...@chromium.org
Attention needed from Christoph Schwering and Philip Rogers
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved
Adding more reviewers for remaining owners stamps.
Related details
Attention is currently required from:
- Christoph Schwering
- Philip Rogers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christoph Schwering (Gerrit)
Dec 12, 2025, 6:01:45 PM (2 days ago) Dec 12
to Lei Zhang, Philip Rogers, Robert Flack, AI Code Reviewer, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, (Julie)Jeongeun Kim, Raphael Kubo da Costa, abigailbk...@google.com, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, jbroma...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, npm+...@chromium.org, trewin...@google.com, yigu+...@chromium.org, yuzo+...@chromium.org
Attention needed from Lei Zhang and Philip Rogers
Christoph Schwering voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Lei Zhang
- Philip Rogers
Lei Zhang (Gerrit)
Dec 12, 2025, 6:04:17 PM (2 days ago) Dec 12
to Lei Zhang, Philip Rogers, Robert Flack, AI Code Reviewer, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, (Julie)Jeongeun Kim, Raphael Kubo da Costa, abigailbk...@google.com, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, jbroma...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, npm+...@chromium.org, trewin...@google.com, yigu+...@chromium.org, yuzo+...@chromium.org
Attention needed from Philip Rogers
Lei Zhang voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Philip Rogers
Philip Rogers (Gerrit)
Dec 12, 2025, 6:14:00 PM (2 days ago) Dec 12
to Lei Zhang, Robert Flack, AI Code Reviewer, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, (Julie)Jeongeun Kim, Raphael Kubo da Costa, abigailbk...@google.com, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, jbroma...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, npm+...@chromium.org, trewin...@google.com, yigu+...@chromium.org, yuzo+...@chromium.org
Attention needed from Lei Zhang
Philip Rogers voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Rogers
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 12, 2025, 6:16:47 PM (2 days ago) Dec 12
to Lei Zhang, Philip Rogers, Robert Flack, AI Code Reviewer, Akihiro Ota, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, (Julie)Jeongeun Kim, Raphael Kubo da Costa, abigailbk...@google.com, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, jbroma...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, npm+...@chromium.org, trewin...@google.com, yigu+...@chromium.org, yuzo+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Forward declare base::ScopedClosureRunner in some Blink headers
Avoid including base/functional/callback_helpers.h when not needed. Also
use base/functional/callback_forward.h since callback_helpers.h was
providing callback.h. For scrollable_area.h, make this possible by
getting rid the default arguments to PerformSnapping(),
SnapAtCurrentPosition(), and SnapForEndPosition(). These methods have
very few callers, so just pass in all the arguments. Then do IWYU to fix
the build.
Change-Id: I5cfd017bd6f392b0d97e99c41d4885fac7140a4c
Commit-Queue: Philip Rogers <p...@chromium.org>
Auto-Submit: Lei Zhang <the...@chromium.org>
Reviewed-by: Philip Rogers <p...@chromium.org>
Reviewed-by: Christoph Schwering <schw...@google.com>
Reviewed-by: Robert Flack <fla...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558318}
Files:
- M chrome/renderer/accessibility/read_anything/read_anything_app_controller_browsertest.cc
- M components/autofill/content/renderer/autofill_agent.h
- M third_party/blink/public/web/web_node.h
- M third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules_test.cc
- M third_party/blink/renderer/core/exported/web_node.cc
- M third_party/blink/renderer/core/exported/web_page_popup_impl.cc
- M third_party/blink/renderer/core/scroll/scrollable_area.cc
- M third_party/blink/renderer/core/scroll/scrollable_area.h
- M third_party/blink/renderer/core/web_test/web_test_web_frame_widget_impl.cc
- M third_party/blink/renderer/modules/credentialmanagement/federated_credential.cc
- M third_party/blink/renderer/platform/media/multi_buffer_data_source_unittest.cc
Change size: M
Delta: 11 files changed, 46 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Robert Flack, +1 by Philip Rogers, +1 by Christoph Schwering
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages