WTF: Update String::Substring() usages in bindings/ and core/ [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Mar 11, 2026, 4:22:34 AM (yesterday) Mar 11
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Menard, Alexis, David Bokan, srirama chandra sekhar, Kentaro Hara, AyeAye, blink-revi...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, antoniosarto...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, gl...@chromium.org, apavlo...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, mkwst+w...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, arthursonzog...@chromium.org, jshin...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, feature-me...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3aaf36086785a5e4252bf84ebf977565ca870830
Gerrit-Change-Number: 7651455
Gerrit-PatchSet: 2
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Wed, 11 Mar 2026 08:22:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Mar 11, 2026, 5:12:21 AM (yesterday) Mar 11
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Menard, Alexis, David Bokan, srirama chandra sekhar, Kentaro Hara, AyeAye, blink-revi...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, antoniosarto...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, gl...@chromium.org, apavlo...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, mkwst+w...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, arthursonzog...@chromium.org, jshin...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, feature-me...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3aaf36086785a5e4252bf84ebf977565ca870830
    Gerrit-Change-Number: 7651455
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 09:12:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 11, 2026, 5:20:08 AM (yesterday) Mar 11
    to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, Raphael Kubo da Costa, Menard, Alexis, David Bokan, srirama chandra sekhar, Kentaro Hara, AyeAye, blink-revi...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, antoniosarto...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, gl...@chromium.org, apavlo...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, mkwst+w...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, arthursonzog...@chromium.org, jshin...@chromium.org, loading-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WTF: Update String::Substring() usages in bindings/ and core/

    String::Substring() gracefully handles out-of-range start positions by
    clamping them. `substr()` and `subview()` methods do not have this
    behavior.

    This change replaces `Substring()` with `substr()` or `subview()` where
    the arguments are known to be valid.
    Bug: 473854537
    Change-Id: I3aaf36086785a5e4252bf84ebf977565ca870830
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1597599}
    Files:
    • M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
    • M third_party/blink/renderer/core/css/css_default_style_sheets.cc
    • M third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
    • M third_party/blink/renderer/core/css/style_perftest.cc
    • M third_party/blink/renderer/core/dom/character_data.cc
    • M third_party/blink/renderer/core/dom/document.cc
    • M third_party/blink/renderer/core/dom/processing_instruction.cc
    • M third_party/blink/renderer/core/dom/text.cc
    • M third_party/blink/renderer/core/dom/tree_scope.cc
    • M third_party/blink/renderer/core/editing/commands/editor_command.cc
    • M third_party/blink/renderer/core/editing/commands/typing_command.cc
    • M third_party/blink/renderer/core/editing/ime/edit_context.cc
    • M third_party/blink/renderer/core/editing/iterators/text_searcher_icu_test.cc
    • M third_party/blink/renderer/core/editing/testing/selection_sample.cc
    • M third_party/blink/renderer/core/editing/text_offset_mapping_test.cc
    • M third_party/blink/renderer/core/exported/web_element_test.cc
    • M third_party/blink/renderer/core/exported/web_frame_serializer_test.cc
    • M third_party/blink/renderer/core/frame/csp/csp_directive_list.cc
    • M third_party/blink/renderer/core/frame/frame_serializer.cc
    • M third_party/blink/renderer/core/frame/location.cc
    • M third_party/blink/renderer/core/frame/mhtml_archive_test.cc
    • M third_party/blink/renderer/core/frame/navigator_id.cc
    • M third_party/blink/renderer/core/html/fenced_frame/fenced_frame_config.cc
    • M third_party/blink/renderer/core/html/forms/email_input_type.cc
    • M third_party/blink/renderer/core/html/forms/number_input_type.cc
    • M third_party/blink/renderer/core/html/forms/text_control_element.cc
    • M third_party/blink/renderer/core/html/forms/type_ahead.cc
    • M third_party/blink/renderer/core/html/html_element.cc
    • M third_party/blink/renderer/core/html/html_map_element.cc
    • M third_party/blink/renderer/core/html/media/html_media_element.cc
    • M third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
    • M third_party/blink/renderer/core/html/parser/html_parser_idioms.cc
    • M third_party/blink/renderer/core/html/track/vtt/buffered_line_reader_test.cc
    • M third_party/blink/renderer/core/inspector/inspector_css_parser_observer.cc
    • M third_party/blink/renderer/core/inspector/inspector_css_parser_observer_test.cc
    • M third_party/blink/renderer/core/inspector/inspector_session_state.h
    • M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
    • M third_party/blink/renderer/core/layout/inline/inline_node.cc
    • M third_party/blink/renderer/core/layout/inline/justification_utils.cc
    • M third_party/blink/renderer/core/layout/layout_text_test.cc
    • M third_party/blink/renderer/core/page/chrome_client_impl.cc
    • M third_party/blink/renderer/core/page/scrolling/element_fragment_anchor.cc
    • M third_party/blink/renderer/core/script/document_modulator_impl.cc
    • M third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
    • M third_party/blink/renderer/core/url/dom_url.cc
    • M third_party/blink/renderer/core/url/dom_url_utils.cc
    • M third_party/blink/renderer/core/url/url_search_params.cc
    • M third_party/blink/renderer/core/url_pattern/url_pattern_canon.cc
    • M third_party/blink/renderer/core/url_pattern/url_pattern_dummy_url_canon.cc
    • M third_party/blink/renderer/core/xml/xpath_functions.cc
    • M third_party/blink/renderer/core/xml/xpath_parser.cc
    • M third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
    Change size: M
    Delta: 53 files changed, 107 insertions(+), 111 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3aaf36086785a5e4252bf84ebf977565ca870830
    Gerrit-Change-Number: 7651455
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages