[Fuzzing] Fix Android dependencies in Blink fuzzers [chromium/src : main]
Titouan Rigoudy (Gerrit)
Titouan Rigoudy added 3 comments![]( "Open in Gerrit")
"//base/test:icu_fuzzer_environment_maybe_java",Here we can directly depend on the source set since we never need the assets, which are handled below.
This makes me realize that with the current setup in crrev.com/c/7831500, we can't express this dependency correctly. I'll comment there.
visibility = [] # Allow re-assignment of list.I don't understand this. Can you elaborate?
"//third_party/icu:icu_assets",There should be a separate comment for the ICU dependency, it's unrelated to the V8 snapshot.
Related details
- Edgar Aguilar
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Edgar Aguilar (Gerrit)
Edgar Aguilar added 3 comments![]( "Open in Gerrit")
Here we can directly depend on the source set since we never need the assets, which are handled below.
This makes me realize that with the current setup in crrev.com/c/7831500, we can't express this dependency correctly. I'll comment there.
Done
visibility = [] # Allow re-assignment of list.I don't understand this. Can you elaborate?
I just copied the comment from the existing `source_set` above.
If this is not added autoninja shows this error
```
ERROR at //third_party/blink/renderer/platform/BUILD.gn:2718:3: Replacing nonempty list.
visibility = [ "*" ]
^---------
This overwrites a previously-defined nonempty list with another nonempty list.
```
I thought this might be a known behavior so didn't extend the comment. Should I be more verbose?
There should be a separate comment for the ICU dependency, it's unrelated to the V8 snapshot.
- Titouan Rigoudy
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |