Remove cookie deprecation label code [chromium/src : main]

[Avi Drissman (Gerrit)]

Attention needed from Joshua Hood, Kent Tamura, Kevin Graney and Russ Hamilton

Avi Drissman voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Joshua Hood
• Kent Tamura
• Kevin Graney
• Russ Hamilton

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I04ab2c2973befcfcf669550c87269f49023ea80b

Gerrit-Change-Number: 7155846

Gerrit-PatchSet: 6

Gerrit-Owner: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Joshua Hood <j...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Russ Hamilton <beham...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Brian Lefler <b...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fiona Macintosh <fmaci...@google.com>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Russ Hamilton <beham...@google.com>

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 18 Nov 2025 15:27:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Avi Drissman (Gerrit)]

Attention needed from Joshua Hood, Kent Tamura, Kevin Graney and Russ Hamilton

Avi Drissman voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Joshua Hood
• Kent Tamura
• Kevin Graney
• Russ Hamilton

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I04ab2c2973befcfcf669550c87269f49023ea80b

Gerrit-Change-Number: 7155846

Gerrit-PatchSet: 7

Gerrit-Owner: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Joshua Hood <j...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Russ Hamilton <beham...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Brian Lefler <b...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fiona Macintosh <fmaci...@google.com>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Russ Hamilton <beham...@google.com>

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 18 Nov 2025 23:24:33 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Kevin Graney (Gerrit)]

Attention needed from Joshua Hood, Kent Tamura, Nan Lin and Russ Hamilton

Kevin Graney added 1 comment

Patchset-level comments

File-level comment, Patchset 4:

Nan Lin . resolved

Can we also remove the following directory/files?

//third_party/blink/renderer/modules/cookie_deprecation_label

The cookie deprecation label in //services/network and //net, e.g.
https://source.chromium.org/chromium/chromium/src/+/main:services/network/public/mojom/network_context.mojom;l=602

https://source.chromium.org/chromium/chromium/src/+/main:net/url_request/url_request_context_builder.h;l=485

Nan Lin

CLs that added these changes for reference:
https://chromium-review.googlesource.com/c/chromium/src/+/4997315
https://chromium-review.googlesource.com/c/chromium/src/+/4812461

Kevin Graney

Done (side note: wow, those builder for updating web_tests expected files take forever!)

Open in Gerrit

Related details

Attention is currently required from:

• Joshua Hood
• Kent Tamura
• Nan Lin
• Russ Hamilton

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 18 Nov 2025 23:58:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Nan Lin <lin...@chromium.org>

[Kent Tamura (Gerrit)]

Attention needed from Joshua Hood, Kevin Graney, Nan Lin and Russ Hamilton

Kent Tamura voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Joshua Hood
• Kevin Graney
• Nan Lin
• Russ Hamilton

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Comment-Date: Tue, 18 Nov 2025 23:59:57 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Nan Lin (Gerrit)]

Attention needed from Joshua Hood, Kevin Graney and Russ Hamilton

Nan Lin voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Joshua Hood
• Kevin Graney
• Russ Hamilton

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 00:25:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[gwsq (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi, Joshua Hood, Russ Hamilton and mmenke

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): ort...@chromium.org

Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi
• Joshua Hood
• Russ Hamilton
• mmenke

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I04ab2c2973befcfcf669550c87269f49023ea80b

Gerrit-Change-Number: 7155846

Gerrit-PatchSet: 7

Gerrit-Owner: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Joshua Hood <j...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Russ Hamilton <beham...@google.com>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Brian Lefler <b...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fiona Macintosh <fmaci...@google.com>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: mmenke <mme...@chromium.org>

Gerrit-Attention: Russ Hamilton <beham...@google.com>

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 01:01:35 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Joshua Hood (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi, Kevin Graney, Russ Hamilton and mmenke

Joshua Hood voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi
• Kevin Graney
• Russ Hamilton
• mmenke

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 14:26:39 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Russ Hamilton (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi, Kevin Graney and mmenke

Russ Hamilton voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi
• Kevin Graney

• mmenke

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 15:14:13 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Kevin Graney and mmenke

Giovanni Ortuno Urquidi voted and added 1 comment

Votes added by Giovanni Ortuno Urquidi

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Giovanni Ortuno Urquidi . resolved

mojo lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Kevin Graney
• mmenke

Gerrit-Comment-Date: Wed, 19 Nov 2025 15:25:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[mmenke (Gerrit)]

Attention needed from Kevin Graney

mmenke added 3 comments

Commit Message

Line 11, Patchset 8 (Latest):- Disabled in binary by default in M143
- Code removal in M144 (next branch)

mmenke . unresolved

Was there an intent for this / is there a feature in chrome status we can link to?

Line 14, Patchset 8 (Latest):Bug: 447619585

mmenke . unresolved

This is a public, web-exposed feature. Seems like there should be a public bug for this work.

File net/url_request/url_request_context_builder.cc

Line 627, Patchset 8 (Parent): context->set_cookie_deprecation_label(*cookie_deprecation_label_);

mmenke . unresolved

This CL does not remove URLRequestContext::cookie_deprecation_label(). Is that deliberate? The CL description doesn't mention it at all.

Open in Gerrit

Related details

Attention is currently required from:

• Kevin Graney

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I04ab2c2973befcfcf669550c87269f49023ea80b

Gerrit-Change-Number: 7155846

Gerrit-PatchSet: 8

Gerrit-Owner: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Joshua Hood <j...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Russ Hamilton <beham...@google.com>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Brian Lefler <b...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fiona Macintosh <fmaci...@google.com>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Comment-Date: Wed, 19 Nov 2025 16:10:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Kevin Graney (Gerrit)]

Attention needed from mmenke

Kevin Graney added 3 comments

Commit Message

Line 11, Patchset 8 (Latest):- Disabled in binary by default in M143
- Code removal in M144 (next branch)

mmenke . resolved

Was there an intent for this / is there a feature in chrome status we can link to?

Kevin Graney

https://chromestatus.com/feature/5189079788683264

More context in these threads:
https://groups.google.com/a/chromium.org/g/blink-dev/c/WnIy9TTDXpk/m/66Xio4YGDAAJ
https://groups.google.com/a/chromium.org/g/blink-dev/c/63u-0KmBG4w/m/nhIsSbLfAwAJ

Line 14, Patchset 8 (Latest):Bug: 447619585

mmenke . resolved

This is a public, web-exposed feature. Seems like there should be a public bug for this work.

Kevin Graney

The bug has a combination of Finch and public CLs on it. Is it typical to include Finch CLs on public bugs?

File net/url_request/url_request_context_builder.cc

Line 627, Patchset 8 (Parent): context->set_cookie_deprecation_label(*cookie_deprecation_label_);

mmenke . unresolved

This CL does not remove URLRequestContext::cookie_deprecation_label(). Is that deliberate? The CL description doesn't mention it at all.

Kevin Graney

No, that was an oversight, thanks. Do you mind if I remove that code as a follow-up? (This CL is becoming quite large and unwieldy.)

Open in Gerrit

Related details

Attention is currently required from:

• mmenke

Gerrit-Attention: mmenke <mme...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 16:31:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: mmenke <mme...@chromium.org>

[Kevin Graney (Gerrit)]

Attention needed from Avi Drissman, Giovanni Ortuno Urquidi, Joshua Hood, Kent Tamura, Nan Lin, Russ Hamilton and mmenke

Kevin Graney voted and added 2 comments

Votes added by Kevin Graney

Commit-Queue

+2

2 comments

Commit Message

Line 11, Patchset 8:- Disabled in binary by default in M143


- Code removal in M144 (next branch)

mmenke . resolved

Was there an intent for this / is there a feature in chrome status we can link to?

Kevin Graney

https://chromestatus.com/feature/5189079788683264

More context in these threads:
https://groups.google.com/a/chromium.org/g/blink-dev/c/WnIy9TTDXpk/m/66Xio4YGDAAJ
https://groups.google.com/a/chromium.org/g/blink-dev/c/63u-0KmBG4w/m/nhIsSbLfAwAJ

mmenke

Thanks! Guess this was always considered an experiment and nor a shipped feature. Could you mention that in the CL description?

Kevin Graney

Done

File net/url_request/url_request_context_builder.cc

Line 627, Patchset 8 (Parent): context->set_cookie_deprecation_label(*cookie_deprecation_label_);

mmenke . resolved

This CL does not remove URLRequestContext::cookie_deprecation_label(). Is that deliberate? The CL description doesn't mention it at all.

Kevin Graney

No, that was an oversight, thanks. Do you mind if I remove that code as a follow-up? (This CL is becoming quite large and unwieldy.)

mmenke

I'd be fine with that, but looks like you already expanded the CL to remove that code?

Kevin Graney

Whoops! I meant to push that to a chained review, not sure what `git cl upload` did there. Reverted to the previous patchset and will do the other removals in a follow-up.

Open in Gerrit

Related details

Attention is currently required from:

• Avi Drissman

• Giovanni Ortuno Urquidi
• Joshua Hood

• Kent Tamura
• Nan Lin
• Russ Hamilton

• mmenke

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I04ab2c2973befcfcf669550c87269f49023ea80b

Gerrit-Change-Number: 7155846

Gerrit-PatchSet: 11

Gerrit-Owner: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Joshua Hood <j...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Russ Hamilton <beham...@google.com>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Brian Lefler <b...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fiona Macintosh <fmaci...@google.com>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: mmenke <mme...@chromium.org>

Gerrit-Attention: Russ Hamilton <beham...@google.com>

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Attention: Avi Drissman <a...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 17:11:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: mmenke <mme...@chromium.org>

Comment-In-Reply-To: Kevin Graney <k...@google.com>

[mmenke (Gerrit)]

Attention needed from Avi Drissman, Giovanni Ortuno Urquidi, Joshua Hood, Kent Tamura, Kevin Graney, Nan Lin and Russ Hamilton

mmenke voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Avi Drissman
• Giovanni Ortuno Urquidi
• Joshua Hood
• Kent Tamura

• Kevin Graney
• Nan Lin
• Russ Hamilton

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Attention: Russ Hamilton <beham...@google.com>

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Attention: Avi Drissman <a...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 17:15:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Kevin Graney (Gerrit)]

Attention needed from Avi Drissman, Giovanni Ortuno Urquidi, Joshua Hood, Kent Tamura, Nan Lin and Russ Hamilton

Kevin Graney voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Avi Drissman
• Giovanni Ortuno Urquidi
• Joshua Hood
• Kent Tamura

• Nan Lin
• Russ Hamilton

Gerrit-Attention: Joshua Hood <j...@chromium.org>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Attention: Avi Drissman <a...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 17:16:30 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Joshua Hood (Gerrit)]

Attention needed from Avi Drissman, Giovanni Ortuno Urquidi, Kent Tamura, Kevin Graney, Nan Lin and Russ Hamilton

Joshua Hood voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Avi Drissman
• Giovanni Ortuno Urquidi

• Kent Tamura
• Kevin Graney
• Nan Lin
• Russ Hamilton

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Attention: Avi Drissman <a...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 17:16:36 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Blink W3C Test Autoroller (Gerrit)]

Attention needed from Avi Drissman, Giovanni Ortuno Urquidi, Kent Tamura, Kevin Graney, Nan Lin and Russ Hamilton

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/56120.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Brian Lefler <b...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fiona Macintosh <fmaci...@google.com>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Russ Hamilton <beham...@google.com>

Gerrit-Attention: Kevin Graney <k...@google.com>

Gerrit-Attention: Nan Lin <lin...@chromium.org>

Gerrit-Attention: Avi Drissman <a...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 17:31:49 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove cookie deprecation label code

Traffic labels:
- Disabled via Finch in M142

- Disabled in binary by default in M143
- Code removal in M144 (next branch)

See https://chromestatus.com/feature/5189079788683264.

Some additional context is in these threads:
https://groups.google.com/a/chromium.org/g/blink-dev/c/WnIy9TTDXpk/m/66Xio4YGDAAJ
https://groups.google.com/a/chromium.org/g/blink-dev/c/63u-0KmBG4w/m/nhIsSbLfAwAJ

Bug: 447619585

Change-Id: I04ab2c2973befcfcf669550c87269f49023ea80b

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7155846

Reviewed-by: mmenke <mme...@chromium.org>

Reviewed-by: Joshua Hood <j...@chromium.org>

Commit-Queue: Kevin Graney <k...@google.com>

Cr-Commit-Position: refs/heads/main@{#1547313}

Files:

• M chrome/browser/tpcd/experiment/eligibility_service.cc
• M chrome/browser/tpcd/experiment/eligibility_service.h
• D chrome/browser/tpcd/experiment/eligibility_service_browsertest.cc
• M chrome/test/BUILD.gn
• M content/browser/BUILD.gn
• D content/browser/cookie_deprecation_label/cookie_deprecation_label_browsertest.cc
• D content/browser/cookie_deprecation_label/cookie_deprecation_label_manager_impl.cc
• D content/browser/cookie_deprecation_label/cookie_deprecation_label_manager_impl.h
• D content/browser/cookie_deprecation_label/cookie_deprecation_label_manager_impl_unittest.cc
• D content/browser/cookie_deprecation_label/cookie_deprecation_label_test_utils.h
• M content/browser/interest_group/ad_auction_service_impl.cc
• M content/browser/interest_group/ad_auction_service_impl.h
• M content/browser/interest_group/ad_auction_service_impl_unittest.cc
• M content/browser/interest_group/auction_runner_unittest.cc
• M content/browser/interest_group/auction_url_loader_factory_proxy.cc
• M content/browser/interest_group/auction_url_loader_factory_proxy.h
• M content/browser/interest_group/auction_url_loader_factory_proxy_unittest.cc
• M content/browser/interest_group/auction_worklet_manager.cc
• M content/browser/interest_group/auction_worklet_manager.h
• M content/browser/interest_group/auction_worklet_manager_unittest.cc
• M content/browser/interest_group/interest_group_auction_reporter_unittest.cc
• M content/browser/renderer_host/navigation_controller_impl.cc
• M content/browser/renderer_host/navigation_entry_impl.cc
• M content/browser/renderer_host/navigation_request.cc
• M content/browser/renderer_host/render_frame_host_impl.cc
• M content/browser/storage_partition_impl.cc
• M content/browser/storage_partition_impl.h
• M content/public/browser/BUILD.gn
• D content/public/browser/cookie_deprecation_label_manager.h
• M content/public/browser/storage_partition.h
• M content/public/common/content_features.cc
• M content/public/common/content_features.h
• M content/public/test/test_storage_partition.cc
• M content/public/test/test_storage_partition.h
• M content/renderer/render_frame_impl.cc
• M content/test/BUILD.gn
• M net/url_request/url_request_context_builder.cc
• M net/url_request/url_request_context_builder.h
• M services/network/network_context.cc
• M services/network/network_context.h
• M services/network/public/mojom/network_context.mojom
• M services/network/test/test_network_context.h
• M third_party/blink/public/mojom/navigation/navigation_params.mojom
• M third_party/blink/public/web/web_navigation_params.h
• M third_party/blink/renderer/bindings/generated_in_modules.gni
• M third_party/blink/renderer/bindings/idl_in_modules.gni
• M third_party/blink/renderer/core/loader/document_loader.cc
• M third_party/blink/renderer/core/loader/document_loader.h
• M third_party/blink/renderer/modules/BUILD.gn
• D third_party/blink/renderer/modules/cookie_deprecation_label/BUILD.gn
• D third_party/blink/renderer/modules/cookie_deprecation_label/OWNERS
• D third_party/blink/renderer/modules/cookie_deprecation_label/cookie_deprecation_label.cc
• D third_party/blink/renderer/modules/cookie_deprecation_label/cookie_deprecation_label.h
• D third_party/blink/renderer/modules/cookie_deprecation_label/cookie_deprecation_label.idl
• D third_party/blink/renderer/modules/cookie_deprecation_label/navigator_cookie_deprecation_label.idl
• M third_party/blink/web_tests/VirtualTestSuites
• D third_party/blink/web_tests/external/wpt/cookie-deprecation-label/cookie-deprecation-label-detached-iframe.https.html
• D third_party/blink/web_tests/external/wpt/cookie-deprecation-label/cookie-deprecation-label-insecure-context.http.html
• D third_party/blink/web_tests/external/wpt/cookie-deprecation-label/cookie-deprecation-label.https.html
• D third_party/blink/web_tests/external/wpt/cookie-deprecation-label/dummy.html
• D third_party/blink/web_tests/virtual/cookie-deprecation-label/DIR_METADATA
• D third_party/blink/web_tests/virtual/cookie-deprecation-label/README.md
• M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Change size: XL

Delta: 63 files changed, 0 insertions(+), 1637 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by mmenke, +1 by Joshua Hood

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I04ab2c2973befcfcf669550c87269f49023ea80b

Gerrit-Change-Number: 7155846

Gerrit-PatchSet: 12

Gerrit-Owner: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Joshua Hood <j...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kevin Graney <k...@google.com>

Gerrit-Reviewer: Nan Lin <lin...@chromium.org>

Gerrit-Reviewer: Russ Hamilton <beham...@google.com>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Brian Lefler <b...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

[Blink W3C Test Autoroller (Gerrit)]

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56120

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Comment-Date: Wed, 19 Nov 2025 19:07:03 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No