[evp] Remove the EmailVerificationEvent class [chromium/src : main]

0 views
Skip to first unread message

Christian Biesinger (Gerrit)

unread,
May 5, 2026, 1:55:38 PM (14 days ago) May 5
to Sam Goto, Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, jmedle...@chromium.org
Attention needed from Sam Goto

Christian Biesinger voted and added 1 comment

Votes added by Christian Biesinger

Code-Review+1

1 comment

File components/autofill/content/browser/email_verifier_delegate.h
Line 41, Patchset 2 (Latest):
Christian Biesinger . unresolved

why this change?

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Goto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifb087d1fb779040338bd333dd0f7c49e05055601
Gerrit-Change-Number: 7814355
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Goto <go...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Sam Goto <go...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Sam Goto <go...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 17:55:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sam Goto (Gerrit)

unread,
May 7, 2026, 7:09:50 PM (11 days ago) May 7
to Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, jmedle...@chromium.org
Attention needed from Christian Biesinger

Sam Goto added 1 comment

File components/autofill/content/browser/email_verifier_delegate.h
Line 41, Patchset 2:
Christian Biesinger . resolved

why this change?

Sam Goto

Unnecessary, removed.

Open in Gerrit

Related details

Attention is currently required from:
  • Christian Biesinger
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifb087d1fb779040338bd333dd0f7c49e05055601
Gerrit-Change-Number: 7814355
Gerrit-PatchSet: 3
Gerrit-Owner: Sam Goto <go...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Sam Goto <go...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 23:09:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Biesinger <cbies...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Christian Biesinger (Gerrit)

unread,
May 12, 2026, 1:08:19 PM (7 days ago) May 12
to Sam Goto, Christian Biesinger, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, jmedle...@chromium.org
Attention needed from Sam Goto

Christian Biesinger voted and added 1 comment

Votes added by Christian Biesinger

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Christian Biesinger . resolved

lgtm, sorry, didn't realize this was waiting on me

also do you have a bug number you can mention?

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Goto
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifb087d1fb779040338bd333dd0f7c49e05055601
    Gerrit-Change-Number: 7814355
    Gerrit-PatchSet: 3
    Gerrit-Owner: Sam Goto <go...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Sam Goto <go...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Sam Goto <go...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 May 2026 17:08:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Sam Goto (Gerrit)

    unread,
    May 12, 2026, 8:47:26 PM (6 days ago) May 12
    to Christian Biesinger, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, jmedle...@chromium.org

    Sam Goto voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifb087d1fb779040338bd333dd0f7c49e05055601
    Gerrit-Change-Number: 7814355
    Gerrit-PatchSet: 4
    Gerrit-Owner: Sam Goto <go...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Sam Goto <go...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Wed, 13 May 2026 00:47:16 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 12, 2026, 10:20:16 PM (6 days ago) May 12
    to Sam Goto, Christian Biesinger, Code Review Nudger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, jmedle...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [evp] Remove the EmailVerificationEvent class
    Change-Id: Ifb087d1fb779040338bd333dd0f7c49e05055601
    Commit-Queue: Sam Goto <go...@chromium.org>
    Reviewed-by: Christian Biesinger <cbies...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1629716}
    Files:
    • M third_party/blink/renderer/bindings/generated_in_core.gni
    • M third_party/blink/renderer/bindings/idl_in_core.gni
    • M third_party/blink/renderer/core/events/build.gni
    • D third_party/blink/renderer/core/events/email_verified_event.cc
    • D third_party/blink/renderer/core/events/email_verified_event.h
    • D third_party/blink/renderer/core/events/email_verified_event.idl
    • D third_party/blink/renderer/core/events/email_verified_event_init.idl
    • M third_party/blink/renderer/core/exported/web_form_control_element.cc
    • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
    Change size: M
    Delta: 9 files changed, 0 insertions(+), 104 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Christian Biesinger
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifb087d1fb779040338bd333dd0f7c49e05055601
    Gerrit-Change-Number: 7814355
    Gerrit-PatchSet: 5
    Gerrit-Owner: Sam Goto <go...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Sam Goto <go...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages