IWYU: css_style_sheet.h [chromium/src : main]

[Matt Jolly (Gerrit)]

Attention needed from David Sanders and Philip Rogers

Matt Jolly added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Matt Jolly . resolved

Hi,

I encountered issues downstream in M141 after recent forward decl changes (suspect https://chromium-review.googlesource.com/c/chromium/src/+/6886677 but never bisected). We've had to add these includes to get a successful Chromium build in M141 and M142. Open to other solutions than just "give the compiler what it's asking for" if you have suggestions.

Please submit if approved - I'm not a committer.

Open in Gerrit

Related details

Attention is currently required from:

• David Sanders
• Philip Rogers

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibeca2830484b16915444dac8df5730cdceaa0a8d

Gerrit-Change-Number: 6965747

Gerrit-PatchSet: 1

Gerrit-Owner: Matt Jolly <kan...@gentoo.org>

Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>

Gerrit-Reviewer: Philip Rogers <p...@chromium.org>

Gerrit-CC: Alexis Menard <alexis...@intel.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Philip Rogers <p...@chromium.org>

Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>

Gerrit-Comment-Date: Sun, 21 Sep 2025 00:02:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[David Sanders (Gerrit)]

Attention needed from Matt Jolly and Philip Rogers

David Sanders added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

David Sanders . resolved

Could you check if https://chromium-review.googlesource.com/c/chromium/src/+/6965399 alternatively fixes the issue for you, if you haven't already?

That ended up being the fix for a very similar issue reported in https://chromium-review.googlesource.com/c/chromium/src/+/6955056, so I think it might also fix the build error you're seeing. I don't think the change in this CL, of adding `css_style_sheet.h` to all observable arrays in `observerable_array.py` would be correct since most shouldn't need it.

Open in Gerrit

Related details

Attention is currently required from:

• Matt Jolly
• Philip Rogers

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibeca2830484b16915444dac8df5730cdceaa0a8d

Gerrit-Change-Number: 6965747

Gerrit-PatchSet: 1

Gerrit-Owner: Matt Jolly <kan...@gentoo.org>

Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>

Gerrit-Reviewer: Philip Rogers <p...@chromium.org>

Gerrit-CC: Alexis Menard <alexis...@intel.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Matt Jolly <kan...@gentoo.org>

Gerrit-Attention: Philip Rogers <p...@chromium.org>

Gerrit-Comment-Date: Sun, 21 Sep 2025 05:54:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Matt Jolly (Gerrit)]

Attention needed from David Sanders and Philip Rogers

Matt Jolly added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

David Sanders . resolved

Could you check if https://chromium-review.googlesource.com/c/chromium/src/+/6965399 alternatively fixes the issue for you, if you haven't already?

That ended up being the fix for a very similar issue reported in https://chromium-review.googlesource.com/c/chromium/src/+/6955056, so I think it might also fix the build error you're seeing. I don't think the change in this CL, of adding `css_style_sheet.h` to all observable arrays in `observerable_array.py` would be correct since most shouldn't need it.

Matt Jolly

That fix seems to do the job. Looks like Lauren hit the same issue! I'll confirm later this week that we don't see any issues an dabandor t

Open in Gerrit

Related details

Attention is currently required from:

• David Sanders
• Philip Rogers

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibeca2830484b16915444dac8df5730cdceaa0a8d

Gerrit-Change-Number: 6965747

Gerrit-PatchSet: 1

Gerrit-Owner: Matt Jolly <kan...@gentoo.org>

Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>

Gerrit-Reviewer: Philip Rogers <p...@chromium.org>

Gerrit-CC: Alexis Menard <alexis...@intel.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Philip Rogers <p...@chromium.org>

Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>

Gerrit-Comment-Date: Sun, 21 Sep 2025 23:13:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: David Sanders <dsand...@ucsbalum.com>

[Matt Jolly (Gerrit)]

Matt Jolly abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon