Forward declare base::OnceCallback in callback_function_base.h [chromium/src : main]
0 views
Skip to first unread message
Nate Chapin (Gerrit)
Nov 17, 2025, 5:11:36 PM (5 days ago) Nov 17
to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Lei Zhang
Nate Chapin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Nov 17, 2025, 5:26:19 PM (5 days ago) Nov 17
to Lei Zhang, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 17, 2025, 5:29:32 PM (5 days ago) Nov 17
to Lei Zhang, Nate Chapin, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Forward declare base::OnceCallback in callback_function_base.h
In Blink's renderer/platform/bindings/callback_function_base.h, switch
from base/functional/callback.h to callback_forward.h. This helps avoid
transitively including callback.h in 2000+ translation units. Most of
the TUs are generated Blink files for classes in the
CallbackFunctionBase hierarchy that do not involve base::OnceCallback.
Change-Id: I997de0bc7ad676697f54789cd2ef624242590933
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1546159}
Files:
- M third_party/blink/renderer/platform/bindings/callback_function_base.cc
- M third_party/blink/renderer/platform/bindings/callback_function_base.h
Change size: XS
Delta: 2 files changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages