[BRP] Rewrite WrapperTypeInfo::parent_class to raw_ptr<> [chromium/src : main]
39 views
Skip to first unread message
Bartek Nowierski (Gerrit)
Jun 20, 2024, 1:00:24 PM (9 days ago) Jun 20
to Kentaro Hara, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kentaro Hara
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Jun 20, 2024, 1:08:34 PM (9 days ago) Jun 20
to Bartek Nowierski, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski
Kentaro Hara voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Bartek Nowierski
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 20, 2024, 1:18:50 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Kentaro Hara
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12a26340c10000
Related details
Attention is currently required from:
- Bartek Nowierski
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 20, 2024, 1:21:29 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Kentaro Hara
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17ba2864c10000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 20, 2024, 1:21:35 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Kentaro Hara
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12b7518cc10000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 20, 2024, 1:22:31 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Kentaro Hara
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/128e7a63410000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 20, 2024, 2:38:34 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Kentaro Hara
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17c45a70c10000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 20, 2024, 2:38:48 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Kentaro Hara
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/144803db410000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 20, 2024, 2:47:19 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Kentaro Hara
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15f0fcc7410000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 20, 2024, 2:49:43 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Kentaro Hara
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11a8ebeb410000
Bartek Nowierski (Gerrit)
Jun 20, 2024, 9:12:41 PM (9 days ago) Jun 20
to chrom...@appspot.gserviceaccount.com, Kentaro Hara, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kentaro Hara
Bartek Nowierski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Bartek Nowierski
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Bartek Nowierski . resolved
Sorry, added a file, need re-LGTM
Related details
Attention is currently required from:
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Jun 20, 2024, 9:14:42 PM (9 days ago) Jun 20
to Bartek Nowierski, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski
Kentaro Hara voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kentaro Hara
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Kentaro Hara . resolved
LGTM
Attention is currently required from:
- Bartek Nowierski
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 20, 2024, 9:52:55 PM (9 days ago) Jun 20
to Bartek Nowierski, Kentaro Hara, chrom...@appspot.gserviceaccount.com, Keishi Hattori, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[BRP] Rewrite WrapperTypeInfo::parent_class to raw_ptr<>
There appears to be no regression on Speedometer and MotionMark:
https://pinpoint-dot-chromeperf.appspot.com/job/15f0fcc7410000
https://pinpoint-dot-chromeperf.appspot.com/job/17c45a70c10000
https://pinpoint-dot-chromeperf.appspot.com/job/11a8ebeb410000
https://pinpoint-dot-chromeperf.appspot.com/job/144803db410000
Change-Id: I883e3cf6a123ef72acb4488a8316e55214eabbb3
Commit-Queue: Kentaro Hara <har...@chromium.org>
Auto-Submit: Bartek Nowierski <bar...@chromium.org>
Commit-Queue: Bartek Nowierski <bar...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1317745}
Files:
- M third_party/blink/renderer/platform/bindings/v8_per_context_data.cc
- M third_party/blink/renderer/platform/bindings/wrapper_type_info.h
Change size: XS
Delta: 2 files changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kentaro Hara
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages