Apply blink::StrCat to renderer/bindings/ [chromium/src : main]

46 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Oct 24, 2025, 3:54:52 AM (9 days ago) Oct 24
to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, extension...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, jbroma...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iecb86d5c3226a40ad4c91bde3be9462f3566b4e5
Gerrit-Change-Number: 7081590
Gerrit-PatchSet: 1
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Fri, 24 Oct 2025 07:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Oct 24, 2025, 5:16:56 AM (9 days ago) Oct 24
to Kent Tamura, chromium...@chromium.org, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, extension...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, jbroma...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iecb86d5c3226a40ad4c91bde3be9462f3566b4e5
    Gerrit-Change-Number: 7081590
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Fri, 24 Oct 2025 09:16:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 24, 2025, 5:20:39 AM (9 days ago) Oct 24
    to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, Raphael Kubo da Costa, Kentaro Hara, AyeAye, blink-revie...@chromium.org, extension...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, jbroma...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Apply blink::StrCat to renderer/bindings/

    to improve performance and binary size.
    This CL has no behavior changes.
    Bug: 419595599
    Change-Id: Iecb86d5c3226a40ad4c91bde3be9462f3566b4e5
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1534867}
    Files:
    • M third_party/blink/renderer/bindings/core/v8/generated_code_helper.cc
    • M third_party/blink/renderer/bindings/core/v8/serialization/post_message_helper.cc
    • M third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
    • M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer.cc
    • M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
    • M third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
    Change size: M
    Delta: 6 files changed, 35 insertions(+), 30 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iecb86d5c3226a40ad4c91bde3be9462f3566b4e5
    Gerrit-Change-Number: 7081590
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages