Introduce GlobalEventHandlers partial mixin for onbeforexrselect [chromium/src : main]
6 views
Skip to first unread message
Suyeon Ji (Gerrit)
Nov 8, 2025, 11:41:14 PM (14 days ago) Nov 8
to Alexander Cooper, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Attention needed from Alexander Cooper and Kentaro Hara
Suyeon Ji added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Alexander Cooper
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Nov 9, 2025, 12:20:01 AM (14 days ago) Nov 9
to Suyeon Ji, Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Attention needed from Alexander Cooper and Suyeon Ji
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Cooper
- Suyeon Ji
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Nov 10, 2025, 12:11:47 PM (12 days ago) Nov 10
to Suyeon Ji, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji
Alexander Cooper voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Suyeon Ji
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Suyeon Ji (Gerrit)
Nov 10, 2025, 10:27:54 PM (12 days ago) Nov 10
to Alexander Cooper, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Suyeon Ji voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Suyeon Ji (Gerrit)
Nov 12, 2025, 10:35:29 AM (10 days ago) Nov 12
to Alexander Cooper, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Attention needed from Alexander Cooper and Kentaro Hara
Suyeon Ji added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Suyeon Ji . resolved
Hi, thanks for your previous votes.
A conflict happened when I tried to merge, so I rebased it.
Could you please vote again?
Related details
Attention is currently required from:
- Alexander Cooper
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Nov 12, 2025, 3:33:25 PM (10 days ago) Nov 12
to Suyeon Ji, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Attention needed from Kentaro Hara and Suyeon Ji
Alexander Cooper voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kentaro Hara
- Suyeon Ji
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Suyeon Ji (Gerrit)
Nov 18, 2025, 9:11:07 AM (4 days ago) Nov 18
to Alexander Cooper, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Attention needed from Kentaro Hara
Suyeon Ji added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Nov 18, 2025, 10:59:44 AM (4 days ago) Nov 18
to Suyeon Ji, Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji
Kentaro Hara voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kentaro Hara
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Suyeon Ji
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Suyeon Ji (Gerrit)
Nov 18, 2025, 10:47:32 PM (4 days ago) Nov 18
to Kentaro Hara, Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Suyeon Ji voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 18, 2025, 11:49:41 PM (4 days ago) Nov 18
to Suyeon Ji, Kentaro Hara, Alexander Cooper, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, jmedle...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Introduce GlobalEventHandlers partial mixin for onbeforexrselect
This patch migrates partial interfaces to an interface mixin to align
with the specification.
Originally, these partial interfaces were introduced as an workaround
for a layering violation between core/ and modules/, since Blink could
not include mixins across those layers.
Now that the IDL compiler supports cross-component mixins[1], the
workaround is no longer needed, and this patch replaces the partial
interfaces with an interface mixin to follow the spec[2].
This CL has no behavior changes.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6968299
[2] https://immersive-web.github.io/dom-overlays/#onbeforexrselect
Bug: 453570181, 1109272
Change-Id: Ie4772a96a60f6eae913d4f71e65d0532e95ebcf2
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Commit-Queue: Suyeon Ji <zees...@gmail.com>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1546958}
Files:
- M third_party/blink/renderer/bindings/idl_in_modules.gni
- D third_party/blink/renderer/modules/xr/document_xr.idl
- R third_party/blink/renderer/modules/xr/global_event_handlers_onbeforexrselect.idl
- M third_party/blink/renderer/modules/xr/global_event_handlers_xr.h
- D third_party/blink/renderer/modules/xr/html_element_xr.idl
- D third_party/blink/renderer/modules/xr/mathml_element_xr.idl
- D third_party/blink/renderer/modules/xr/window_xr.idl
Change size: M
Delta: 7 files changed, 2 insertions(+), 58 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Cooper, +1 by Kentaro Hara
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages