SpeculationMeasurement - renderer-side preconnect [chromium/src : main]
0 views
Skip to first unread message
Yoav Weiss (@Shopify) (Gerrit)
Jun 22, 2026, 2:31:27 AM (8 days ago) Jun 22
to Barry Pollard, Hiroki Nakagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Attention needed from Barry Pollard and Hiroki Nakagawa
Yoav Weiss (@Shopify) voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Barry Pollard
- Hiroki Nakagawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Barry Pollard (Gerrit)
Jun 22, 2026, 6:09:11 AM (8 days ago) Jun 22
to Yoav Weiss (@Shopify), Hiroki Nakagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Attention needed from Hiroki Nakagawa and Yoav Weiss (@Shopify)
Barry Pollard added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/timing/preconnect_data.idl
Line 18, Patchset 6 (Latest):
readonly attribute boolean earlyHints;Barry Pollard . unresolved
The public API is `earlyhint` (all lower case, no s at end). Should the interface be the same?
Note you've already used `earlyHints` for preload so if we do change here, then should change there too.
File third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-preconnect.tentative.html
Line 42, Patchset 6 (Latest):
assert_false(entry.earlyHints,Barry Pollard . unresolved
Oh is it `earlyHints` after all? In which case the spec is incorrect?
https://github.com/WICG/speculative_load_measurement/blob/main/README.md#api-design
Related details
Attention is currently required from:
- Hiroki Nakagawa
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Jun 22, 2026, 6:24:56 AM (8 days ago) Jun 22
to Barry Pollard, Hiroki Nakagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Attention needed from Barry Pollard and Hiroki Nakagawa
Yoav Weiss (@Shopify) added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/timing/preconnect_data.idl
Line 18, Patchset 6 (Latest):
readonly attribute boolean earlyHints;Barry Pollard . unresolved
The public API is `earlyhint` (all lower case, no s at end). Should the interface be the same?
Note you've already used `earlyHints` for preload so if we do change here, then should change there too.
Yoav Weiss (@Shopify)
I think it makes sense to align on the spec (both this and preloads)
Related details
Attention is currently required from:
- Barry Pollard
- Hiroki Nakagawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroki Nakagawa (Gerrit)
Jun 23, 2026, 4:58:24 AM (7 days ago) Jun 23
to Yoav Weiss (@Shopify), Barry Pollard, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Attention needed from Barry Pollard and Yoav Weiss (@Shopify)
Hiroki Nakagawa voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hiroki Nakagawa
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/core/loader/preload_helper.cc
Line 381, Patchset 6 (Latest):
params.cross_origin != kCrossOriginAttributeAnonymous;Hiroki Nakagawa . unresolved
Can we move this into the if-body (line 384-386) to narrow down the scope of this variable, or keep it inlined in Preconnect() call like the original code?
Related details
Attention is currently required from:
- Barry Pollard
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Jun 23, 2026, 8:43:13 AM (7 days ago) Jun 23
to Hiroki Nakagawa, Barry Pollard, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Attention needed from Barry Pollard
Yoav Weiss (@Shopify) added 3 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/loader/preload_helper.cc
Line 381, Patchset 6:
params.cross_origin != kCrossOriginAttributeAnonymous;Hiroki Nakagawa . resolved
Can we move this into the if-body (line 384-386) to narrow down the scope of this variable, or keep it inlined in Preconnect() call like the original code?
Yoav Weiss (@Shopify)
Done
File third_party/blink/renderer/core/timing/preconnect_data.idl
Yoav Weiss (@Shopify)The public API is `earlyhint` (all lower case, no s at end). Should the interface be the same?
Note you've already used `earlyHints` for preload so if we do change here, then should change there too.
I think it makes sense to align on the spec (both this and preloads)
Yoav Weiss (@Shopify)
Done
File third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-preconnect.tentative.html
Oh is it `earlyHints` after all? In which case the spec is incorrect?
https://github.com/WICG/speculative_load_measurement/blob/main/README.md#api-design
Yoav Weiss (@Shopify)
Done
Related details
Attention is currently required from:
- Barry Pollard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Jun 23, 2026, 8:43:39 AM (7 days ago) Jun 23
to Hiroki Nakagawa, Barry Pollard, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Attention needed from Barry Pollard
Yoav Weiss (@Shopify) voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Barry Pollard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 23, 2026, 8:54:48 AM (7 days ago) Jun 23
to Yoav Weiss (@Shopify), Hiroki Nakagawa, Barry Pollard, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Attention needed from Barry Pollard
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60834.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Barry Pollard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 23, 2026, 9:48:09 AM (7 days ago) Jun 23
to Yoav Weiss (@Shopify), Blink W3C Test Autoroller, Hiroki Nakagawa, Barry Pollard, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/timing/preconnect_data.cc
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/renderer/core/timing/preconnect_data.idl
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/renderer/core/timing/preconnect_data.h
Insertions: 3, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-preconnect.tentative.html
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/renderer/core/loader/preload_helper.cc
Insertions: 2, Deletions: 3.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
SpeculationMeasurement - renderer-side preconnect
https://github.com/WICG/speculative_load_measurement/issues/14 showed
a use case to also expose preconnects through the SpeculationMeasurement
API. This CL implements that for renderer-side preconnects.
Change-Id: I2a3ccf87bfafb5224c46c70395a6b278752bd251
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Commit-Queue: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1650958}
Files:
- M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
- M third_party/blink/renderer/bindings/generated_in_core.gni
- M third_party/blink/renderer/bindings/idl_in_core.gni
- M third_party/blink/renderer/core/loader/preload_helper.cc
- M third_party/blink/renderer/core/timing/build.gni
- A third_party/blink/renderer/core/timing/cross_origin_mode_converter.h
- A third_party/blink/renderer/core/timing/preconnect_data.cc
- A third_party/blink/renderer/core/timing/preconnect_data.h
- A third_party/blink/renderer/core/timing/preconnect_data.idl
- M third_party/blink/renderer/core/timing/preload_data.cc
- M third_party/blink/renderer/core/timing/speculation_data.cc
- M third_party/blink/renderer/core/timing/speculation_data.h
- M third_party/blink/renderer/core/timing/speculation_data.idl
- M third_party/blink/renderer/core/timing/window_performance.cc
- M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
- M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
- A third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-preconnect.tentative.html
- M third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/support/speculation-measurement-utils.js
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Change size: L
Delta: 19 files changed, 366 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hiroki Nakagawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 23, 2026, 11:32:45 AM (6 days ago) Jun 23
to Chromium LUCI CQ, Yoav Weiss (@Shopify), Hiroki Nakagawa, Barry Pollard, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60834
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages