Use USVString instead of DOMString/CSSOMString in css/cssom [chromium/src : main]

0 views

Skip to first unread message

Suyeon Ji (Gerrit)

unread,

6:58 AM (8 hours ago) 6:58 AM

to Rune Lillesveen, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Rune Lillesveen

Suyeon Ji added 1 comment

Patchset-level comments

File-level comment, Patchset 9:

Suyeon Ji . resolved

Hi, Please take a look. Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

10:42 AM (4 hours ago) 10:42 AM

to Suyeon Ji, Rune Lillesveen, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Suyeon Ji

Rune Lillesveen added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Rune Lillesveen . unresolved

I found this discussion, and I'm unsure what to do here:

https://github.com/w3c/css-houdini-drafts/issues/687

I don't have a deep understanding of the differences. Do we have really good reasons to do this change now?