Introduce NavigatorNetworkInformation mixin for connection [chromium/src : main]
0 views
Skip to first unread message
Suyeon Ji (Gerrit)
Oct 23, 2025, 11:16:29 AM (10 days ago) Oct 23
to Kentaro Hara, Tarun Bansal, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org
Attention needed from Kentaro Hara and Tarun Bansal
Suyeon Ji added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Kentaro Hara
- Tarun Bansal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Oct 23, 2025, 6:15:02 PM (10 days ago) Oct 23
to Suyeon Ji, Tarun Bansal, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org
Attention needed from Suyeon Ji and Tarun Bansal
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Suyeon Ji
- Tarun Bansal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Suyeon Ji (Gerrit)
Oct 24, 2025, 5:36:50 AM (9 days ago) Oct 24
to Jinho Bang, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org
Attention needed from Jinho Bang
Suyeon Ji added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Jinho Bang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jinho Bang (Gerrit)
Oct 24, 2025, 11:01:40 AM (9 days ago) Oct 24
to Suyeon Ji, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org
Attention needed from Suyeon Ji
Jinho Bang voted![]( "Open in Gerrit")
Attention is currently required from:
- Suyeon Ji
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 24, 2025, 11:49:58 AM (9 days ago) Oct 24
to Suyeon Ji, Jinho Bang, Kentaro Hara, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Introduce NavigatorNetworkInformation mixin for connection
This patch migrates partial interfaces to a interface mixin to align
with the specification.
Originally, these partial interfaces were introduced as a workaround for
a layering violation between core/ and modules/, since Blink could not
include mixins across those layers.
Now that the IDL compiler supports cross-component mixins[1], the
workaround is no longer needed, and this patch replaces the partial
interfaces with an interface mixin to follow the spec[2].
This CL has no behavior changes.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6968299
[2] https://wicg.github.io/netinfo/#navigatornetworkinformation-interface
Bug: 453570181
Change-Id: Ie001f08da80ecd397a673faf417e2522db41c705
Commit-Queue: Jinho Bang <zi...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Jinho Bang <zi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1535052}
Files:
- M third_party/blink/renderer/bindings/idl_in_modules.gni
- M third_party/blink/renderer/modules/netinfo/navigator_network_information.idl
- D third_party/blink/renderer/modules/netinfo/worker_navigator_network_information.idl
Change size: S
Delta: 3 files changed, 7 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jinho Bang, +1 by Kentaro Hara
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages