WTF: Rename LowerASCII() methods to ToAsciiLower() [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Mar 11, 2026, 4:23:07 AM (yesterday) Mar 11
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Nate Chapin, Kevin Babbitt, Dirk Schulze, Menard, Alexis, Stephen Chenney, Christian Biesinger, Raphael Kubo da Costa, AyeAye, ipc-securi...@chromium.org, blink-re...@chromium.org, loading-re...@chromium.org, blink-rev...@chromium.org, feature-me...@chromium.org, apavlo...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, emircan+watch...@chromium.org, mbarowsky+watc...@chromium.org, video-networking...@google.com, dcheng+c...@chromium.org, blink-revie...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, blink-...@chromium.org, lucasrada...@google.com, aleventh...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, jshin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, francisjp...@google.com, webap...@microsoft.com, yigu+...@chromium.org, storage...@chromium.org, abigailbk...@google.com, npm+...@chromium.org, drott+bl...@chromium.org, josiah...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, cblume+im...@chromium.org, dtseng...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieeaa10572246cf5b9f836acc3147e691bcae7de1
Gerrit-Change-Number: 7651260
Gerrit-PatchSet: 4
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Wed, 11 Mar 2026 08:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Mar 11, 2026, 5:30:40 AM (yesterday) Mar 11
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Nate Chapin, Kevin Babbitt, Dirk Schulze, Menard, Alexis, Stephen Chenney, Christian Biesinger, Raphael Kubo da Costa, AyeAye, ipc-securi...@chromium.org, blink-re...@chromium.org, loading-re...@chromium.org, blink-rev...@chromium.org, feature-me...@chromium.org, apavlo...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, emircan+watch...@chromium.org, mbarowsky+watc...@chromium.org, video-networking...@google.com, dcheng+c...@chromium.org, blink-revie...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, blink-...@chromium.org, lucasrada...@google.com, aleventh...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, jshin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, francisjp...@google.com, webap...@microsoft.com, yigu+...@chromium.org, storage...@chromium.org, abigailbk...@google.com, npm+...@chromium.org, drott+bl...@chromium.org, josiah...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, cblume+im...@chromium.org, dtseng...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 09:30:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 11, 2026, 5:38:15 AM (yesterday) Mar 11
    to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, Akihiro Ota, Kentaro Hara, (Julie)Jeongeun Kim, Nate Chapin, Kevin Babbitt, Dirk Schulze, Menard, Alexis, Stephen Chenney, Christian Biesinger, Raphael Kubo da Costa, AyeAye, ipc-securi...@chromium.org, blink-re...@chromium.org, loading-re...@chromium.org, blink-rev...@chromium.org, feature-me...@chromium.org, apavlo...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, emircan+watch...@chromium.org, mbarowsky+watc...@chromium.org, video-networking...@google.com, dcheng+c...@chromium.org, blink-revie...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, blink-...@chromium.org, lucasrada...@google.com, aleventh...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, jshin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, francisjp...@google.com, webap...@microsoft.com, yigu+...@chromium.org, storage...@chromium.org, abigailbk...@google.com, npm+...@chromium.org, drott+bl...@chromium.org, josiah...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, cblume+im...@chromium.org, dtseng...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WTF: Rename LowerASCII() methods to ToAsciiLower()

    This CL renames `LowerASCII()` to `ToAsciiLower()` for consistency with
    the Google C++ style guide and conventions within the codebase.

    The new name `ToAsciiLower` is chosen for the following reasons:
    * ascii_ctype.h has `blink::ToASCIILower()`.
    * The `Ascii` casing (instead of `ASCII`) follows the Google C++ style
      guide for acronyms in names.

    For backward compatibility, `LowerASCII()` is preserved as a deprecated
    inline wrapper that calls the new `ToAsciiLower()` method.

    This CL migrates the existing call sites in `bindings/`, `modules/`, and
    `platform/` to the new name.
    Change-Id: Ieeaa10572246cf5b9f836acc3147e691bcae7de1
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1597606}
    Files:
    • M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
    • M third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
    • M third_party/blink/renderer/modules/accessibility/ax_object.cc
    • M third_party/blink/renderer/modules/accessibility/blink_ax_tree_source.cc
    • M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_state.cc
    • M third_party/blink/renderer/modules/clipboard/clipboard_promise.cc
    • M third_party/blink/renderer/modules/content_extraction/ai_page_content_debug_utils.cc
    • M third_party/blink/renderer/modules/cookie_store/cookie_store.cc
    • M third_party/blink/renderer/modules/credentialmanagement/password_credential.cc
    • M third_party/blink/renderer/modules/encoding/text_decoder.cc
    • M third_party/blink/renderer/modules/encoding/text_decoder_stream.cc
    • M third_party/blink/renderer/modules/encoding/text_encoder.cc
    • M third_party/blink/renderer/modules/manifest/manifest_parser.cc
    • M third_party/blink/renderer/modules/media_capabilities/media_capabilities.cc
    • M third_party/blink/renderer/modules/mediarecorder/media_recorder_handler.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_certificate.cc
    • M third_party/blink/renderer/modules/shared_storage/shared_storage.cc
    • M third_party/blink/renderer/modules/webcodecs/audio_decoder.cc
    • M third_party/blink/renderer/modules/webcodecs/image_decoder_external.cc
    • M third_party/blink/renderer/platform/fonts/font_cache_key.h
    • M third_party/blink/renderer/platform/image-decoders/image_decoder.cc
    • M third_party/blink/renderer/platform/image-encoders/image_encoder_utils.cc
    • M third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_response.cc
    • M third_party/blink/renderer/platform/mhtml/mhtml_parser.cc
    • M third_party/blink/renderer/platform/network/http_parsers.cc
    • M third_party/blink/renderer/platform/network/mime/mime_type_registry.cc
    • M third_party/blink/renderer/platform/network/parsed_content_header_field_parameters.cc
    • M third_party/blink/renderer/platform/peerconnection/webrtc_decoding_info_handler.cc
    • M third_party/blink/renderer/platform/peerconnection/webrtc_encoding_info_handler.cc
    • M third_party/blink/renderer/platform/text/hyphenation/hyphenation_minikin.cc
    • M third_party/blink/renderer/platform/weborigin/scheme_registry.cc
    • M third_party/blink/renderer/platform/wtf/text/atomic_string.cc
    • M third_party/blink/renderer/platform/wtf/text/atomic_string.h
    • M third_party/blink/renderer/platform/wtf/text/string_impl.cc
    • M third_party/blink/renderer/platform/wtf/text/string_impl.h
    • M third_party/blink/renderer/platform/wtf/text/string_impl_test.cc
    • M third_party/blink/renderer/platform/wtf/text/wtf_string.cc
    • M third_party/blink/renderer/platform/wtf/text/wtf_string.h
    Change size: L
    Delta: 42 files changed, 137 insertions(+), 141 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieeaa10572246cf5b9f836acc3147e691bcae7de1
    Gerrit-Change-Number: 7651260
    Gerrit-PatchSet: 5
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages