AWC remove API from unsupported platforms [chromium/src : main]
0 views
Skip to first unread message
Patryk Chodur (Gerrit)
Oct 28, 2025, 9:02:22 AM (5 days ago) Oct 28
to Raphael Kubo da Costa, Kentaro Hara, AyeAye, Andrew Rayskiy, Mike Wasserman, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrew Rayskiy and Mike Wasserman
Patryk Chodur voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patryk Chodur
| Commit-Queue | +1 |
1 comment
File third_party/blink/renderer/modules/awc/additional_windowing_controls.cc
Line 30, Patchset 2:
#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS)Andrew Rayskiy . resolved
Patryk ChodurNah, that's not the right way to go. Just configure the respective build files to only include data on desktop platforms.
Thanks for the link. Done now
Related details
Attention is currently required from:
- Andrew Rayskiy
- Mike Wasserman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Rayskiy (Gerrit)
Oct 28, 2025, 9:08:55 AM (5 days ago) Oct 28
to Patryk Chodur, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Mike Wasserman, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Mike Wasserman and Patryk Chodur
Andrew Rayskiy voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mike Wasserman
- Patryk Chodur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Rayskiy (Gerrit)
Oct 28, 2025, 10:20:50 AM (5 days ago) Oct 28
to Patryk Chodur, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Mike Wasserman, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Mike Wasserman and Patryk Chodur
Andrew Rayskiy voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Mike Wasserman
- Patryk Chodur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Wasserman (Gerrit)
Oct 28, 2025, 7:56:57 PM (5 days ago) Oct 28
to Patryk Chodur, Andrew Rayskiy, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Patryk Chodur
Mike Wasserman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mike Wasserman
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/modules/awc/additional_windowing_controls.cc
Related details
Attention is currently required from:
- Patryk Chodur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patryk Chodur (Gerrit)
Oct 29, 2025, 5:23:27 AM (4 days ago) Oct 29
to Mike Wasserman, Andrew Rayskiy, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Patryk Chodur added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/awc/additional_windowing_controls.cc
Mike Wasserman . resolved
optional nit: keep blank line
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patryk Chodur (Gerrit)
Oct 29, 2025, 6:44:47 AM (4 days ago) Oct 29
to Mike Wasserman, Andrew Rayskiy, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Patryk Chodur voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Oct 29, 2025, 6:51:52 AM (4 days ago) Oct 29
to Patryk Chodur, Mike Wasserman, Andrew Rayskiy, Raphael Kubo da Costa, Kentaro Hara, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/modules/awc/additional_windowing_controls.cc
Insertions: 1, Deletions: 0.
@@ -150,6 +150,7 @@
resolver->Resolve();
}
+
} // namespace
// static
```
Change information
Commit message:
AWC remove API from unsupported platforms
This commit removes the Additional Windowing Controls API from Android
and iOS.
Bug: 40946306
Change-Id: I6b05a39045a50151990b56a5eca390ed5c49442a
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-by: Andrew Rayskiy <green...@google.com>
Commit-Queue: Patryk Chodur <pch...@google.com>
Reviewed-by: Mike Wasserman <m...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1537221}
Files:
- M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
- M third_party/blink/renderer/bindings/idl_in_modules.gni
- M third_party/blink/renderer/modules/BUILD.gn
- M third_party/blink/renderer/modules/awc/additional_windowing_controls.cc
Change size: S
Delta: 4 files changed, 11 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrew Rayskiy, +1 by Mike Wasserman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages