Prepare for v8::MemorySpan cleanup [chromium/src : main]

0 views
Skip to first unread message

Nikolaos Papaspyrou (Gerrit)

unread,
May 18, 2026, 3:27:14 PM (14 hours ago) May 18
to Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Michael Lippautz

Nikolaos Papaspyrou voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic7f632ef3a174531a2bef49a4faef1687b5c375e
Gerrit-Change-Number: 7856564
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Mon, 18 May 2026 19:26:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
3:08 AM (2 hours ago) 3:08 AM
to Nikolaos Papaspyrou, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Nikolaos Papaspyrou

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nikolaos Papaspyrou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic7f632ef3a174531a2bef49a4faef1687b5c375e
Gerrit-Change-Number: 7856564
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Comment-Date: Tue, 19 May 2026 07:08:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
3:09 AM (2 hours ago) 3:09 AM
to Nikolaos Papaspyrou, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Nikolaos Papaspyrou

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Commit-Queue+2

1 comment

Commit Message
Line 12, Patchset 1 (Latest):
Michael Lippautz . unresolved

Can you add a tracking bug?

Open in Gerrit

Related details

Attention is currently required from:
  • Nikolaos Papaspyrou
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic7f632ef3a174531a2bef49a4faef1687b5c375e
    Gerrit-Change-Number: 7856564
    Gerrit-PatchSet: 1
    Gerrit-Owner: Nikolaos Papaspyrou <niko...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Nikolaos Papaspyrou <niko...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 May 2026 07:09:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nikolaos Papaspyrou (Gerrit)

    unread,
    4:20 AM (1 hour ago) 4:20 AM
    to Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Michael Lippautz

    Nikolaos Papaspyrou added 2 comments

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Nikolaos Papaspyrou . resolved

    Thank you!

    Commit Message
    Line 12, Patchset 1:
    Michael Lippautz . resolved

    Can you add a tracking bug?

    Nikolaos Papaspyrou

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Lippautz
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic7f632ef3a174531a2bef49a4faef1687b5c375e
      Gerrit-Change-Number: 7856564
      Gerrit-PatchSet: 2
      Gerrit-Owner: Nikolaos Papaspyrou <niko...@chromium.org>
      Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Comment-Date: Tue, 19 May 2026 08:20:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Michael Lippautz <mlip...@chromium.org>
      satisfied_requirement
      open
      diffy

      Nikolaos Papaspyrou (Gerrit)

      unread,
      4:21 AM (1 hour ago) 4:21 AM
      to Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Michael Lippautz

      Nikolaos Papaspyrou voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Tue, 19 May 2026 08:20:50 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      4:24 AM (1 hour ago) 4:24 AM
      to Nikolaos Papaspyrou, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Unreviewed changes

      1 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      Prepare for v8::MemorySpan cleanup

      A subsequent CL in V8 will perform some cleanup to v8::MemorySpan, to
      better align with std::span. This CL prepares for this change, so that
      existing code in Chromium does not break.

      Bug: 361372981
      Change-Id: Ic7f632ef3a174531a2bef49a4faef1687b5c375e
      Reviewed-by: Michael Lippautz <mlip...@chromium.org>
      Commit-Queue: Nikolaos Papaspyrou <niko...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1632695}
      Files:
      • M third_party/blink/renderer/bindings/core/v8/pass_as_span.h
      Change size: S
      Delta: 1 file changed, 10 insertions(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Michael Lippautz
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic7f632ef3a174531a2bef49a4faef1687b5c375e
      Gerrit-Change-Number: 7856564
      Gerrit-PatchSet: 3
      Gerrit-Owner: Nikolaos Papaspyrou <niko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages