Reland "[heap] Record GrowingMode in GC Cycle UKM" [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Jun 25, 2026, 7:12:44 AM (2 days ago) Jun 25
to Sun Yueru, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Michael Lippautz, Raphael Kubo da Costa, Takashi Sakamoto, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Michael Lippautz and Sun Yueru

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Etienne Pierre-Doray . resolved

PTAL
-rkaplow@ (OOO) -> +yrsun@

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
  • Sun Yueru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4203e6e438759d4d7903ce11c943563ad466dfec
Gerrit-Change-Number: 7977410
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Takashi Sakamoto <ta...@google.com>
Gerrit-Attention: Sun Yueru <yr...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Jun 2026 11:12:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Jun 25, 2026, 7:48:27 AM (2 days ago) Jun 25
to Etienne Pierre-Doray, Sun Yueru, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Raphael Kubo da Costa, Takashi Sakamoto, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Etienne Pierre-Doray and Sun Yueru

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
  • Sun Yueru
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4203e6e438759d4d7903ce11c943563ad466dfec
    Gerrit-Change-Number: 7977410
    Gerrit-PatchSet: 3
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Takashi Sakamoto <ta...@google.com>
    Gerrit-Attention: Sun Yueru <yr...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 11:48:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sun Yueru (Gerrit)

    unread,
    Jun 25, 2026, 10:20:33 AM (2 days ago) Jun 25
    to Etienne Pierre-Doray, Michael Lippautz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Raphael Kubo da Costa, Takashi Sakamoto, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
    Attention needed from Etienne Pierre-Doray

    Sun Yueru voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4203e6e438759d4d7903ce11c943563ad466dfec
    Gerrit-Change-Number: 7977410
    Gerrit-PatchSet: 3
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Takashi Sakamoto <ta...@google.com>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 14:20:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Jun 25, 2026, 11:55:12 AM (2 days ago) Jun 25
    to Sun Yueru, Michael Lippautz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Raphael Kubo da Costa, Takashi Sakamoto, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org

    Etienne Pierre-Doray voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4203e6e438759d4d7903ce11c943563ad466dfec
    Gerrit-Change-Number: 7977410
    Gerrit-PatchSet: 3
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Takashi Sakamoto <ta...@google.com>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 15:55:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 25, 2026, 1:45:04 PM (2 days ago) Jun 25
    to Etienne Pierre-Doray, Sun Yueru, Michael Lippautz, android-bu...@system.gserviceaccount.com, Raphael Kubo da Costa, Takashi Sakamoto, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Reland "[heap] Record GrowingMode in GC Cycle UKM"

    This is a reland of commit 115fe532a838027a6c1dc679441547ae39c3c2a8

    Reason for revert:
    LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5644029657088000

    Fix: landed on v8 side https://crrev.com/c/7972994

    Original change's description:
    > [heap] Record GrowingMode in GC Cycle UKM
    >
    > Growing mode informs on heap limit heuristics.
    > Following https://chromium-review.git.corp.google.com/c/v8/v8/+/7957808
    >
    > Bug: 477484620
    > Change-Id: Ie5da39bf7ca048939660a616ee9d07fbecd521c0
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7962922
    > Reviewed-by: Robert Kaplow <rka...@chromium.org>
    > Reviewed-by: Michael Lippautz <mlip...@chromium.org>
    > Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1649766}
    Bug: 510369060
    Change-Id: I4203e6e438759d4d7903ce11c943563ad466dfec
    Reviewed-by: Michael Lippautz <mlip...@chromium.org>
    Reviewed-by: Sun Yueru <yr...@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1652543}
    Files:
    • M third_party/blink/renderer/bindings/core/v8/v8_metrics.cc
    • M tools/metrics/histograms/metadata/v8/enums.xml
    • M tools/metrics/ukm/ukm.xml
    Change size: S
    Delta: 3 files changed, 14 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Michael Lippautz, +1 by Sun Yueru
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4203e6e438759d4d7903ce11c943563ad466dfec
    Gerrit-Change-Number: 7977410
    Gerrit-PatchSet: 4
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages