[source-phase-imports] Move JS streaming out of BackgroundProcessor [chromium/src : main]
Luis Pardo (Gerrit)
Luis Pardo added 1 comment![]( "Open in Gerrit")
Related details
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Kouhei Ueno added 1 comment![]( "Open in Gerrit")
This CL is quite involved. Can I request a design doc that aids with class diagrams / their responsibilities?
Related details
- Luis Pardo
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Luis Pardo (Gerrit)
Luis Pardo added 1 comment![]( "Open in Gerrit")
This CL is quite involved. Can I request a design doc that aids with class diagrams / their responsibilities?
I'll update the related [design doc](https://docs.google.com/document/d/1J5z96hCpVToQejAHFhEih3xo9QxKl4-CSFPCnwuH1Bk/edit?usp=sharing), the design in that document is now outdated. In the meantime here is a short summary; and it would be great if you could take a first look at the changes in the [next CL](https://chromium-review.googlesource.com/c/chromium/src/+/7212259), particularly those in `module_script_loader.*` and `wasm_module_script.*`.
Before this CL `BackgroundResourceScriptStreamer::BackgroundProcessor` implemented `BackgroundResponseProcessor::MaybeStartProcessingResponse` as well as the specifics of the JS streaming logic: when to allow/suppress streaming, code caching, etc. Now, `BackgroundResourceScriptStreamer::BackgroundProcessor` only implements `BackgroundResponseProcessor::MaybeStartProcessingResponse` and the logic and class members specific to JS streaming are encapsulated in the `BackgroundJSStreamManager` class, created after a JS mime type is received. The next CL introduces `BackgroundWasmStreamManager`, created for a Wasm mime type.
The class members that remain in `BackgroundResourceScriptStreamer::BackgroundProcessor` and referred from `BackgroundJSStreamManager` are those that are set before knowing the response's mime type.
Related details
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Luis Pardo (Gerrit)
Luis Pardo added 1 comment![]( "Open in Gerrit")
Luis PardoThis CL is quite involved. Can I request a design doc that aids with class diagrams / their responsibilities?
I'll update the related [design doc](https://docs.google.com/document/d/1J5z96hCpVToQejAHFhEih3xo9QxKl4-CSFPCnwuH1Bk/edit?usp=sharing), the design in that document is now outdated. In the meantime here is a short summary; and it would be great if you could take a first look at the changes in the [next CL](https://chromium-review.googlesource.com/c/chromium/src/+/7212259), particularly those in `module_script_loader.*` and `wasm_module_script.*`.
Before this CL `BackgroundResourceScriptStreamer::BackgroundProcessor` implemented `BackgroundResponseProcessor::MaybeStartProcessingResponse` as well as the specifics of the JS streaming logic: when to allow/suppress streaming, code caching, etc. Now, `BackgroundResourceScriptStreamer::BackgroundProcessor` only implements `BackgroundResponseProcessor::MaybeStartProcessingResponse` and the logic and class members specific to JS streaming are encapsulated in the `BackgroundJSStreamManager` class, created after a JS mime type is received. The next CL introduces `BackgroundWasmStreamManager`, created for a Wasm mime type.
The class members that remain in `BackgroundResourceScriptStreamer::BackgroundProcessor` and referred from `BackgroundJSStreamManager` are those that are set before knowing the response's mime type.
@kou...@chromium.org I added some descriptions and diagrams to [this doc](https://docs.google.com/document/d/1J5z96hCpVToQejAHFhEih3xo9QxKl4-CSFPCnwuH1Bk/edit?usp=sharing) under the "blink>BackgroundResourceScriptStreamer refactoring" section. Also did a little refactoring to improve this code. PATL.
Related details
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |