Fix crash in ScriptPromiseResolver::ResolveOverridingToCurrentContext() [chromium/src : refs/branch-heads/6478]

0 views

Skip to first unread message

Nate Chapin (Gerrit)

unread,

Jun 21, 2024, 1:33:51 PM (8 days ago) Jun 21

to Srinivas Sista, Tricium, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-revie...@chromium.org

Attention needed from Srinivas Sista

Nate Chapin voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Srinivas Sista

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Srinivas Sista (Gerrit)

unread,

Jun 21, 2024, 1:34:24 PM (8 days ago) Jun 21

to Nate Chapin, Tricium, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-revie...@chromium.org

Srinivas Sista voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 21, 2024, 1:36:28 PM (8 days ago) Jun 21

to Srinivas Sista, Nate Chapin, Tricium, Kentaro Hara, AyeAye, blink-...@chromium.org, blink-revie...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Fix crash in ScriptPromiseResolver::ResolveOverridingToCurrentContext()

It should override first, then check the validity of the ScriptState.
Otherwise, we never check the vaility of the ScriptState we've
overriden to.

(cherry picked from commit 33bd81807b4fb3457c7d6fd4b8cd64cc2ae1e05a)

Fixed: 345275138

Change-Id: I308eaff7c782b62161345cbbf6a48b4392b1a115

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5618491

Commit-Queue: Nate Chapin <jap...@chromium.org>

Reviewed-by: Andrey Kosyakov <ca...@chromium.org>

Auto-Submit: Nate Chapin <jap...@chromium.org>

Commit-Queue: Andrey Kosyakov <ca...@chromium.org>

Cr-Original-Commit-Position: refs/heads/main@{#1313108}

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648305

Reviewed-by: Nate Chapin <jap...@chromium.org>

Commit-Queue: Srinivas Sista <sriniv...@chromium.org>

Cr-Commit-Position: refs/branch-heads/6478@{#1577}

Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}

Files:

M third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h
M third_party/blink/renderer/bindings/core/v8/script_promise_resolver_test.cc

Change size: M

Delta: 2 files changed, 53 insertions(+), 1 deletion(-)

Branch: refs/branch-heads/6478

Submit Requirements:

Code-Review: +1 by Nate Chapin

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages