Use type tags for data stored in V8 internal fields [chromium/src : main]
0 views
Skip to first unread message
Andreas Haas (Gerrit)
Sep 23, 2025, 4:20:43 AM (13 days ago) Sep 23
to Michael Lippautz, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Michael Lippautz
Andreas Haas added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Sep 23, 2025, 12:19:19 PM (13 days ago) Sep 23
to Andreas Haas, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Andreas Haas
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andreas Haas
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Sep 24, 2025, 2:57:26 AM (12 days ago) Sep 24
to Andreas Haas, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Sep 24, 2025, 3:32:50 AM (12 days ago) Sep 24
to Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Michael Lippautz
Andreas Haas voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 24, 2025, 3:36:39 AM (12 days ago) Sep 24
to Andreas Haas, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use type tags for data stored in V8 internal fields
v8::Context::SetAlignedPointerInEmbedderData and
v8::Object::SetAlignedPointerInInternalField both allow to use type
tags. With this CL, type tags are added to all call sites of these
methods.
Bug: 433909571
Change-Id: Ia0b08e3884c7582c8b3955af35bfb025d6aa4c10
Commit-Queue: Andreas Haas <ah...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519812}
Files:
- M gin/per_context_data.cc
- M gin/public/gin_embedders.h
- M gin/wrappable.cc
- M gin/wrapper_info.cc
- M third_party/blink/renderer/platform/bindings/script_state.cc
- M third_party/blink/renderer/platform/bindings/script_state.h
- M third_party/blink/renderer/platform/bindings/wrapper_type_info.h
Change size: M
Delta: 7 files changed, 38 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages